From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Y2X4GTJPmGq/LB8AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 12:30:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bap0jhWe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YLXkBJVg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OyrV6WMl; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bl5VTeiw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5443C1E033; Wed, 02 Sep 2026 12:30:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B0BA1E033 for ; Wed, 02 Sep 2026 12:30:41 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D05A34BAE7D1 for ; Wed, 2 Sep 2026 16:30:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D05A34BAE7D1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bap0jhWe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YLXkBJVg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OyrV6WMl; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bl5VTeiw Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 17FC14BA2E06 for ; Wed, 2 Sep 2026 16:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17FC14BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17FC14BA2E06 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788366614; cv=none; b=kqmDINaFTi62JP9d1Iq5OHTYBNYnwlyjSrZKhRwlfY3HWRYR1CAAxZTcf4dE/VZG0xAkshUEz9ElRki1bqwPbQ7JbxJLANU9Z81eP/KNjgaG3MJlFLwvNGJ4xRSCM8HXeLJtiRH/7kaz0ajbbrfU1WhQJ8giqBO9yTo5h6bxalY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788366614; c=relaxed/simple; bh=muyTpXfjmIeYr0DdJYDOEB3cwuOl5sE8QApGBixlOys=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=DICEs3LG5pb61efqAFKnTq0KISFGMvkdHAlOy6IrTO/EJXnN+LNiuzvQqoOMljPWKHKjWneigOfVTIZJpGSTn37BUg3vzDKwajer8jX0uSQbUZkRWmzqmfE5AGDzLDww/761k/aowJcbS9QdzmRlkfvXG2YyBJVvZvLot5vIKqY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Bap0jhWe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YLXkBJVg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OyrV6WMl; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Bl5VTeiw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17FC14BA2E06 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ED9071F7D6 for ; Wed, 2 Sep 2026 16:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788366609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMn0BKlM8IwoY5/liA2PO4soAp88V4sENNJa6JRSaUw=; b=Bap0jhWeX9viK0r3KPYMiCCgomcCrIjqaHCDxxID3+a9dUu0IMUAZvG32GlCkqpHQrJrQZ hBk51DeTqtkpHn0DC1SsBra+keFtWx0RiIJNyEw5Y54aIysFTetf+IUIfYEjZFgH/Wycb+ bY9G5mqW1fZ7MV1Yw+TLlHCxI/cVxfE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788366609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMn0BKlM8IwoY5/liA2PO4soAp88V4sENNJa6JRSaUw=; b=YLXkBJVgze/odOgjGc+HgcAqkn/4lE4sBZuGYW3wVfjGV26g4TrAUIs12PkGIE69dh8lRG XTL3Z/YErfVfSVCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OyrV6WMl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Bl5VTeiw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788366605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMn0BKlM8IwoY5/liA2PO4soAp88V4sENNJa6JRSaUw=; b=OyrV6WMl0M2S06SLlIKQplRcdX98+36Bei7ilBGQ7U/TNQ0mox0fc4pac6S0uP077dvGMt HwSPWa5K36HB4F4MHSdAfWQ2/Y9jm3Wk21FYwLuT03gQbOjFPQxOBh0tZFfWTi3wwFyXgo lmNPGTmqoaep6Hre3PZV+DazKQ+Wlus= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788366605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMn0BKlM8IwoY5/liA2PO4soAp88V4sENNJa6JRSaUw=; b=Bl5VTeiwFF5I3rJE5ikDCbDKlmaQgHVJMtULBCRkkC9cTYoqxcz9ucfspfiyyKSzt7gKo+ 28i1Omqt3sRyVmCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9CDD1136E6 for ; Wed, 2 Sep 2026 16:30:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zAgyJAxPmGqZEgAAD6G6ig (envelope-from ) for ; Wed, 02 Sep 2026 16:30:04 +0000 Message-ID: <81fbd404-d993-4b2b-ba28-4243ba22e2a3@suse.de> Date: Wed, 2 Sep 2026 18:30:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PING][PATCH] [gdb/tui] Don't disassemble non-code sections and section holes From: Tom de Vries To: gdb-patches@sourceware.org References: <20260819143514.2221499-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260819143514.2221499-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ED9071F7D6 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,plt:email,gdb.tui:url]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/19/26 4:35 PM, Tom de Vries wrote: > I was investigating TUI behaviour on ppc64-linux using the executable from > test-case gdb.tui/basic.exp, and after scrolling in the asm window ended up > with: > ... > +----------------------------------------------------------------------------+ > | 0x920 <__libc_start_main@plt+4> b 0x8f0 <__glink_PLTresolve> | > | 0x924 <__gmon_start__@plt> li r0,1 | > | 0x928 <__gmon_start__@plt+4> b 0x8f0 <__glink_PLTresolve> | > | 0x92c <__cxa_finalize@plt> li r0,2 | > | 0x930 <__cxa_finalize@plt+4> b 0x8f0 <__glink_PLTresolve> | > | 0x934 <._fini> mflr r0 | > | 0x938 <._fini+4> std r0,16(r1) | > | 0x93c <._fini+8> stdu r1,-112(r1) | > | 0x940 <._fini+12> addi r1,r1,112 | > | 0x944 <._fini+16> ld r0,16(r1) | > | 0x948 <._fini+20> mtlr r0 | > | 0x94c <._fini+24> blr | > | 0x950 <_IO_stdin_used> .long 0x20001 | > | 0x954 .long 0x11b033b | > | 0x958 .long 0x18 | > | 0x95c .long 0x2 | > | 0x960 .long 0xffffff60 | > | 0x964 .long 0x48 | > | 0x968 .long 0xffffff9c | > | 0x96c .long 0x30 | > +----------------------------------------------------------------------------+ > exec No process (asm) In: L?? PC: ?? > (gdb) > ... > > The view corresponds to this objdump -D output: > ... > Disassembly of section .text: > > ... > > 000000000000091c <__libc_start_main@plt>: > 91c: 38 00 00 00 li r0,0 > 920: 4b ff ff d0 b 8f0 <__glink_PLTresolve> > > 0000000000000924 <__gmon_start__@plt>: > 924: 38 00 00 01 li r0,1 > 928: 4b ff ff c8 b 8f0 <__glink_PLTresolve> > > 000000000000092c <__cxa_finalize@plt>: > 92c: 38 00 00 02 li r0,2 > 930: 4b ff ff c0 b 8f0 <__glink_PLTresolve> > > Disassembly of section .fini: > > 0000000000000934 <._fini>: > 934: 7c 08 02 a6 mflr r0 > 938: f8 01 00 10 std r0,16(r1) > 93c: f8 21 ff 91 stdu r1,-112(r1) > 940: 38 21 00 70 addi r1,r1,112 > 944: e8 01 00 10 ld r0,16(r1) > 948: 7c 08 03 a6 mtlr r0 > 94c: 4e 80 00 20 blr > > Disassembly of section .rodata: > > 0000000000000950 <_IO_stdin_used>: > 950: 00 02 00 01 .long 0x20001 > > Disassembly of section .eh_frame_hdr: > > 0000000000000954 <__GNU_EH_FRAME_HDR>: > 954: 01 1b 03 3b .long 0x11b033b > 958: 00 00 00 18 .long 0x18 > 95c: 00 00 00 02 .long 0x2 > 960: ff ff ff 60 .long 0xffffff60 > 964: 00 00 00 48 .long 0x48 > 968: ff ff ff 9c .long 0xffffff9c > 96c: 00 00 00 30 .long 0x30 > ... > > ISTM that we should not be disassembling the .rodata section. > > My first thought was to require tui_disassemble to stay in the same section, > but after thinking about it a bit more decided that that was too restrictive, > and instead went for requiring that we stay in code sections. > > So, I came up with this fix: > ... > struct obj_section *section = find_pc_section (pc); > if (section != nullptr > && (bfd_section_flags (section->the_bfd_section) & SEC_CODE) == 0) > return pc; > ... > > Then I stumbled on PR tui/34399, which reports not being able to scroll back > up after scrolling down. The problem there is that we disassemble code from a > section hole (0x401034-0x402000): > ... > Section Headers: > [Nr] Name Type Address Offset > Size EntSize Flags Link Info Align > [ 0] NULL 0000000000000000 00000000 > 0000000000000000 0000000000000000 0 0 0 > [ 1] .note.gnu.pr[...] NOTE 0000000000400190 00000190 > 0000000000000030 0000000000000000 A 0 0 8 > [ 2] .note.gnu.bu[...] NOTE 00000000004001c0 000001c0 > 0000000000000024 0000000000000000 A 0 0 4 > [ 3] .text PROGBITS 0000000000401000 00001000 > 0000000000000034 0000000000000000 AX 0 0 1 > [ 4] .rodata PROGBITS 0000000000402000 00002000 > 0000000000000006 0000000000000000 A 0 0 1 > [ 5] .symtab SYMTAB 0000000000000000 00002008 > 0000000000000078 0000000000000018 6 1 8 > [ 6] .strtab STRTAB 0000000000000000 00002080 > 0000000000000019 0000000000000000 0 0 1 > [ 7] .shstrtab STRTAB 0000000000000000 00002099 > 000000000000004f 0000000000000000 0 0 1 > Key to Flags: > W (write), A (alloc), X (execute), M (merge), S (strings), I (info), > L (link order), O (extra OS processing required), G (group), T (TLS), > C (compressed), x (unknown), o (OS specific), E (exclude), > D (mbind), l (large), p (processor specific) > ... > and once we call tui_find_backward_disassembly_start_address with an address > ADDR for which find_pc_section (ADDR - 1) == nullptr, we are stuck in the > section hole. > > Fix this by not disassembling section holes. > > This is achieved by slightly modifying the earlier fix: > ... > if (section == nullptr > || (bfd_section_flags (section->the_bfd_section) & SEC_CODE) == 0) > return pc; > ... > Ping. Thanks, - Tom > Tested on x86_64-linux and ppc64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34399 > --- > gdb/tui/tui-disasm.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c > index 5c68312a91b..085a6c2903e 100644 > --- a/gdb/tui/tui-disasm.c > +++ b/gdb/tui/tui-disasm.c > @@ -112,6 +112,15 @@ tui_disassemble (struct gdbarch *gdbarch, > { > tui_asm_line tal; > > + /* Don't disassemble: > + - non-code sections (not appropriate for disassembly window), and > + - section holes (otherwise we can get stuck, unable to scroll back to > + the section before the section hole). */ > + struct obj_section *section = find_pc_section (pc); > + if (section == nullptr > + || (bfd_section_flags (section->the_bfd_section) & SEC_CODE) == 0) > + return pc; > + > /* Save the instruction address. */ > tal.addr = pc; > > > base-commit: 4ed310516eb76cbf650523a53f733060d3ae71b9