From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53220 invoked by alias); 9 Oct 2017 14:49:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53187 invoked by uid 89); 9 Oct 2017 14:49:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 14:49:50 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v99EnfTV012729 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 9 Oct 2017 10:49:46 -0400 Received: from [10.0.0.11] (cable-192.222.251.162.electronicbox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9FD5E1E523; Mon, 9 Oct 2017 10:49:41 -0400 (EDT) Subject: Re: [PATCH 1/3] gdbserver: Use std::list for all_dlls To: Pedro Alves , gdb-patches@sourceware.org References: <20171009143036.10215-1-simon.marchi@polymtl.ca> <20171009143036.10215-2-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <81d9eff8-140f-dce2-3689-f7c355ff7c11@polymtl.ca> Date: Mon, 09 Oct 2017 14:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 9 Oct 2017 14:49:41 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00209.txt.bz2 On 2017-10-09 10:44 AM, Pedro Alves wrote: > On 10/09/2017 03:30 PM, Simon Marchi wrote: > >> diff --git a/gdb/gdbserver/dll.h b/gdb/gdbserver/dll.h >> index 39e5eb0653..52f924bc85 100644 >> --- a/gdb/gdbserver/dll.h >> +++ b/gdb/gdbserver/dll.h >> @@ -18,17 +18,15 @@ >> #ifndef DLL_H >> #define DLL_H >> >> +#include >> + >> struct dll_info >> { >> - /* This must appear first. See inferiors.h. >> - The list iterator functions assume it. */ >> - struct inferior_list_entry entry; >> - >> char *name; >> CORE_ADDR base_addr; >> }; >> >> -extern struct inferior_list all_dlls; >> +extern std::list all_dlls; > > Is there a reason for making this a list of dll_info pointers > instead of a list of dll_info objects? If you make this a list of > objects, then each list node + dll_info is allocated in one go, > very much like the current code. With a list of pointers, you > have an extra allocation/indirection for each dll_info (one for > node + pointer, another for the dll_info pointee). No reason, except that I thought this was a reasonnable intermediary step. I'll try doing as you say, it's probably not too long. Simon