From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5nvuGxXjll8PIgAAWB0awg (envelope-from ) for ; Mon, 26 Oct 2020 10:54:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 656BD1F08D; Mon, 26 Oct 2020 10:54:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B45DC1E552 for ; Mon, 26 Oct 2020 10:54:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5BA20393C843; Mon, 26 Oct 2020 14:54:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5BA20393C843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603724052; bh=ToWNtU7Qxkg1aFnNWPkAuD7ZCh00VvHO/2cVSY/gVeM=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fNpnh9R1VdWxr9IhGNhT1kmmV33dDrhvm6klA663gWkMoB4nyAYMxm+T3u87XOjuf qk87tCYzZIdRMfpU09+4beG1j6/7BZoXhM2CHw1QWzYDqGWNtfszs6EOV/rCR552cq 1STotmzdoDskeliFAp6vtXSdWDCAjc+Uaxnl1zYM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7729B385782D for ; Mon, 26 Oct 2020 14:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7729B385782D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 09QEs3Ye001610 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Oct 2020 10:54:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 09QEs3Ye001610 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 43E3F1E552; Mon, 26 Oct 2020 10:54:03 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS To: Tom de Vries , gdb-patches@sourceware.org References: <20201026090134.GA27913@delia> Message-ID: <81c4eda5-471c-8c6c-d995-590354de87b9@polymtl.ca> Date: Mon, 26 Oct 2020 10:54:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201026090134.GA27913@delia> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 26 Oct 2020 14:54:04 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-26 5:01 a.m., Tom de Vries wrote: > Hi, > > When running test-case gdb.base/corefile.exp with target board readnow, we run > into: > ... > Reading symbols from outputs/gdb.base/corefile/corefile...^M > Expanding full symbols from outputs/gdb.base/corefile/corefile...^M > [New LWP 2293]^M > Core was generated by `outputs/gdb.base/corefile/co'.^M > Program terminated with signal SIGABRT, Aborted.^M > --Type for more, q to quit, c to continue without paging--\ > FAIL: gdb.base/corefile.exp: (timeout) starting with -core > ... > > In commit bd447abb24 "Make gdb.base/corefile.exp work on terminals with few > rows", pagination (in the same test-case) is prevented using: > ... > set stty_init "rows 25 cols 80" > ... > but this doesn't work in our case because using -readnow adds an extra line > "Expanding full symbols". > > The test passes when increasing rows to 26. However, increasing the rows by > some n only fixes the problem for n lines, and things will break again if > somehow we end up with n + 1 lines. > > Instead, fix this by setting heigth and width in INTERNAL_GDBFLAGS. This > solution was not chosen in commit bd447abb24 because it doesn't handle > pagination due to the introduction text. But it does handle the pagination > due to the extra "Expanding full symbols", and any other line printed during > and after file loading. > > Tested on x86_64-linux, with and without readnow. > > With -readnow, fixes these FAILs: > ... > FAIL: gdb.base/corefile.exp: (timeout) starting with -core > FAIL: gdb.base/reread-readsym.exp: source reread-readsym.gdb 1 (timeout) > ... > > Any comments? > > Thanks, > - Tom I don't see the failures on Ubuntu 20.04. The set of lines printed when loading the core are probably a bit different depending on the distro, which libraries are loaded, etc. But I think I can reproduce it if I reduce the rows to 20 in stty_init. The patch LGTM. Simon