From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79551 invoked by alias); 20 Jun 2017 11:04:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79355 invoked by uid 89); 20 Jun 2017 11:04:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*RU:HELO, Hx-spam-relays-external:HELO, Tel, tel X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 11:04:28 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2017 04:04:25 -0700 X-ExtLoop1: 1 Received: from wtedesch-mobl.ger.corp.intel.com (HELO [10.62.146.24]) ([10.62.146.24]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jun 2017 04:04:24 -0700 Subject: Re: [PATCH 5/5] Add support for Intel PKRU register to GDB and GDBserver. To: Yao Qi References: <1485954205-18536-1-git-send-email-michael.sturm@intel.com> <1485954205-18536-6-git-send-email-michael.sturm@intel.com> <86a85355wz.fsf@gmail.com> <65548273-a6dc-5b74-f1b2-81d0a92c3a91@intel.com> <86wp8653bq.fsf@gmail.com> Cc: Simon Marchi , "Sturm, Michael" , "mark.kettenis@xs4all.nl" , "palves@redhat.com" , "eliz@gnu.org" , "gdb-patches@sourceware.org" From: "Tedeschi, Walfred" Message-ID: <81baa969-0663-b65d-307e-c5f09bcb63a7@intel.com> Date: Tue, 20 Jun 2017 11:04:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <86wp8653bq.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00565.txt.bz2 CgpBbSA2LzIwLzIwMTcgdW0gMTI6MDMgUE0gc2NocmllYiBZYW8gUWk6Cj4g IlRlZGVzY2hpLCBXYWxmcmVkIiA8d2FsZnJlZC50ZWRlc2NoaUBpbnRlbC5j b20+IHdyaXRlczoKPgo+PiBNYXkgaSBhc2sgeW91IHRvIGNyZWF0ZSBhIHRl bXBvcmFyeSBicmFuY2ggZm9yIHRoaXMgcGF0Y2ggc2VyaWVzLgo+PiBNeSBp bnRlbnRpb24gaXMgdG8gYXBwbHkgYW5kIHRlc3QgYXJvdW5kIGluIHNvbWUg Y29uZmlndXJhdGlvbnMgd2UgaGF2ZS4KPiBJdCBpcyB1c2Vycy9xaXlhby90 YXJnZXQtZGVzYy0yCgpZYW8sCgpUaGFua3MhCgpCZXN0IHJlZ2FyZHMsCi9G cmVkCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBBZGRyZXNz OiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdlcm1hbnkK VGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFuYWdpbmcg RGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgQ2hyaXN0aWFuIExh bXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29yeSBCb2Fy ZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVuaWNoCkNvbW1l cmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVuIEhSQiAxODY5 MjgK >From gdb-patches-return-139946-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jun 20 11:09:39 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 100126 invoked by alias); 20 Jun 2017 11:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100090 invoked by uid 89); 20 Jun 2017 11:09:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 11:09:35 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 985E9C04D294; Tue, 20 Jun 2017 11:09:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 985E9C04D294 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 985E9C04D294 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 001A7867BA; Tue, 20 Jun 2017 11:09:33 +0000 (UTC) Subject: Re: [PATCH 10/25] Adjust code generated by regformats/regdat.sh To: Yao Qi , gdb-patches@sourceware.org References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-11-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <92ca03ca-e06d-09fc-7243-e52dd29edcef@redhat.com> Date: Tue, 20 Jun 2017 11:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1497256916-4958-11-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00566.txt.bz2 Content-length: 805 On 06/12/2017 09:41 AM, Yao Qi wrote: > regformats/regdat.sh generate some *-generated.c files when GDBserver > is built. Each .c file has some static variables, which are only used > within function init_registers_XXX, like this, > > static struct reg regs_i386_linux[] = { > { "eax", 0, 32 }, > { "ecx", 32, 32 }, > ... > }; > > static const char *expedite_regs_i386_linux[] = { "ebp", "esp", "eip", 0 }; > static const char *xmltarget_i386_linux = "i386-linux.xml"; > > void > init_registers_i386_linux (void) > { > ... > } > > This patch moves these static variables' definitions to function > init_registers_XXX, so the generated files look like this, > The rationale misses stating why is this better than the status quo. I presume this helps following patches? Thanks, Pedro Alves