From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PfVOLB6JjGpaJD0AWB0awg (envelope-from ) for ; Mon, 24 Aug 2026 14:10:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dymkRBFJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nAvAXF8l; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CBx7pQfI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=20NAzgQ7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C34B1E033; Mon, 24 Aug 2026 14:10:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A98701E033 for ; Mon, 24 Aug 2026 14:10:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C7C7B4BB24E4 for ; Mon, 24 Aug 2026 18:10:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7C7B4BB24E4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dymkRBFJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nAvAXF8l; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CBx7pQfI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=20NAzgQ7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id B9CDE4BB24E4 for ; Mon, 24 Aug 2026 18:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9CDE4BB24E4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9CDE4BB24E4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787595009; cv=none; b=jKIJHPocJF38rX339DDFtX7/OYlqM2izBbKaj3CCMBQKdbz/Syj8MAdeQkvPPo8wLXFJBpbOtHbzfcLwqNCQc4XMpZ/qWzbRtROvtq/pNRz0yBW1H10D80UIt1PppePw6HiZEpMtTjtSixfTQFnSCvpHGZEIz3X3uI6QWuQqRZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787595009; c=relaxed/simple; bh=W7usxnUabCCpWx/CGdbdM3QiYFmKY9TNO7flrXDTNF4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=P3le4W4CDI3XuhDhegdFTv38+Na7AcqBp0bwMCBCPjg36SFYpE48ksCzd+zBQhP9UWmI5uqnI9xjBxIYGCuvav5PJy+zfakI3O/1UHL7QL4T6pVKDQXVcLpKtqd4e6N8SIgtt0nvqAhHI61vg8soqzPDUVrTpAQabMjhGyPwbGY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dymkRBFJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nAvAXF8l; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CBx7pQfI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=20NAzgQ7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9CDE4BB24E4 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 471EB869F0; Mon, 24 Aug 2026 18:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787595003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MR4Ce/ct2spvMvCsPtFozgy+G/198bwYOX0dgnBNQ5c=; b=dymkRBFJneLRYoiy471UnsNoeE6IusxoZCkLNLs153yrdJj40JfysBh57zNH5ug7l7RKlF IiIvQmy2jt9ZcpsJPMEXAzCy/CXjkLFRxXBg4leBRXjdTAkwq8SL9XR/+04JTCiJYrY+OT UGjW6homfY+zU5WoEQbnBj8R34ihcgc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787595003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MR4Ce/ct2spvMvCsPtFozgy+G/198bwYOX0dgnBNQ5c=; b=nAvAXF8lHL1hiAPuB/sGz9Rz9cKR20W6jqeHtcmmOAWZFAA+ETSfVq8Y9+6gFQSLHeYlYA OtdtzoT4edIHdRDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CBx7pQfI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=20NAzgQ7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787594999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MR4Ce/ct2spvMvCsPtFozgy+G/198bwYOX0dgnBNQ5c=; b=CBx7pQfIMrlNZSfg/fojnQYl1by99zDffbj12jtIIjlgGWtGaswtnQc5ZXkdxBxa/MC2Dt azjJKGH6CGEeUHVBwBhSjN9aycETkCSkW2dflsNcwI1YQSwYr2jUGCJHOEIrVRLToAV2Z/ RUCTxiIU07sgN5Leo23svmeg8McnRUs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787594999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MR4Ce/ct2spvMvCsPtFozgy+G/198bwYOX0dgnBNQ5c=; b=20NAzgQ7kRj/2yWuGf4vwWnbzRt/88nJXEZPx/7S0V4rul6Xc+ciyTlhr/jzI0RlhaYPwY +DUXBXbWhlF5kfBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2CE0C13332; Mon, 24 Aug 2026 18:09:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Sd26CfeIjGrCbQAAD6G6ig (envelope-from ); Mon, 24 Aug 2026 18:09:59 +0000 Message-ID: <816ab45b-4814-4f01-a2f9-dde7066a32ff@suse.de> Date: Mon, 24 Aug 2026 20:09:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] Fix weird quoting in stap-probe.c To: Eli Zaretskii , Tom Tromey Cc: gdb-patches@sourceware.org References: <20260822-no-backquotes-in-strings-v1-0-0b035ad036a3@tromey.com> <20260822-no-backquotes-in-strings-v1-3-0b035ad036a3@tromey.com> <86mrudwj97.fsf@gnu.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <86mrudwj97.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 471EB869F0 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[tromey.com:email,suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/23/26 6:31 AM, Eli Zaretskii wrote: >> From: Tom Tromey >> Date: Sat, 22 Aug 2026 14:30:05 -0600 >> Cc: Tom Tromey >> >> I found some code in stap-probe.c that split the quoting in a strange >> way: >> >> warning (_("unrecognized bitness %s%c' for probe `%s'"), >> got_minus ? "`-" : "`", *cur, >> >> Here the leading ` is not part of the format string. I found this odd >> and so I split this fix out into its own patch. > > This changes the quoting style of "-7" and the like. As the test > suite shows, it was previously quoted as `-7'. Is there a good reason > for this change? I googled this a bit, and came across ( https://www.gnu.org/prep/standards/html_node/Quote-Characters.html#Quote-Characters ): ... Although GNU programs traditionally used 0x60 (‘`’) for opening and 0x27 (‘'’) for closing quotes, nowadays quotes ‘`like this'’ are typically rendered asymmetrically, so quoting ‘"like this"’ or ‘'like this'’ typically looks better. ... > I'm not sure I understand what is weird about this > quoting or ` not being part of the format string. Is this just a > style-preference thing? If we'd leave the quoting style unchanged, I would have preferred: ... warning (_("unrecognized bitness `%s%c' for probe `%s'"), got_minus ? "-" : "", *cur, ... which I find easier to read. Thanks, - Tom