From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30033 invoked by alias); 1 Aug 2019 17:30:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28948 invoked by uid 89); 1 Aug 2019 17:30:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 17:30:28 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5204E1E05C; Thu, 1 Aug 2019 13:30:16 -0400 (EDT) Subject: Re: [PATCH] Include s12z-opc.h using ../opcodes. To: Christian Biesinger , gdb-patches@sourceware.org References: <20190801170141.198456-1-cbiesinger@google.com> <20190801172647.64620-1-cbiesinger@google.com> From: Simon Marchi Message-ID: <814c05fb-299d-8d95-fb0b-c8cde820b0d6@simark.ca> Date: Thu, 01 Aug 2019 17:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190801172647.64620-1-cbiesinger@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00024.txt.bz2 On 2019-08-01 1:26 p.m., Christian Biesinger via gdb-patches wrote: > This file exists in binutils-gdb/opcodes, and nothing in Makefile.in adds this > to the include path. Default builds work because in-tree readline adds > binutils-gdb/ to the include path (!). However, this is broken when compiling > with system readline. Yeah, my guess is that the include path is added when using the in-tree readline to make #include "readline/readline.h" work. And it made this include work by chance. > Other files already use this way to include files in opcodes: > ./gdb/lm32-tdep.c:#include "../opcodes/lm32-desc.h" > ./gdb/or1k-tdep.h:#include "../opcodes/or1k-desc.h" > ./gdb/mep-tdep.c:#include "../opcodes/mep-desc.h" > > etc. > > gdb/ChangeLog: > > 2019-08-01 Christian Biesinger > > * s12z-tdep.c: Fix include path for s12z-opc.h. > --- > gdb/s12z-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > index a9d20e809c..a1c085cfbb 100644 > --- a/gdb/s12z-tdep.c > +++ b/gdb/s12z-tdep.c > @@ -30,7 +30,7 @@ > #include "opcode/s12z.h" > #include "trad-frame.h" > #include "remote.h" > -#include "opcodes/s12z-opc.h" > +#include "../opcodes/s12z-opc.h" > > /* Two of the registers included in S12Z_N_REGISTERS are > the CCH and CCL "registers" which are just views into > Thanks, the patch LGTM. Simon