Re: [PATCH v2] Indicate batch mode failures by exiting with nonzero status

Pedro Alves
2018-08-31T14:42:52Z

On 08/31/2018 03:32 PM, Tom Tromey wrote:

> Maybe calling clear_gdb_spawn_id, but I don't know if that's best or if
> there should be something else.

Yeah, if we compare with gdb.base/quit.exp, that is missing
as well as the "remote_close host" call. For the latter, when I last
touched quit.exp, I remember fretting a bit about whether the remote_close
was really necessary, but in the end decided to keep it, I don't recall
exactly if I kept it because I found it's necessary (probably for
remote hosts), or because it doesn't hurt.

Now that I look at gdb.base/quit.exp again, I see that gdb.base/batch-exit-status.exp
can hang forever in the same way that 15763a09d4ae fixed, isn't it?
Gary, any reason you didn't do the "eof" thing here too?

Thanks,
Pedro Alves