From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88702 invoked by alias); 31 Aug 2018 14:42:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88686 invoked by uid 89); 31 Aug 2018 14:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 14:42:51 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 188A57DAC2; Fri, 31 Aug 2018 14:42:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EE6E202706B; Fri, 31 Aug 2018 14:42:47 +0000 (UTC) Subject: Re: [PATCH v2] Indicate batch mode failures by exiting with nonzero status To: Tom Tromey , Gary Benson References: <1534934813-10188-1-git-send-email-gbenson@redhat.com> <8736uviosv.fsf@redhat.com> <87pnxy1u94.fsf@tromey.com> Cc: Sergio Durigan Junior , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <813f3a12-ff85-c48a-aede-7aa89b1ae889@redhat.com> Date: Fri, 31 Aug 2018 14:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87pnxy1u94.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00855.txt.bz2 On 08/31/2018 03:32 PM, Tom Tromey wrote: > Maybe calling clear_gdb_spawn_id, but I don't know if that's best or if > there should be something else. Yeah, if we compare with gdb.base/quit.exp, that is missing as well as the "remote_close host" call. For the latter, when I last touched quit.exp, I remember fretting a bit about whether the remote_close was really necessary, but in the end decided to keep it, I don't recall exactly if I kept it because I found it's necessary (probably for remote hosts), or because it doesn't hurt. Now that I look at gdb.base/quit.exp again, I see that gdb.base/batch-exit-status.exp can hang forever in the same way that 15763a09d4ae fixed, isn't it? Gary, any reason you didn't do the "eof" thing here too? Thanks, Pedro Alves