From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79457 invoked by alias); 29 Jun 2016 10:50:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79378 invoked by uid 89); 29 Jun 2016 10:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 10:50:31 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2EFBC0D6342; Wed, 29 Jun 2016 10:50:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5TAoTZQ000991; Wed, 29 Jun 2016 06:50:30 -0400 Subject: Re: [PATCH v3 31/34] Add testing infrastruture bits for running with MI on a separate UI To: Simon Marchi , gdb-patches@sourceware.org References: <1462538104-19109-1-git-send-email-palves@redhat.com> <1462538104-19109-32-git-send-email-palves@redhat.com> <5772DBCA.4090802@ericsson.com> From: Pedro Alves Message-ID: <813555f3-c917-cd95-6d41-3ec64cad2cf6@redhat.com> Date: Wed, 29 Jun 2016 10:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <5772DBCA.4090802@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00505.txt.bz2 On 06/28/2016 09:19 PM, Simon Marchi wrote: > I think this commit breaks MI tests with native-gdbserver: > > $ make check RUNTESTFLAGS="--target_board=native-gdbserver mi-var-child.exp" > ... > Running /home/emaisin/build/binutils-gdb/gdb/testsuite/../../../../src/binutils-gdb/gdb/testsuite/gdb.mi/mi-var-child.exp ... > can't unset "inferior_spawn_id": no such variable > while executing > "unset inferior_spawn_id" > (procedure "close_gdbserver" line 20) > invoked from within > "close_gdbserver" > ... > I can reproduce this. Odd, maybe I made some last minute change that went untested, not sure. I'll take a look. Thanks, Pedro Alves > I added a few traces to understand what's happening, and it seems that inferior_spawn_id > is being unset at two places: > >>>> gdbserver-support.exp:gdb_exit called >>>> gdb.exp:default_gdb_exit called >>>> mi-support.exp:default_mi_gdb_start called > *** set inferior_spawn_id to gdb_spawn_id exp8 in mi-support.exp:default_mi_gdb_start >>>> gdbserver-support.exp:gdbserver_start called > *** set server_spawn_id in gdbserver-support.exp:gdbserver_start > *** set inferior_spawn_id to server_spawn_id exp9 in gdbserver-support.exp.exp:gdbserver_start >>>> gdbserver-support.exp:gdbserver_start called > *** set server_spawn_id in gdbserver-support.exp:gdbserver_start > *** set inferior_spawn_id to server_spawn_id exp10 in gdbserver-support.exp.exp:gdbserver_start >>>> mi-support.exp:mi_uncatched_gdb_exit called > *** unset inferior_spawn_id in mi-support.exp:mi_uncatched_gdb_exit >>>> gdbserver-support.exp:gdb_exit called > *** unset server_spawn_id in gdbserver-support.exp:close_gdbserver > *** unset inferior_spawn_id in gdbserver-support.exp:close_gdbserver <--- This is the one that breaks. > > The easy way would be to add a "info exists" check before unsetting it, but I don't know if > that would only hide a real problem. > > Simon >