From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21081 invoked by alias); 24 Jan 2020 15:49:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21072 invoked by uid 89); 24 Jan 2020 15:49:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.22) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 15:49:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1579880955; bh=Oqe+2W0E+gD9Q8D3oqpezHR0qQ0R12UGDQJynUzIb4M=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=kUzfMf3PUyyCQb1uNC7qxpGiEl9N0OcXpDGPghqcwVGzYOEVeUH/EJq+Cdda7Ue+5 aGlBou7CywJaCZbxrIOgMPo72R69KQ2aCQLSlUouvPCf2pUmZYwbP1nPmWqeIKWS3h zRfkq2ecA9pIlPmS1676JOKV1UFhmSykEZZ5dRlo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MKbkC-1jBbBX0I04-00KwVB; Fri, 24 Jan 2020 16:49:15 +0100 Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c To: Christian Biesinger Cc: gdb-patches References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> <7432896e-39ec-4a99-cc07-77c684b71644@gmx.com> From: Kamil Rytarowski Message-ID: <8126c811-3416-a4d4-5a01-17776b0df999@gmx.com> Date: Fri, 24 Jan 2020 15:49:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vjmpBXI893G4Ic7ZVkyn8aSwmx499sirc" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00808.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vjmpBXI893G4Ic7ZVkyn8aSwmx499sirc Content-Type: multipart/mixed; boundary="YwUZnqIHBXdQYSRSSFZuPYMFm6Tx83KTW"; protected-headers="v1" From: Kamil Rytarowski To: Christian Biesinger Cc: gdb-patches Message-ID: <8126c811-3416-a4d4-5a01-17776b0df999@gmx.com> Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> <7432896e-39ec-4a99-cc07-77c684b71644@gmx.com> In-Reply-To: --YwUZnqIHBXdQYSRSSFZuPYMFm6Tx83KTW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 4395 On 24.01.2020 16:35, Christian Biesinger via gdb-patches wrote: > On Fri, Jan 24, 2020 at 4:23 PM Kamil Rytarowski wrote: >> >> On 24.01.2020 15:53, Christian Biesinger via gdb-patches wrote: >>> Hi Kamil, >>> >>> I have a related question. NetBSD applied this patch: >>> https://www.mail-archive.com/tech@openbsd.org/msg44100.html >>> >> >> Is this the right link? >=20 > Yeah -- that patch changes a system header at the top and patches GDB > at the bottom. >=20 This is not a change in NetBSD, so it is unrelated. >>> Do you know which NetBSD version that shipped in? Can we apply that >>> patch to GDB as-is or should we attempt to support the older struct >>> layout as well? >> >> Please go for the current FPU layout on NetBSD. Massive ptrace(2) fixes >> were introduced in NetBSD-8 and later. Soon NetBSD 7.x will go EOL >> (after releasing 9.0, rc2 is planned soon). >=20 > OK, great. Thanks. >=20 >> In LLDB we support NetBSD 9.0 or newer. In GDB we should keep the same >> minimal requirements and deal with older NetBSD versions (if at all) >> with downstream patches. >> >> We have got a pile of local GDB patches. >=20 > OK. Maybe I should look through those at some point... I was > surprised that NetBSD apparently has an oldish GDB if > http://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/gdb/README.html > is correct (8.1) >=20 >> There is also a functional gdbserver implementation on NetBSD/amd64 and >> I intend to upstream it. (Help wanted! Would you be interested in this >> and in upstreaming?) >> >> The patches are located here: >> >> https://github.com/NetBSD/pkgsrc-wip/tree/master/gdb-netbsd/patches >> >> * with core/basic features... but it is difficult as there is no OS with >> finished transition... >> https://sourceware.org/gdb/wiki/LocalRemoteFeatureParity >=20 > I can definitely not commit to upstreaming the gdbserver. I am only > looking at NetBSD because I wanted to remove a deprecated function in > GDB, and one of the two callers is in NetBSD ARM code. So, I wanted to > build ARM NetBSD first so I can test if it still works after that > change. But I can't commit to any further NetBSD work. >=20 OK, thanks! > BTW, is there a reason why your patches have one .patch per changed > file? I usually find it easier to follow them if they are instead > grouped by some kind of topic per patch. >=20 This is a convention in pkgsrc and it is practical for its use-case. > Thanks, > Christian >=20 >> >>> >>> Thanks, >>> Christian >>> >>> On Fri, Jan 24, 2020 at 3:29 PM Kamil Rytarowski wrote: >>>> >>>> On 24.01.2020 15:18, cbiesinger@chromium.org wrote: >>>>> From: Christian Biesinger >>>>> >>>>> Fixes the below compile error on ARM NetBSD 9.0_RC1 (the only version= I >>>>> tested). types.h does not define register_t by default. >>>>> >>>>> We already use this define elsewhere, notably in bsd-kvm.c. >>>>> >>>>> In file included from ../../gdb/arm-nbsd-nat.c:28: >>>>> /usr/include/machine/frame.h:54:2: error: unknown type name 'register= _t'; did you mean '__register_t'? >>>>> register_t tf_spsr; >>>>> ^ >>>>> /usr/include/machine/types.h:77:14: note: '__register_t' declared here >>>>> typedef int __register_t; >>>>> ^ >>>>> >>>>> There are other compile errors that this does not fix. >>>>> >>>>> gdb/ChangeLog: >>>>> >>>>> 2020-01-24 Christian Biesinger >>>>> >>>>> * arm-nbsd-nat.c: Define _KMEMUSER to get the declaration of >>>>> register_t. >>>>> >>>>> Change-Id: I82c21d38189ee59ea0af2538ba84b771d268722e >>>>> --- >>>>> gdb/arm-nbsd-nat.c | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c >>>>> index 00f919194b..4844b51a3c 100644 >>>>> --- a/gdb/arm-nbsd-nat.c >>>>> +++ b/gdb/arm-nbsd-nat.c >>>>> @@ -17,6 +17,8 @@ >>>>> You should have received a copy of the GNU General Public License >>>>> along with this program. If not, see . */ >>>>> >>>>> +/* We define this to get types like register_t. */ >>>>> +#define _KMEMUSER >>>>> #include "defs.h" >>>>> #include "gdbcore.h" >>>>> #include "inferior.h" >>>>> >>>> >>>> While gdb is the right user for _KMEMUSER, here we should probably go >>>> for -D_KERNTYPES as it is the canonical symbol for register_t. >>>> >> >> --YwUZnqIHBXdQYSRSSFZuPYMFm6Tx83KTW-- --vjmpBXI893G4Ic7ZVkyn8aSwmx499sirc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl4rEcEACgkQS7MI6bAu dmyDIhAAlpkeFInQM1QWsxclGyLwTNhEr8cLxuNDgISkvXjPvSXurwnrdY50VOo3 R59bKexSqu9O9COOqKtXbKGowyPJKcb4S20LoiCUPe5u+ixwDZ0XQaUEvp4Yz9gE k7rPJehMTo6eLxheikjahayLmxWEt9/jQFi+HYQvGDrMDZCa648AwXAjoqEW78jK SO1/QPWNQGuassq+JTwfWrNWKHGaN+s4IaGqL4562il6qO87To6Vy2XVyjJuoIZN d7jaO2zKXF7+kqnq/r5c/OK7cvCGgL59DyWjoPNfdEITxx3hrLZnhC5EuzgrNhZH TVJhMFqoeOHYZEFsqFYWVnQwRLewnd5MPpuVNase0UPnVZKYqdRTzryTTF+UntBw w4NwfJK63FUDmZsWDt/eOrLkrtHeR5K7mkIYLzrLVFcSSaf+lDCAShR2QyoqmjqO /Ge0bbMLQ6znL4FzIgKWDmOOyoLXRaEMSMWHzaRpUE6dIr5OTsBt6JDUQ8SOaQF7 mvZgd0yNuoIjVpvSn2fdUrHFk96AMiGeyaRDqbf4py5La5A7xNsI+eAGoXtJ0HfX zUC9oezCWdM2apW5iJqW2vfeymw9bj+8yBiTM01Aapcw5TEvWIf71IeH0wJzaHWH uqHIgGAGkd7RHXZqtX8S6vItww7CUfQPVNkjTgkR5vuuxgeDu98= =Ba0M -----END PGP SIGNATURE----- --vjmpBXI893G4Ic7ZVkyn8aSwmx499sirc--