From: Klee Dienes <klee@apple.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] GDB crash when using command lines due to memory corruption
Date: Wed, 11 Dec 2002 10:20:00 -0000 [thread overview]
Message-ID: <8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com> (raw)
In-Reply-To: <20021211173805.GG25575@gnat.com>
A safer change for 5.3 might be the patch I submitted on October 30th.
http://sources.redhat.com/ml/gdb-patches/2002-10/msg00586.html
Rather than deal with sharing the command-line structure, I just
updated bpstat_copy to match its comment, and do a deep copy of the
command lines as well as the value. I don't really have a strong
opinion about copying the command lines vs. managing them the way Joel
proposes, although my patch does have the argument of simplicity going
for it. On the other hand, if/when we go to a more sophistiated
command-line evaluator, we'll probably want the command body to be some
opaque and externally managed structure anyway.
Whichever patch we end up taking, though, we should be sure to update
the comment in bpstat_copy and add my proposed change to the test suite.
next prev parent reply other threads:[~2002-12-11 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 10:01 Joel Brobecker
2002-12-11 10:20 ` Klee Dienes [this message]
2002-12-11 15:24 ` Michael Snyder
2002-12-12 2:04 ` Joel Brobecker
2002-12-12 2:41 ` Joel Brobecker
2002-12-12 13:03 ` Daniel Jacobowitz
2003-01-13 3:21 ` [RFA] (ping) " Joel Brobecker
2003-02-11 9:38 ` Joel Brobecker
2003-02-11 16:55 ` Andrew Cagney
2003-02-24 7:37 ` Andrew Cagney
2003-03-10 23:38 ` [RFC/RFA] " Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com \
--to=klee@apple.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox