From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86421 invoked by alias); 17 May 2018 17:08:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86378 invoked by uid 89); 17 May 2018 17:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 May 2018 17:08:11 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w4HH847k029505 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 May 2018 13:08:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 57F161EF62; Thu, 17 May 2018 13:08:04 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id EE1E31EF62; Thu, 17 May 2018 13:07:59 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 17 May 2018 17:23:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Make format_pieces recognize the \e escape sequence In-Reply-To: <87efiaguyd.fsf@tromey.com> References: <1526564365-4036-1-git-send-email-simon.marchi@ericsson.com> <87efiaguyd.fsf@tromey.com> Message-ID: <8059848c4e76ccfb1d539b7eab0d33d9@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 17 May 2018 17:08:04 +0000 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00385.txt.bz2 On 2018-05-17 11:31, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I noticed that the printf command did not recognize the \e > escape > Simon> sequence, used amongst other things to use colors: > > Simon> (gdb) printf "This is \e[32mgreen\e[m!\n" > Simon> Unrecognized escape character \e in format string. > > Simon> This patch makes format_pieces recognize it, which makes that > command > Simon> print the expected result in glorious color. > > Thanks. The patch looked reasonable to me. > > Maybe this could be considered part of PR 14975. Thanks for taking a look. I changed the title of 14975 to make it a bit more general (not only about \x escape sequences) and added a reference to it in my patch, which is now pushed. Simon