From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122252 invoked by alias); 5 Sep 2019 22:40:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122171 invoked by uid 89); 5 Sep 2019 22:40:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_SBL_CSS autolearn=ham version=3.3.1 spammy=83, $HOME, HOME, $home X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2019 22:40:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mathworks.com; s=mimecast20180117; t=1567723250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PjteZrOnPSjeiVmE14P3IGr2AvzyXJ9bmnsbXsyCqHk=; b=gEVhh2vT7Av8weBzZAEo0Az8bb7itKojgnVDuXtlizSPe8xY5BStHzHtjM0fzz9S4UYhc+ hpklJs55Sk0c8vjJSorxduM1rDoelYKi9GCVtvBJC+t1k24XY20UB25+Ndfe7PtPQuOre6 JEQ4x6rOsGAwgY8S6KIaRPb2zwBmlTs= Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01lp2051.outbound.protection.outlook.com [104.47.33.51]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-fXj_90SGP12Wn_2sAqWkeA-1; Thu, 05 Sep 2019 18:40:49 -0400 Received: from DM6PR05MB4156.namprd05.prod.outlook.com (20.176.72.29) by DM6SPR01MB0064.namprd05.prod.outlook.com (20.179.160.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.5; Thu, 5 Sep 2019 22:40:48 +0000 Received: from DM6PR05MB4156.namprd05.prod.outlook.com ([fe80::a00e:ddad:be30:b632]) by DM6PR05MB4156.namprd05.prod.outlook.com ([fe80::a00e:ddad:be30:b632%6]) with mapi id 15.20.2220.022; Thu, 5 Sep 2019 22:40:48 +0000 From: Mike Gulick To: "gdb-patches@sourceware.org" CC: Mike Gulick Subject: [RFC] Apply compilation dir to source_path lookup Date: Thu, 05 Sep 2019 22:40:00 -0000 Message-ID: <8058b501-9020-84f1-ecf4-b46bfe3b86e3@mathworks.com> x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cz9XB1pprV6M82NiZFPvXnvzpvoPxuUV70bgPshxfhGdxkslTARJ/GPDjRj2TWiDUW+PhxtmxTHJyB3hq4QNvA== X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-SW-Source: 2019-09/txt/msg00059.txt.bz2 SGksDQoNCkknbSBoYXZpbmcgdHJvdWJsZSBnZXR0aW5nIGdkYiB0byBmaW5k IHRoZSBjb3JyZXNwb25kaW5nIHNvdXJjZSBmb3IgYQ0KYmluYXJ5IHdob3Nl IGNvbXBpbGF0aW9uIGRpcmVjdG9yeSB3YXMgcmV3cml0dGVuIHVzaW5nDQot ZmRlYnVnLXByZWZpeC1tYXAuICBJIGFtIGRvaW5nIHRoaXMgaW4gb3JkZXIg dG8gbWFrZSBidWlsZHMNCnJlcHJvZHVjaWJsZS4gIEkgYW0gdXNpbmcgdGhp cyBnY2Mgc3dpdGNoIHRvIHJlbW92ZSBhIHBvcnRpb24gb2YgdGhlDQpjb21w aWxlIGRpcmVjdG9yeSwgZS5nLg0KDQokIGNkICRIT01FL3Rlc3Qvc3JjLw0K JCBnY2MgLWcgLW8gdGVzdCAtZmRlYnVnLXByZWZpeC1tYXA9JEhPTUU9IHRl c3QuYw0KJCBkd2FyZmR1bXAgdGVzdA0KLi4uDQogICAgICAgICAgICAgICAg ICAgIERXX0FUX25hbWUgICAgICAgICAgICAgICAgICB0ZXN0LmMNCiAgICAg ICAgICAgICAgICAgICAgRFdfQVRfY29tcF9kaXIgICAgICAgICAgICAgIC90 ZXN0L3NyYw0KLi4uDQoNCldoZW4gYXR0ZW1wdGluZyB0byBkZWJ1ZyB0aGUg cmVzdWx0aW5nIGJpbmFyeSwgZ2RiIGlzIHVuYWJsZSB0byBmaW5kIHRoZQ0K c291cmNlIGZpbGUgZXZlbiBpZiBJIGFkZCB0aGUgcmVtb3ZlZCBwYXRoICRI T01FIHRvIHRoZSBnZGIgc291cmNlDQpwYXRoOg0KDQokIGNkICRIT01FDQok IGdkYiAtLW5oIH4vdGVzdC9zcmMvdGVzdA0KR05VIGdkYiAoR0RCKSA4LjMN Ci4uLg0KKGdkYikgZGlyZWN0b3J5IC9ob21lL21ndWxpY2sNClNvdXJjZSBk aXJlY3RvcmllcyBzZWFyY2hlZDogL2hvbWUvbWd1bGljazokY2RpcjokY3dk DQooZ2RiKSBpbmZvIHNvdXJjZXMNClNvdXJjZSBmaWxlcyBmb3Igd2hpY2gg c3ltYm9scyBoYXZlIGJlZW4gcmVhZCBpbjoNCg0KL3Rlc3Qvc3JjL3Rlc3Qu Yw0KDQpTb3VyY2UgZmlsZXMgZm9yIHdoaWNoIHN5bWJvbHMgd2lsbCBiZSBy ZWFkIGluIG9uIGRlbWFuZDoNCg0KDQooZ2RiKSBiIHRlc3QuYzozDQpCcmVh a3BvaW50IDEgYXQgMHg2NjQ6IGZpbGUgdGVzdC5jLCBsaW5lIDMuDQooZ2Ri KSByDQpTdGFydGluZyBwcm9ncmFtOiAvbWF0aHdvcmtzL2hvbWUvbWd1bGlj ay90ZXN0L3NyYy90ZXN0IA0KDQpCcmVha3BvaW50IDEsIG1haW4gKCkgYXQg dGVzdC5jOjMNCjMJdGVzdC5jOiBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5 Lg0KDQoNCkl0IHR1cm5zIG91dCB0aGF0IG9ubHkgdGhlIHNvdXJjZSBmaWxl LCBpLmUuIERXX0FUX25hbWUsIGlzIHVzZWQgd2hlbg0Kc2VhcmNoaW5nIHRo ZSBzb3VyY2UgcGF0aC4gIFRoaXMgaXMgc3VycHJpc2luZyBnaXZlbiB0aGUg ZXhhbXBsZSB3aXRoDQonL3Vzci9zcmMvZm9vLTEuMC9saWIvZm9vLmMnIGFu ZCAnL21udC9jcm9zcycgaW4gdGhlIGdkYiBkb2N1bWVudGF0aW9uDQpoZXJl OiBodHRwczovL3NvdXJjZXdhcmUub3JnL2dkYi9vbmxpbmVkb2NzL2dkYi9T b3VyY2UtUGF0aC5odG1sLiAgSXQNCnNlZW1zIHVuY29tbW9uIGZvciBEV19B VF9uYW1lIHRvIGJlIHRoZSBmdWxsIHBhdGggdG8gdGhlIHNvdXJjZSBmaWxl IGluDQptb3N0IHByb2dyYW1zIEkgaGF2ZSBjb21lIGFjcm9zcy4gIEluIHRo YXQgZXhhbXBsZSBmcm9tIHRoZQ0KZG9jdW1lbnRhdGlvbiwgaXQgaXMgbGlr ZWx5IHRoYXQgRFdfQVRfbmFtZSB3b3VsZCBiZSAnbGliL2Zvby5jJyBhbmQN CkRXX0FUX2NvbXBfZGlyIHdvdWxkIGJlICcvdXNyL3NyYy9mb28tMS4wJy4N Cg0KSSBoYXZlIGltcGxlbWVudGVkIHR3byBkaWZmZXJlbnQgYXBwcm9hY2hl cyB0byBoYW5kbGUgdGhpcywgYm90aCBvZg0Kd2hpY2ggd29yaywgYW5kIEkg d2FudGVkIGZlZWRiYWNrIG9uIGEpIHdoZXRoZXIgeW91IHRoaW5rIHRoaXMg aXMgYQ0KbGVnaXRpbWF0ZSBidWcvZmVhdHVyZSwgYW5kIGIpIHdoaWNoIGFw cHJvYWNoIHlvdSBwcmVmZXIuDQoNCkFwcHJvYWNoIDEgaXMgdG8gaW5jbHVk ZSBhbm90aGVyIHBhc3MgaW4gZmluZF9hbmRfb3Blbl9zb3VyY2Ugd2hlcmUg dGhlDQpjb21waWxhdGlvbiBkaXJlY3RvcnkgaXMgcHJlcGVuZGVkIHRvIHRo ZSBmaWxlbmFtZSBiZWZvcmUgc2VhcmNoaW5nIGZvcg0KdGhlIGZpbGUgd2l0 aCBvcGVucC4gIFRoaXMgYWxsb3dzIHRoZSBleGFtcGxlIEkgcHJvdmlkZWQg YWJvdmUgdG8gd29yaw0KYXMtaXMuDQoNCkFwcHJvYWNoIDIgaXMgdG8gYWxs b3cgJyRjZGlyJyB0byBhcHBlYXIgYXMgcGFydCBvZiBhbiBlbnRyeSBpbiB0 aGUNCnNvdXJjZV9wYXRoLiAgQ3VycmVudGx5IGl0IGlzIG9ubHkgYWxsb3dl ZCB0byBleGlzdCBhcyBhIHN0YW5kYWxvbmUNCmVudHJ5LiAgVGhpcyB3b3Vs ZCBhbGxvdyBtZSB0byBzYXkgJ2RpcmVjdG9yeSAvaG9tZS9tZ3VsaWNrLyRj ZGlyJywgYW5kDQpmaW5kX2FuZF9vcGVuX3NvdXJjZSB3b3VsZCBleHBhbmQg dGhlICRjZGlyIHBhcnQgb2YgdGhpcyBzdHJpbmcgdG8gdGhlDQpjb21waWxh dGlvbiBkaXJlY3RvcnkuDQoNCkkgcHJlZmVyIGFwcHJvYWNoIDEgZm9yIGEg Y291cGxlIG9mIHJlYXNvbnM6DQoNCjEpIEl0IGlzIHNpbXBsZXIgZm9yIHVz ZXJzIHRvIHVuZGVyc3RhbmQuICBJdCBkb2Vzbid0IHJlYWxseSByZXF1aXJl DQp1bmRlcnN0YW5kaW5nIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gRFdfQVRf Y29tcF9kaXIgYW5kIERXX0FUX25hbWUuICBJdA0Kd2lsbCBtYXRjaCB0aGUg c291cmNlIGZpbGUgaW4gL2hvbWUvbWd1bGljay90ZXN0LmMsIC90ZXN0L3Ny Yy90ZXN0LmMsIG9yDQovaG9tZS9tZ3VsaWNrL3Rlc3Qvc3JjL3Rlc3QuYy4g IE9mIGNvdXJzZSwgc2luY2UgJyRjZGlyJyBpcyBzdGlsbCBpbg0Kc291cmNl X3BhdGgsIGl0IHdpbGwgYWxzbyBsb29rIGluIC90ZXN0L3NyYy90ZXN0L3Ny Yy90ZXN0LmMsIHdoaWNoIGlzIGENCmxpdHRsZSBjb25mdXNpbmcsIGJ1dCBz aG91bGRuJ3QgYmUgYSBwcm9ibGVtIChhbmQgd2UgY291bGQgZXhwbGljaXRs eQ0KcmVtb3ZlICckY2RpcicgZnJvbSB0aGUgcGF0aCB3aGVuIGRvaW5nIHRo aXMgc2VhcmNoKS4NCg0KMikgSXQgc2VlbXMgdG8gbWF0Y2ggdGhlIGV4aXN0 aW5nIGdkYiBkb2N1bWVudGF0aW9uLg0KDQpJIGRpc2xpa2UgYXBwcm9hY2gg MiBiZWNhdXNlIGl0IG1ha2VzIHRoZSBkaXJlY3Rvcnkgc3RyaW5ncyBtb3Jl DQpjb21wbGljYXRlZCwgYW5kIGl0IGFsc28gbWVhbnMgSSdtIHVuYWJsZSB0 byBoYXZlIGEgZGlyZWN0b3J5IG5hbWVkDQonL2hvbWUvbWd1bGljay8kY2Rp cicgKGJpemFycmUsIEkga25vdywgYnV0IHN1Y2ggdGhpbmdzIGFyZSBwb3Nz aWJsZSkuDQoNCkhlcmUgaXMgYSBwcmVsaW1pbmFyeSBwYXRjaCBmb3IgdGhl IGZpcnN0IGFwcHJvYWNoLiAgSSB3aWxsIGdvIGFoZWFkIGFuZA0KYWRkIGEg dGVzdC1jYXNlIGFuZCByZS1zZW5kIGEgZm9ybWFsIHBhdGNoIHJldmlldyBy ZXF1ZXN0IGlmIHRoaXMgc2VlbXMNCmxpa2UgYW4gYWNjZXB0YWJsZSBzb2x1 dGlvbi4NCg0KVGhhbmtzLA0KTWlrZQ0KDQpkaWZmIC0tZ2l0IGEvZ2RiL3Nv dXJjZS5jIGIvZ2RiL3NvdXJjZS5jDQppbmRleCBiMjdmMjEwODAyLi5iN2I1 NzQxMDI4IDEwMDY0NA0KLS0tIGEvZ2RiL3NvdXJjZS5jDQorKysgYi9nZGIv c291cmNlLmMNCkBAIC0xMDMzLDcgKzEwMzMsMzUgQEAgZmluZF9hbmRfb3Bl bl9zb3VyY2UgKGNvbnN0IGNoYXIgKmZpbGVuYW1lLA0KICAgb3BlbnBfZmxh Z3MgZmxhZ3MgPSBPUEZfU0VBUkNIX0lOX1BBVEg7DQogICBpZiAoYmFzZW5h bWVzX21heV9kaWZmZXIpDQogICAgIGZsYWdzIHw9IE9QRl9SRVRVUk5fUkVB TFBBVEg7DQorDQorICAvKiBUcnkgdG8gbG9jYXRlIGZpbGUgdXNpbmcgZmls ZW5hbWUgKi8NCiAgIHJlc3VsdCA9IG9wZW5wIChwYXRoLCBmbGFncywgZmls ZW5hbWUsIE9QRU5fTU9ERSwgZnVsbG5hbWUpOw0KKyAgaWYgKHJlc3VsdCA8 IDAgJiYgZGlybmFtZSAhPSBOVUxMKQ0KKyAgICB7DQorICAgICAgLyogVHJ5 IHRvIGxvY2F0ZSBmaWxlIHVzaW5nIGNvbXBpbGF0aW9uIGRpciArIGZpbGVu YW1lLiAgVGhpcyBpcyBoZWxwZnVsDQorCSBpZiBwYXJ0IG9mIHRoZSBjb21w aWxhdGlvbiBkaXJlY3Rvcnkgd2FzIHJlbW92ZWQsIGUuZy4gdXNpbmcgZ2Nj J3MNCisJIC1mZGVidWctcHJlZml4LW1hcCwgYW5kIHdlIGhhdmUgYWRkZWQg dGhlIG1pc3NpbmcgcHJlZml4IHRvDQorCSBzb3VyY2VfcGF0aC4gKi8NCisg ICAgICAvKiBBbGxvY2F0ZSBzcGFjZSBmb3IgZGlybmFtZSwgcG9zc2libHkg YW4gZXh0cmEgc2xhc2gsIHRoZSBmaWxlbmFtZSwNCisJIGFuZCB0ZXJtaW5h dGluZyBudWxsICovDQorICAgICAgY2hhciAqIGNkaXJfZmlsZW5hbWUgPSAo Y2hhciAqKQ0KKwlhbGxvY2EgKHN0cmxlbiAoZGlybmFtZSkgKyBzdHJsZW4o U0xBU0hfU1RSSU5HKSArIHN0cmxlbiAoZmlsZW5hbWUpICsgMSk7DQorDQor ICAgICAgY2Rpcl9maWxlbmFtZSA9IHN0cmNweSAoY2Rpcl9maWxlbmFtZSwg ZGlybmFtZSk7DQorICAgICAgaW50IGxlbiA9IHN0cmxlbiAoY2Rpcl9maWxl bmFtZSk7ICAgIC8qIGxhc3QgY2hhciBpbiBjZGlyX2ZpbGVuYW1lICovDQor DQorICAgICAgLyogQWRkIGRpcmVjdG9yeSBzZXBhcmF0b3IgaWYgbm90IHBy b3ZpZGVkIGJ5IGRpcm5hbWUgb3IgZmlsZW5hbWUgKi8NCisgICAgICBpZiAo IShJU19ESVJfU0VQQVJBVE9SIChjZGlyX2ZpbGVuYW1lW2xlbl0pIHx8DQor CSAgICBJU19ESVJfU0VQQVJBVE9SIChmaWxlbmFtZVswXSkpKQ0KKyAgICAg ICAgc3RyY2F0IChjZGlyX2ZpbGVuYW1lLCBTTEFTSF9TVFJJTkcpOw0KKyAg ICAgIGVsc2UgaWYgKElTX0RJUl9TRVBBUkFUT1IgKGNkaXJfZmlsZW5hbWVb bGVuXSkgJiYNCisJICAgICAgIElTX0RJUl9TRVBBUkFUT1IgKGZpbGVuYW1l WzBdKSkNCisJLyogQm90aCBwcm92aWRlIGEgc2xhc2gsIHVzZSBvbmx5IG9u ZSAqLw0KKwljZGlyX2ZpbGVuYW1lW2xlbl0gPSAnXDAnOw0KKyAgICAgIHN0 cmNhdChjZGlyX2ZpbGVuYW1lLGZpbGVuYW1lKTsNCisNCisgICAgICByZXN1 bHQgPSBvcGVucChwYXRoLCBmbGFncywgY2Rpcl9maWxlbmFtZSwgT1BFTl9N T0RFLCBmdWxsbmFtZSk7DQorICAgIH0NCiAgIGlmIChyZXN1bHQgPCAwKQ0K ICAgICB7DQogICAgICAgLyogRGlkbid0IHdvcmsuICBUcnkgdXNpbmcganVz dCB0aGUgYmFzZW5hbWUuICAqLw0K >From gdb-patches-return-158593-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Sep 06 00:53:39 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 2649 invoked by alias); 6 Sep 2019 00:53:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2001 invoked by uid 89); 6 Sep 2019 00:53:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*c:alternative X-HELO: mail-vs1-f44.google.com Received: from mail-vs1-f44.google.com (HELO mail-vs1-f44.google.com) (209.85.217.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 00:53:36 +0000 Received: by mail-vs1-f44.google.com with SMTP id i128so2945077vsc.7 for ; Thu, 05 Sep 2019 17:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0oVf4nWe/wACxOy6emL3lFkioAQWeYlO/lcgXB2UjQQ=; b=W3gvpuMOxmB86olpW/h1xcRgSt9+tlBdStz49kAW/B7wmIxj6cmP9HiTL4O9YkVYGI 3cxEq8uYMMXnHzqVrBMhRZViO5pzQZeOHSLY1pL06lTsE+WvTRNRI2euXW3yGysm527I kliTfplgIRFBRdZ3mP/BAhz/XQAqHx7oNFtfhP/IqrnvyWm2WTjVCGZnWhWT7oduyu01 +9sr6C/As5P9LuN5uqDsahDwfM4WXuEbNcphnvd0+YrLgVf/Bh6gYPNygytc+xF6IgOQ S7vQwcnmpxNefSC/9YRM8IkkP5oH0sorep019bKhNpoGMkKkh9mItwywDgO3/SV39qgh IF8A== MIME-Version: 1.0 References: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> In-Reply-To: From: "Doug Evans via gdb-patches" Reply-To: Doug Evans Date: Fri, 06 Sep 2019 00:53:00 -0000 Message-ID: Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info To: David Blaikie Cc: Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00060.txt.bz2 Content-length: 2548 SGTM On Thu, Sep 5, 2019 at 3:12 PM David Blaikie wrote: > Clang now supports labels - so I'd like to essentially revert this patch. > > Is this OK? > > > On Thu, Apr 24, 2014 at 8:23 PM David Blaikie wrote: > > > > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans wrote: > > > David Blaikie writes: > > > > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a > > > > bunch of GDB tests that rely on debug info for labels. > > > > > > > > For some reason gdb.linespec/ls-expr.exp gathered all tests into a > > > > dictionary and then ran them. This made it hard to XFAIL just the > > > > right tests. I refactored this to execute the tests directly, > removing > > > > the dictionary so I could XFAIL the right tests. Is there a reason > it > > > > would've been written that way? Does my patch break it in some way? > > > > commit c438cb16b63292e415330f289616c4e4ecece63c > > > > Author: David Blaikie > > > > Date: Sun Apr 13 11:42:02 2014 -0700 > > > > > > > > XFAIL under Clang tests using labels > > > > > > > > gdb/testsuite/ > > > > * gdb.base/label.exp: XFAIL label related tests under Clang. > > > > * gdb.cp/cplabel.exp: Ditto. > > > > * gdb.linespec/ls-errs.exp: Refactor tests to execute directly > > > > and XFAIL under Clang those using labels. > > > > > > LGTM > > > > > > > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog > > > > index 730c116..b04b940 100644 > > > > --- gdb/testsuite/ChangeLog > > > > +++ gdb/testsuite/ChangeLog > > > > @@ -1,3 +1,9 @@ > > > > +2014-04-12 David Blaikie > > > > + > > > > + * gdb.base/label.exp: XFAIL label related tests under > Clang. > > > > + * gdb.cp/cplabel.exp: Ditto. > > > > + * gdb.linespec/ls-errs.exp: Refactor tests to execute directly > and XFAIL under Clang those using labels. > > > > + > > > > > > Nit: space vs tabs. Just use tabs. > > > Plus line is longer than 80 chars. > > > > Thanks for the catches - fixed those up and committed in > > c2e827ad5340fcf1735df6c77cb0311e56b985ef. > > > > Also refactored some of the xfails along the lines of what Pedro > > suggested in the one test case that had several similar failures > > (gdb.base/label.exp). If/when we fix this in Clang it might be worth > > refactoring into a common function (though I'm personally not very > > vested in keeping the test suite usable with anything other than ToT > > Clang - perhaps others are). >