Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Rogerio Alves <rcardoso@linux.ibm.com>,
	gdb-patches@sourceware.org, uweigand@de.ibm.com,
	pedromfc@linux.ibm.com
Subject: Re: [PATCH][PowerPC] Fix powerpc tests
Date: Tue, 04 Feb 2020 03:39:00 -0000	[thread overview]
Message-ID: <802b3f31-90e3-ebe1-1779-951054e7ef03@simark.ca> (raw)
In-Reply-To: <2f87e7da-d040-cb9a-eddd-f87d703a1f7d@linux.ibm.com>

On 2020-02-03 3:55 p.m., Rogerio Alves wrote:
> This patch fixes test failures power8 and power9 caused by changes on
> opcodes:
> 
> The dissasembler does not emit whitespace for instructions
> anymore (c2b1c2754526acff8aae2fe8f5a56c2dd11d0b7f)
> 
> The dissasembler generates extended mnemonics for some instructions
> instead (aae9718e4d4e8d01dcee22684e82b000203d3e52)
> 
> The ldmx instruction was removed. This instruction was never
> implemented (6fbc939cfdbdf02f205c20925583738b0f835e62)

Hi Rogerio,

Thanks for the patch.  Note that applying the patch with an older git version (1.8.3.1,
as found on gcc135 of the compile farm) failed.  When applying it locally with a more
recent git (2.25.0), it worked but said:

  warning: Patch sent with format=flowed

That probably means you sent the patch using your email client.  Please consider using
git-send-email when sending patches by email in the future to avoid formatting issues.

I've tested the patch on that machine (a Power9) and confirmed that the tests did fail
and now pass with this patch applied, so I've pushed it.

Thanks!

Simon


      reply	other threads:[~2020-02-04  3:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 20:59 Rogerio Alves
2020-02-04  3:39 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=802b3f31-90e3-ebe1-1779-951054e7ef03@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=pedromfc@linux.ibm.com \
    --cc=rcardoso@linux.ibm.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox