From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15829 invoked by alias); 10 May 2002 07:16:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15778 invoked from network); 10 May 2002 07:16:46 -0000 Received: from unknown (HELO mirapoint.inter.net.il) (192.114.186.20) by sources.redhat.com with SMTP; 10 May 2002 07:16:46 -0000 Received: from Zaretsky ([80.230.2.40]) by mirapoint.inter.net.il (Mirapoint Messaging Server MOS 3.1.0.54-GA) with ESMTP id ADQ46571; Fri, 10 May 2002 10:15:16 +0300 (IDT) Date: Fri, 10 May 2002 00:16:00 -0000 From: "Eli Zaretskii" To: jimb@redhat.com Message-Id: <8011-Fri10May2002101418+0300-eliz@is.elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <20020509235822.DC4F95EA11@zwingli.cygnus.com> (message from Jim Blandy on Thu, 9 May 2002 18:58:22 -0500 (EST)) Subject: Re: RFA: add macro commands Reply-to: Eli Zaretskii References: <20020509235822.DC4F95EA11@zwingli.cygnus.com> X-SW-Source: 2002-05/txt/msg00327.txt.bz2 > From: Jim Blandy > Date: Thu, 9 May 2002 18:58:22 -0500 (EST) > > + add_cmd > + ("expand", no_class, macro_expand_command, > + "Fully expand any C/C++ preprocessor macro invocations in EXPRESSION.\n" > + "Show the expanded expression.", > + ¯olist); Do I understand correctly that this command definition, as well as others you added in this patch, makes the command use the default completion function? If so, I'm not sure that's a good idea, unless the tables scanned by make_symbol_completion_list store macro names. It would be nice to have completion only on macro names in these commands. But if that cannot be done easily, at least let's disable completion entirely until something appropriate is coded.