Re: [PATCH] AArch64 pauth: Indicate unmasked addresses in backtrace

Tom Tromey
2019-07-18T13:48:50Z

>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> diff --git a/gdb/stack.c b/gdb/stack.c
Alan> index 9b1d1a6856..cef1c29a82 100644
Alan> --- a/gdb/stack.c
Alan> +++ b/gdb/stack.c
Alan> @@ -1254,7 +1254,11 @@ print_frame (const frame_print_options &fp_opts,
Alan> {
Alan> annotate_frame_address ();
Alan> if (pc_p)
Alan> - uiout->field_core_addr ("addr", gdbarch, pc);
Alan> + {
Alan> + uiout->field_core_addr ("addr", gdbarch, pc);
Alan> + if (frame_get_pc_masked (frame))
Alan> + uiout->text ("<unmasked>");
Alan> + }

Usually a change to frame printing will require a change in the python
layer as well, because it has its own frame printer. The ideal is that
a no-op frame filter should result in no change to the output.

thanks,
Tom