Re: [PATCH 1/2] gdb: Respect field width and alignment for 'fmt' fields in CLI output

Tom Tromey
2018-11-20T22:17:32Z

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> This patch has been tested on x86-64/Linux with no regressions,
Andrew> however, the testsuite doesn't always spot broken output formatting or
Andrew> alignment. I have also audited all uses of 'fmt' fields that I could
Andrew> find, and I don't think there are any other places that specifically
Andrew> try to work around the lack of width/alignment, however, I could have
Andrew> missed something.

Thanks for the patch.

Andrew> - vfprintf_filtered (m_streams.back (), format, args);
Andrew> + string_file stb;
Andrew> + stb.vprintf (format, args);

I think just using string_vprintf directly is simpler here.
This is ok with that change.

Tom