From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 993BE385DC35 for ; Thu, 25 Jun 2020 09:57:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 993BE385DC35 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-vYoMP2tkPLm8NcSPP556yQ-1; Thu, 25 Jun 2020 05:57:55 -0400 X-MC-Unique: vYoMP2tkPLm8NcSPP556yQ-1 Received: by mail-wr1-f70.google.com with SMTP id p9so6461153wrx.10 for ; Thu, 25 Jun 2020 02:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kABIBws7Y1SVnmlIaur4J7e9aSxlC+W+lsioK0Cpkvs=; b=outQtiM4DdR2h1M2GLApdo3AMiWmuCyEFWLs2ePu9ksPnWWmZnDCkJlg8YwFXmd0bE Z52qoh8zJKdsmX0qOvgapYZh24ZRWRPmMPlHne1cm6sy+c/Z2F9opCyzHJsoEcReLj35 UufqGmQIa178hYTjsRp2qdUtvlzTPlxUxWQQ4l3q5AcfbChtkMtAsLqkS4Lm49M/OMaD NvPYCpjAib/kZ8mqsyrvoPQt4IdLia5vCVEVW6/SeSUGEpdh7W48vPSrWRWlEf1DCYpB 2gTnsLsnuQfclWI5OODah/9kZkgDCGTqiF4++wJy25SMSf+O1em8hqFpwgvlz+dTqyF0 cyMw== X-Gm-Message-State: AOAM531IoUzmT4uBl/r7OMpvd7ianAvoIQ4UFCaiDU6wJcNSD/VjWgSX WBr/GmYYu5ePxIdOON3MLaIdHmNn5Avb4udiSe7tX9Fm+tNRF/f96QrhRK75QRoXu/ZePBi4a3i avmy+OCy1iLUNjgo9c+J6iw== X-Received: by 2002:adf:f0c5:: with SMTP id x5mr35827203wro.396.1593079073913; Thu, 25 Jun 2020 02:57:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpQMMAPikBghtwqgom6DwTaDbveRknP+J/2DN3ah+CYcMZkcAXCRGznRUExpgC6U2Sxe60yw== X-Received: by 2002:adf:f0c5:: with SMTP id x5mr35827185wro.396.1593079073670; Thu, 25 Jun 2020 02:57:53 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id j24sm29743255wrd.43.2020.06.25.02.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 02:57:53 -0700 (PDT) Subject: Re: [PATCH] Don't include *sol2-tdep.o on Linux/sparc* To: Rainer Orth , Simon Marchi References: <00d11a67-fb37-52de-859d-f8055c841668@simark.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <7faf3651-4d93-8609-ddfc-51f2359a822b@redhat.com> Date: Thu, 25 Jun 2020 10:57:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 09:58:00 -0000 On 6/25/20 9:23 AM, Rainer Orth wrote: >> From a quick check, this should just work today: the functions declared >> in sparc*-sol2-tdep.c are only called in Solaris-specific files already. >> I'll give it a try separately. sparc{32,64}_sol2_init_abi are currently >> declared in common files (sparc*-tdep.h), but they can just be made >> static and the declarations removed. > the following patch does just that: tested on sparc64-unknown-linux-gnu > (build only due to PR tdep/26170) and sparcv9-sun-solaris2.11. I got curious and looked into git history to find why that was done in the first place. 'git blame configure.tgt' points at a4ce5b0d0204 as the commit that converted the old .mt files into configure.tgt. And then: $ git blame a4ce5b0d0204^ -- ./config/sparc/linux64.mt points at: commit 691342f948aa4f8c4f4e039669276faf753a36b4 Author: David S. Miller AuthorDate: Mon Feb 27 06:14:51 2006 +0000 2006-02-26 David S. Miller * config/sparc/linux.mt (TDEPFILES): Add sol2-tdep.o. * config/sparc/linux64.mt (TDEPFILES): Likewise. Which is... drumroll... a big nothingburger: https://sourceware.org/legacy-ml/gdb-patches/2006-02/msg00492.html So, nothing to see here, move along. :-) Thanks, Pedro Alves