From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88581 invoked by alias); 18 Jan 2018 18:35:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88547 invoked by uid 89); 18 Jan 2018 18:35:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jan 2018 18:35:50 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF93268C1; Thu, 18 Jan 2018 18:35:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0D8460F84; Thu, 18 Jan 2018 18:35:48 +0000 (UTC) Subject: Re: [PATCH] GDB testsuite: Re-enable -fdiagnostics-color=never To: Andreas Arnez , gdb-patches@sourceware.org References: Cc: Tom Tromey From: Pedro Alves Message-ID: <7f9604a4-edef-709c-ed8a-d22b0cc4be0a@redhat.com> Date: Thu, 18 Jan 2018 18:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00380.txt.bz2 On 01/18/2018 06:25 PM, Andreas Arnez wrote: > In August 2017 the GDB test suite was changed to always add the compile > option "-fdiagnostics-color=never", see: > > https://sourceware.org/ml/gdb-patches/2017-08/msg00150.html > > Since this option is not understood by rustc, a commit from 09/2017 > dropped its use in that case: > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=5eb5f850 > ("Don't use -fdiagnostics-color=never for rustc") > > But that change goes overboard and stops using the option for other > languages as well. Thus compiler diagnostics written into gdb.log may > contain colored output again. This is fixed. > > gdb/testsuite/ChangeLog: > > * lib/gdb.exp (gdb_compile): Re-enable use of > universal_compile_options for languages other than Rust. OK. Looks obvious to me. Thanks, Pedro Alves