From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 58089386186A
 for <gdb-patches@sourceware.org>; Mon,  7 Sep 2020 18:48:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58089386186A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id EC6AC1E509;
 Mon,  7 Sep 2020 14:48:40 -0400 (EDT)
Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file
To: Kamil Rytarowski <kamil@netbsd.org>,
 Andrew Burgess <andrew.burgess@embecosm.com>
Cc: tom@tromey.com, gdb-patches@sourceware.org
References: <20200904002905.13616-1-n54@gmx.com>
 <20200904002905.13616-5-n54@gmx.com> <20200907075741.GG853475@embecosm.com>
 <3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org>
From: Simon Marchi <simark@simark.ca>
Message-ID: <7f8fb7bd-f0d4-2ab0-1bfd-d8d624c78c0f@simark.ca>
Date: Mon, 7 Sep 2020 14:48:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <3562912c-2b32-2b5a-308a-d4a28d12f5d9@netbsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2020 18:48:42 -0000

On 2020-09-07 9:36 a.m., Kamil Rytarowski wrote:
>> The convention in GDB is to document global functions in the header
>> file, and leave a comment '/* See xxxx.h.  */' in the source file.
>>
>> Thanks,
>> Andrew
>>
>>
> OK. I will do it in v3.
> 

Thanks, don't forget to apply it in other other patches too (such as 05/10).

Simon