From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74622 invoked by alias); 7 Jun 2018 20:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74611 invoked by uid 89); 7 Jun 2018 20:42:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Jun 2018 20:42:26 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 1F.9D.13413.FA8991B5; Thu, 7 Jun 2018 22:42:23 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSHC022.ericsson.se (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 7 Jun 2018 22:41:35 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 7 Jun 2018 22:41:35 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 7 Jun 2018 22:41:35 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.240] (192.75.88.130) by SN6PR15MB2399.namprd15.prod.outlook.com (2603:10b6:805:24::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.15; Thu, 7 Jun 2018 20:41:33 +0000 Subject: Re: [PATCH v2 03/10] Add reg_buffer_common From: Simon Marchi To: Alan Hayward , CC: References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-4-alan.hayward@arm.com> <17367496-22c7-d61c-6800-cbdfd856f308@ericsson.com> Message-ID: <7f73ec69-1ec5-3d02-0433-d822cbb55126@ericsson.com> Date: Thu, 07 Jun 2018 20:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <17367496-22c7-d61c-6800-cbdfd856f308@ericsson.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN6PR08CA0028.namprd08.prod.outlook.com (2603:10b6:805:66::41) To SN6PR15MB2399.namprd15.prod.outlook.com (2603:10b6:805:24::19) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR15MB2399: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Forefront-PRVS: 06968FD8C4 Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Office365-Filtering-Correlation-Id: 033ebefb-3634-4560-8147-08d5ccb70ea0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2018 20:41:33.4991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 033ebefb-3634-4560-8147-08d5ccb70ea0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2399 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00182.txt.bz2 On 2018-06-07 04:18 PM, Simon Marchi wrote: > Hi Alan, > > Just some quick comments. > > I get this when building on x86-64 with --enable-targets=all: > > CXX aarch64-tdep.o > In file included from /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-sve-linux-ptrace.h:29:0, > from /home/emaisin/src/binutils-gdb/gdb/aarch64-tdep.c:61: > /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-linux-sigcontext.h:19:22: error: field ‘head’ has incomplete type ‘_aarch64_ctx’ > struct _aarch64_ctx head; > ^ > /home/emaisin/src/binutils-gdb/gdb/nat/aarch64-linux-sigcontext.h:19:9: note: forward declaration of ‘struct _aarch64_ctx’ > struct _aarch64_ctx head; > ^ > > First, we should not include "nat/aarch64-sve-linux-ptrace.h" (a file that only makes > sense when building on AArch64) in aarch64-tdep.c, a file built on all architecture > when including the support for AArch64 debugging. It looks like aarch64-tdep.c > needs sve_vq_from_vl. Maybe that definition could be moved to arch/, which can be > included in aarch64-tdep.c. > > Then, is the _aarch64_ctx structure guaranteed to be defined on older AArch64 kernels > or should we include it too? Sorry, I mixed things up, this feedback is about patch 2/10 actually. The other comments apply to this patch (3/10). Simon