From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31807 invoked by alias); 4 Oct 2016 17:41:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31790 invoked by uid 89); 4 Oct 2016 17:41:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=corrupts, Von, von X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Oct 2016 17:41:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 099CAC049D5C; Tue, 4 Oct 2016 17:41:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u94HfFb3002879; Tue, 4 Oct 2016 13:41:15 -0400 Subject: Re: [PING] RE: [RFC][PATCH] - Fix pretty-printers which call the inferiors, mi-interface crashs To: =?UTF-8?B?VsO2cnRsZXIsIFRoaWxv?= , "gdb-patches@sourceware.org" References: <98af10fc7cb34b1baf4e28408ad6d782@EX132MBOX2B.de2.local> From: Pedro Alves Message-ID: <7f4f079e-bb85-5a67-6445-8ab102b0742c@redhat.com> Date: Tue, 04 Oct 2016 17:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <98af10fc7cb34b1baf4e28408ad6d782@EX132MBOX2B.de2.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-10/txt/msg00053.txt.bz2 Hi there, Sorry for the delay. Thanks much for digging in and writing the patch. It'd be really great if we could have a testcase in the testsuite to exercise this. That'd help move the patch along, and, it'd make sure we don't regress again in the future. Thanks, Pedro Alves On 06/27/2016 03:35 PM, Vörtler, Thilo wrote: >> -----Ursprüngliche Nachricht----- >> Von: Vörtler, Thilo >> Gesendet: Donnerstag, 2. Juni 2016 11:09 >> An: 'gdb-patches@sourceware.org' >> Betreff: [RFC][PATCH] - Fix pretty-printers which call the inferiors, mi- >> interface crashs >> >> Hi, >> as described in Bug 17437 the mi interface corrupts cached frames in the >> list_arg_or_local function of mi-cmd-stack.c when a pretty-printer calls a >> function of the inferior. To prevent this the frame_id is stored and used to >> restore the frame after calling list_arg_or_local >> - MI regressions were run and no effect through the patch was seen >> >> Is this patch okay? >> >> BR, Thilo >> >> >> gdb/ChangeLog: >> >> 2016-06-02 Thilo Vörtler >> >> * mi-cmd-stack.c (list_args_or_locals) the mi interface corrupts >> cached frames in the list_arg_or_local function of mi-cmd-stack.c >> when >> a pretty-printer calls a function of the inferior. To prevent this the >> frame_id is stored and used to restore the frame after calling >> list_arg_or_local