From: "Jan Vraný" <Jan.Vrany@labware.com>
To: "tom@tromey.com" <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"vries@gcc.gnu.org" <vries@gcc.gnu.org>,
"tromey@sourceware.org" <tromey@sourceware.org>,
"thiago.bauermann@linaro.org" <thiago.bauermann@linaro.org>,
"simon.marchi@efficios.com" <simon.marchi@efficios.com>
Subject: Re: [PATCH] Revert "gdb: change blockvector::contains() to handle blockvectors with "holes""
Date: Thu, 18 Dec 2025 20:45:01 +0000 [thread overview]
Message-ID: <7f1f14e1358997cffaa9574fd84823db3fc2ff78.camel@labware.com> (raw)
In-Reply-To: <87bjjvmxfr.fsf@tromey.com>
On Thu, 2025-12-18 at 11:55 -0700, Tom Tromey wrote:
> > > > > > "Jan" == Jan Vraný <Jan.Vrany@labware.com> writes:
>
> Jan> I do not know what's the policy regarding regressions. If everyone can tolerate
> Jan> these regressions for longer, I can try to do some more debugging and see.
>
> I suggest we land the backout and then investigate.
> Like I said, I hate to do this, but I guess the bug seems big enough
> that we shouldn't hold anything else up for this.
>
> For the backout:
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks. Will run all tests again and push soon.
>
> If you'd rather not look into the problems, that's totally fine, but
> would you mind filing a bug with your findings?
I'm actually still looking into it when time allows. I do not like
not understanding what's going on. So far it looks like some weird
interference with unwinding. I find that part of GDB particularly
tricky :-) Of course I'll update the bug with my findings.
Jan
>
> thank you,
> Tom
prev parent reply other threads:[~2025-12-18 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 18:07 Jan Vrany
2025-12-15 12:08 ` [PING] " Jan Vraný
2025-12-15 14:49 ` Tom Tromey
2025-12-16 14:24 ` Jan Vraný
2025-12-18 18:55 ` Tom Tromey
2025-12-18 20:45 ` Jan Vraný [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f1f14e1358997cffaa9574fd84823db3fc2ff78.camel@labware.com \
--to=jan.vrany@labware.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=thiago.bauermann@linaro.org \
--cc=tom@tromey.com \
--cc=tromey@sourceware.org \
--cc=vries@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox