From: Simon Marchi <simon.marchi@polymtl.ca>
To: Stafford Horne <shorne@gmail.com>,
GDB patches <gdb-patches@sourceware.org>
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
Date: Wed, 27 Dec 2017 00:30:00 -0000 [thread overview]
Message-ID: <7efaac98-a656-1453-5ecb-f3cf5184b7b7@polymtl.ca> (raw)
In-Reply-To: <20171226134832.23497-5-shorne@gmail.com>
On 2017-12-26 08:48 AM, Stafford Horne wrote:
> tdesc_register_in_reggroup_p in now able to handle arbitrary
> groups. This is useful when groups are created while the
> target descriptor file is received from the remote.
>
> This can be the case of a soft core target processor where
> registers/groups can change.
>
> gdb/ChangeLog:
>
> yyyy-mm-dd Franck Jullien <franck.jullien@gmail.com>
> Stafford Horne <shorne@gmail.com>
>
> * target-descriptions.c (tdesc_register_in_reggroup_p): Support
> arbitrary strings.
Please mention tdesc_use_registers in the ChangeLog. I also usually mention
changes to comments, such as the change to tdesc_reg::group's comment.
LGTM with that fixed.
Thanks!
Simon
prev parent reply other threads:[~2017-12-27 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 13:48 [PATCH v4 0/4] Support for arbitrary reggroups Stafford Horne
2017-12-26 13:48 ` [PATCH v4 3/4] reggroups: Add reggroup_gdbarch_new, reggroup_find for dynamic reggroups Stafford Horne
2017-12-27 0:28 ` Simon Marchi
2017-12-26 13:48 ` [PATCH v4 1/4] reggroups: Add test and docs for `info reg $reggroup` feature Stafford Horne
2017-12-26 15:56 ` Eli Zaretskii
2017-12-27 0:20 ` Simon Marchi
2017-12-27 14:34 ` Stafford Horne
2017-12-26 13:48 ` [PATCH v4 2/4] reggroups: Convert reggroups from post_init to pre_init Stafford Horne
2017-12-26 13:49 ` [PATCH v4 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-12-26 15:57 ` Eli Zaretskii
2017-12-27 0:30 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7efaac98-a656-1453-5ecb-f3cf5184b7b7@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox