From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81807 invoked by alias); 21 Dec 2018 17:00:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81247 invoked by uid 89); 21 Dec 2018 17:00:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=HX-Brightmail-Tracker:sk:H4sIAAA, targeting, H*RU:sk:sessmg2, UD:ericsson.com X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 17:00:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1545411600; x=1548003600; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MEfDgRsf/croVspyb5fBOlgSmGXhshCY8pbHRwZ50RU=; b=KXIuVVOsPCy3XNZetMdq4EmrVe3bCQBVcXP/govJLyOeA03FiMwPD0T1N1OcC+cu Cx6QkphKLw5vTzE32yYpNMIBpkbBF0twXLEYL5CCCi+Oe6IkBNbDMdi0/+MRhzio 3tIhC4RTxN2TtN+c85tAfC34mngIK+VI65I1YQqW4HA=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 25.3D.01583.01C1D1C5; Fri, 21 Dec 2018 18:00:00 +0100 (CET) Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 21 Dec 2018 18:00:00 +0100 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 21 Dec 2018 17:59:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEfDgRsf/croVspyb5fBOlgSmGXhshCY8pbHRwZ50RU=; b=lSYPJqsQpTmxDp04fifzn4ZdkOS5ONZcdpI/0gfEIvASFdgjAqOTf9kaOllRX+e7aCvjLNaOeVbiNANLsZ7RnGDGRQulIuFh5MomgoyUtdgFcmsjQltqIm+dAHII9HaYk9TglQi0ock3U+Bjegpco3kDgPK0G+1RuRGugpI3Uew= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2245.namprd15.prod.outlook.com (52.135.196.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.22; Fri, 21 Dec 2018 16:59:48 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a143:f30c:dd42:3af9]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a143:f30c:dd42:3af9%4]) with mapi id 15.20.1425.025; Fri, 21 Dec 2018 16:59:48 +0000 From: Simon Marchi To: Dave Murphy , Simon Marchi CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] fix compile error with clang Date: Fri, 21 Dec 2018 17:00:00 -0000 Message-ID: <7ec112b7-d8b5-cf59-3596-06455531f2c2@ericsson.com> References: In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00250.txt.bz2 T24gMjAxOC0xMi0yMCA0OjM4IHAubS4sIERhdmUgTXVycGh5IHdyb3RlOg0K PiBIaSBTaW1vbiwNCj4gDQo+IFRoZSBlcnJvciBJIGdldCBpcw0KPiANCj4g Li4vLi4vYmludXRpbHMtZ2RiL2dkYi91bml0dGVzdHMvb2JzZXJ2YWJsZS1z ZWxmdGVzdHMuYzo3MzozMTogZXJyb3I6DQo+IGRlZmF1bHQgaW5pdGlhbGl6 YXRpb24gb2YgYW4gb2JqZWN0IG9mIGNvbnN0IHR5cGUgJ2NvbnN0DQo+IGdk Yjo6b2JzZXJ2ZXJzOjp0b2tlbicgd2l0aG91dCBhIHVzZXItcHJvdmlkZWQg ZGVmYXVsdCBjb25zdHJ1Y3Rvcg0KPiAgIGNvbnN0IGdkYjo6b2JzZXJ2ZXJz Ojp0b2tlbiB0b2tlbjEsIHRva2VuMiwgdG9rZW4zOw0KPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBeDQo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHt9DQo+IGNsYW5nIHZlcnNpb24gaXMNCj4gDQo+ IGRhdmVtQGRldmtpdC1idWlsZGVyOn4kIC9vcHQvb3N4L2Jpbi94ODZfNjQt YXBwbGUtZGFyd2luMTUtY2xhbmcgLS12ZXJzaW9uDQo+IA0KPiBjbGFuZyB2 ZXJzaW9uIDMuOC4xLTI0ICh0YWdzL1JFTEVBU0VfMzgxL2ZpbmFsKQ0KPiBU YXJnZXQ6IHg4Nl82NC1hcHBsZS1kYXJ3aW4xNQ0KPiBUaHJlYWQgbW9kZWw6 IHBvc2l4DQo+IA0KPiAodGFyZ2V0aW5nIDEwLjkrIGhvc3QpDQo+IA0KPiBi dWlsZCBtYWNoaW5lIGlzIGRlYmlhbiBzdHJldGNoDQo+IA0KPiBkYXZlbUBk ZXZraXQtYnVpbGRlcjp+JCB1bmFtZSAtYQ0KPiBMaW51eCBkZXZraXQtYnVp bGRlciA0LjkuMC04LWFtZDY0ICMxIFNNUCBEZWJpYW4gNC45LjEzMC0yDQo+ ICgyMDE4LTEwLTI3KSB4ODZfNjQgR05VL0xpbnV4DQoNClRoYW5rcyBmb3Ig dGhlIGRldGFpbHMsIEkgd2FzIGFibGUgdG8gcmVwcm9kdWNlIHVzaW5nIGNs YW5nIDMuOCBvbiBEZWJpYW4gc3RhYmxlLg0KSSB0aGluayBpdCdzIHdvcnRo IGZpeGluZyBzaW5jZSBpdCBkb2Vzbid0IGh1cnQgd2hlbiBidWlsZGluZyBv dGhlciBjb21waWxlcnMsDQphbmQgY2xhbmcgMy44IGlzIHN0aWxsIHRoZSBk ZWZhdWx0IGNsYW5nIHZlcnNpb24gb24gdGhlIGN1cnJlbnQgRGViaWFuIHN0 YWJsZS4NCg0KSGVyZSdzIHdoYXQgSSBwdXNoZWQ6DQoNCkZyb20gM2RjZmRj NTg2NTZjYWE0YTM4ZTFmZGU3M2EwN2ExOTExNDM0NzIyNiBNb24gU2VwIDE3 IDAwOjAwOjAwIDIwMDENCkZyb206IERhdmUgTXVycGh5IDxkYXZlbUBkZXZr aXRwcm8ub3JnPg0KRGF0ZTogRnJpLCAyMSBEZWMgMjAxOCAxMToxNDoyOCAt MDUwMA0KU3ViamVjdDogW1BBVENIXSBGaXggY29tcGlsZSBlcnJvciB3aXRo IGNsYW5nIDMuOA0KDQpXaGVuIGNvbXBpbGluZyB3aXRoIGNsYW5nIDMuOCAo ZGVmYXVsdCBjbGFuZyB2ZXJzaW9uIG9uIERlYmlhbg0KU3RyZXRjaCwgdGhl IGN1cnJlbnQgc3RhYmxlKSwgd2UgZ2V0IGVycm9ycyBsaWtlIHRoaXM6DQoN CiAgQ1hYICAgIGR0cmFjZS1wcm9iZS5vDQouLi8uLi9iaW51dGlscy1nZGIv Z2RiL2R0cmFjZS1wcm9iZS5jOjEwMzozMTogZXJyb3I6IGRlZmF1bHQgaW5p dGlhbGl6YXRpb24gb2YgYW4gb2JqZWN0IG9mIGNvbnN0IHR5cGUgJ2NvbnN0 IGR0cmFjZV9zdGF0aWNfcHJvYmVfb3BzJyB3aXRob3V0IGEgdXNlci1wcm92 aWRlZCBkZWZhdWx0IGNvbnN0cnVjdG9yDQpjb25zdCBkdHJhY2Vfc3RhdGlj X3Byb2JlX29wcyBkdHJhY2Vfc3RhdGljX3Byb2JlX29wczsNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIF4NCg0KU2lsZW5jZSB0aGVtIGJ5IHZh bHVlLWluaXRpYWxpemluZyB0aG9zZSBvYmplY3RzLiAgSXQncyBub3QgbmVj ZXNzYXJ5DQp3aXRoIG90aGVyIGNvbXBpbGVycyAobGF0ZXIgY2xhbmcgdmVy c2lvbnMsIGdjYyksIGJ1dCBpdCBzaG91bGRuJ3QNCmh1cnQgZWl0aGVyLg0K LS0tDQogZ2RiL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgIHwg MTAgKysrKysrKysrKw0KIGdkYi9kdHJhY2UtcHJvYmUuYyAgICAgICAgICAg ICAgICAgICB8ICAyICstDQogZ2RiL3Byb2JlLmMgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgIDIgKy0NCiBnZGIvcmVjb3JkLWJ0cmFjZS5jICAgICAg ICAgICAgICAgICAgfCAgMiArLQ0KIGdkYi9zdGFwLXByb2JlLmMgICAgICAg ICAgICAgICAgICAgICB8ICAyICstDQogZ2RiL3R1aS90dWktaG9va3MuYyAg ICAgICAgICAgICAgICAgIHwgIDIgKy0NCiBnZGIvdW5pdHRlc3RzL29ic2Vy dmFibGUtc2VsZnRlc3RzLmMgfCAgMiArLQ0KIDcgZmlsZXMgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdp dCBhL2dkYi9DaGFuZ2VMb2cgYi9nZGIvQ2hhbmdlTG9nDQppbmRleCAyOGFi MzM0NTAzMi4uOTUzYmMxN2JlMWYgMTAwNjQ0DQotLS0gYS9nZGIvQ2hhbmdl TG9nDQorKysgYi9nZGIvQ2hhbmdlTG9nDQpAQCAtMSwzICsxLDEzIEBADQor MjAxOC0xMi0yMSAgRGF2ZSBNdXJwaHkgIDxkYXZlbUBkZXZraXRwcm8ub3Jn Pg0KKw0KKwkqIGR0cmFjZS1wcm9iZS5jIChkdHJhY2Vfc3RhdGljX3Byb2Jl X29wcyk6IEV4cGxpY2l0IHplcm8NCisJaW5pdGlhbGlzZS4NCisJKiBwcm9i ZS5jIChhbnlfc3RhdGljX3Byb2JlX29wcyk6IERpdHRvLg0KKwkqIHJlY29y ZC1idHJhY2UuYyAocmVjb3JkX2J0cmFjZV90aHJlYWRfb2JzZXJ2ZXJfdG9r ZW4pOiBEaXR0by4NCisJKiBzdGFwLXByb2JlLmMgKHN0YXBfc3RhdGljX3By b2JlX29wcyk6IERpdHRvLg0KKwkqIHR1aS90dWktaG9va3MuYyAodHVpX29i c2VydmVyc190b2tlbik6IERpdHRvLg0KKwkqIHVuaXR0ZXN0cy9vYnNlcnZh YmxlLXNlbGZ0ZXN0cy5jICh0b2tlbjEsIHRva2VuMiwgdG9rZW4zKTogRGl0 dG8uDQorDQogMjAxOC0xMi0xOSAgQW5kcmV3IEJ1cmdlc3MgIDxhbmRyZXcu YnVyZ2Vzc0BlbWJlY29zbS5jb20+DQoNCiAJKiBnZGIvZHVtbXktZnJhbWUu YyAoZGVmYXVsdF9kdW1teV9pZCk6IERlZmluZWQgbmV3IGZ1bmN0aW9uLg0K ZGlmZiAtLWdpdCBhL2dkYi9kdHJhY2UtcHJvYmUuYyBiL2dkYi9kdHJhY2Ut cHJvYmUuYw0KaW5kZXggZmE0ZTA2ZTc5NDcuLjBjNzU5MDRjNTg1IDEwMDY0 NA0KLS0tIGEvZ2RiL2R0cmFjZS1wcm9iZS5jDQorKysgYi9nZGIvZHRyYWNl LXByb2JlLmMNCkBAIC0xMDAsNyArMTAwLDcgQEAgcHVibGljOg0KDQogLyog RFRyYWNlIHN0YXRpY19wcm9iZV9vcHMuICAqLw0KDQotY29uc3QgZHRyYWNl X3N0YXRpY19wcm9iZV9vcHMgZHRyYWNlX3N0YXRpY19wcm9iZV9vcHM7DQor Y29uc3QgZHRyYWNlX3N0YXRpY19wcm9iZV9vcHMgZHRyYWNlX3N0YXRpY19w cm9iZV9vcHMge307DQoNCiAvKiBUaGUgZm9sbG93aW5nIHN0cnVjdHVyZSBy ZXByZXNlbnRzIGEgZHRyYWNlIHByb2JlLiAgKi8NCg0KZGlmZiAtLWdpdCBh L2dkYi9wcm9iZS5jIGIvZ2RiL3Byb2JlLmMNCmluZGV4IDFmM2RhMjEzZWZj Li41NzAyYWZlMGQyZiAxMDA2NDQNCi0tLSBhL2dkYi9wcm9iZS5jDQorKysg Yi9nZGIvcHJvYmUuYw0KQEAgLTYwLDcgKzYwLDcgQEAgcHVibGljOg0KDQog LyogU3RhdGljIG9wZXJhdGlvbnMgYXNzb2NpYXRlZCB3aXRoIGEgZ2VuZXJp YyBwcm9iZS4gICovDQoNCi1jb25zdCBhbnlfc3RhdGljX3Byb2JlX29wcyBh bnlfc3RhdGljX3Byb2JlX29wczsNCitjb25zdCBhbnlfc3RhdGljX3Byb2Jl X29wcyBhbnlfc3RhdGljX3Byb2JlX29wcyB7fTsNCg0KIC8qIEEgaGVscGVy IGZvciBwYXJzZV9wcm9iZXMgdGhhdCBkZWNvZGVzIGEgcHJvYmUgc3BlY2lm aWNhdGlvbiBpbg0KICAgIFNFQVJDSF9QU1BBQ0UuICBJdCBhcHBlbmRzIG1h dGNoaW5nIFNBTHMgdG8gUkVTVUxULiAgKi8NCmRpZmYgLS1naXQgYS9nZGIv cmVjb3JkLWJ0cmFjZS5jIGIvZ2RiL3JlY29yZC1idHJhY2UuYw0KaW5kZXgg MWNhMDE3NmVjODEuLjkyYzA4MjFlYzkyIDEwMDY0NA0KLS0tIGEvZ2RiL3Jl Y29yZC1idHJhY2UuYw0KKysrIGIvZ2RiL3JlY29yZC1idHJhY2UuYw0KQEAg LTE0Myw3ICsxNDMsNyBAQCBzdGF0aWMgcmVjb3JkX2J0cmFjZV90YXJnZXQg cmVjb3JkX2J0cmFjZV9vcHM7DQoNCiAvKiBUb2tlbiBhc3NvY2lhdGVkIHdp dGggYSBuZXctdGhyZWFkIG9ic2VydmVyIGVuYWJsaW5nIGJyYW5jaCB0cmFj aW5nDQogICAgZm9yIHRoZSBuZXcgdGhyZWFkLiAgKi8NCi1zdGF0aWMgY29u c3QgZ2RiOjpvYnNlcnZlcnM6OnRva2VuIHJlY29yZF9idHJhY2VfdGhyZWFk X29ic2VydmVyX3Rva2VuOw0KK3N0YXRpYyBjb25zdCBnZGI6Om9ic2VydmVy czo6dG9rZW4gcmVjb3JkX2J0cmFjZV90aHJlYWRfb2JzZXJ2ZXJfdG9rZW4g e307DQoNCiAvKiBNZW1vcnkgYWNjZXNzIHR5cGVzIHVzZWQgaW4gc2V0L3No b3cgcmVjb3JkIGJ0cmFjZSByZXBsYXktbWVtb3J5LWFjY2Vzcy4gICovDQog c3RhdGljIGNvbnN0IGNoYXIgcmVwbGF5X21lbW9yeV9hY2Nlc3NfcmVhZF9v bmx5W10gPSAicmVhZC1vbmx5IjsNCmRpZmYgLS1naXQgYS9nZGIvc3RhcC1w cm9iZS5jIGIvZ2RiL3N0YXAtcHJvYmUuYw0KaW5kZXggZWQ3ZTFhMGQzZmIu LmI3OWNiMTUzYTkzIDEwMDY0NA0KLS0tIGEvZ2RiL3N0YXAtcHJvYmUuYw0K KysrIGIvZ2RiL3N0YXAtcHJvYmUuYw0KQEAgLTExOSw3ICsxMTksNyBAQCBw dWJsaWM6DQoNCiAvKiBTeXN0ZW1UYXAgc3RhdGljX3Byb2JlX29wcy4gICov DQoNCi1jb25zdCBzdGFwX3N0YXRpY19wcm9iZV9vcHMgc3RhcF9zdGF0aWNf cHJvYmVfb3BzOw0KK2NvbnN0IHN0YXBfc3RhdGljX3Byb2JlX29wcyBzdGFw X3N0YXRpY19wcm9iZV9vcHMge307DQoNCiBjbGFzcyBzdGFwX3Byb2JlIDog cHVibGljIHByb2JlDQogew0KZGlmZiAtLWdpdCBhL2dkYi90dWkvdHVpLWhv b2tzLmMgYi9nZGIvdHVpL3R1aS1ob29rcy5jDQppbmRleCBlZmEwMmUyZjA4 YS4uM2E5YmZmMzBhNmEgMTAwNjQ0DQotLS0gYS9nZGIvdHVpL3R1aS1ob29r cy5jDQorKysgYi9nZGIvdHVpL3R1aS1ob29rcy5jDQpAQCAtMjA1LDcgKzIw NSw3IEBAIHR1aV9ub3JtYWxfc3RvcCAoc3RydWN0IGJwc3RhdHMgKmJzLCBp bnQgcHJpbnRfZnJhbWUpDQoNCiAvKiBUb2tlbiBhc3NvY2lhdGVkIHdpdGgg b2JzZXJ2ZXJzIHJlZ2lzdGVyZWQgd2hpbGUgVFVJIGhvb2tzIGFyZQ0KICAg IGluc3RhbGxlZC4gICovDQotc3RhdGljIGNvbnN0IGdkYjo6b2JzZXJ2ZXJz Ojp0b2tlbiB0dWlfb2JzZXJ2ZXJzX3Rva2VuOw0KK3N0YXRpYyBjb25zdCBn ZGI6Om9ic2VydmVyczo6dG9rZW4gdHVpX29ic2VydmVyc190b2tlbiB7fTsN Cg0KIC8qIEF0dGFjaCBvciBkZXRhY2ggYSBzaW5nbGUgb2JzZXJ2ZXIsIGFj Y29yZGluZyB0byBBVFRBQ0guICAqLw0KDQpkaWZmIC0tZ2l0IGEvZ2RiL3Vu aXR0ZXN0cy9vYnNlcnZhYmxlLXNlbGZ0ZXN0cy5jIGIvZ2RiL3VuaXR0ZXN0 cy9vYnNlcnZhYmxlLXNlbGZ0ZXN0cy5jDQppbmRleCA2ZjJmN2U4YmNjZi4u OTAzYmFhNzQxYzUgMTAwNjQ0DQotLS0gYS9nZGIvdW5pdHRlc3RzL29ic2Vy dmFibGUtc2VsZnRlc3RzLmMNCisrKyBiL2dkYi91bml0dGVzdHMvb2JzZXJ2 YWJsZS1zZWxmdGVzdHMuYw0KQEAgLTcwLDcgKzcwLDcgQEAgcnVuX3Rlc3Rz ICgpDQogICAgICBhdHRhY2hlZC4gICovDQogICBub3RpZnlfY2hlY2tfY291 bnRlcnMgKDAsIDAsIDApOw0KDQotICBjb25zdCBnZGI6Om9ic2VydmVyczo6 dG9rZW4gdG9rZW4xLCB0b2tlbjIsIHRva2VuMzsNCisgIGNvbnN0IGdkYjo6 b2JzZXJ2ZXJzOjp0b2tlbiB0b2tlbjEge30sIHRva2VuMiB7fSAsIHRva2Vu MyB7fTsNCg0KICAgLyogTm93LCBhdHRhY2ggb25lIG9ic2VydmVyLCBhbmQg c2VuZCBhIG5vdGlmaWNhdGlvbi4gICovDQogICB0ZXN0X25vdGlmaWNhdGlv bi5hdHRhY2ggKCZ0ZXN0X3NlY29uZF9ub3RpZmljYXRpb25fZnVuY3Rpb24s IHRva2VuMik7DQotLSANCjIuMjAuMQ0KDQoNCg== >From gdb-patches-return-152909-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Dec 21 17:16:48 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 109759 invoked by alias); 21 Dec 2018 17:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 109748 invoked by uid 89); 21 Dec 2018 17:16:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr1-f52.google.com Received: from mail-wr1-f52.google.com (HELO mail-wr1-f52.google.com) (209.85.221.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 17:16:46 +0000 Received: by mail-wr1-f52.google.com with SMTP id c14so6037122wrr.0 for ; Fri, 21 Dec 2018 09:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p2Nwj9nGHyHu5DS+biR2ovRHhN1CAJInMV017zVf4QI=; b=EvYvvqirf82G4UxAOE1W97g1aVPnX/EWbFYT1dsZH30dJly1ahbtfStppAvBHpWBd/ NStK9pPpATO6FQN7NEqWg1EGTelKQPDurEU3fdCFhZJna9KD6SEO3oCgxLZ39lryt7ga Pm7md1TAQQULPGqYtO+9nO7oSCVMsd30/6T+3b/fEyyKdISt65lnKu8uJ8ZaI4ZiNCJB sjLJ/fHgO6ETv4uai+m43TVpdtItW2JUqjczkmchN9C9X8DthYFUR8HwQWJuZps2Z5E8 8MBqy1fJSjcRLM+nZ1jHYeGBfPyuCDMnpalxVutGJKzPNG8Kj/3Wjv6IdeMYJ1XAsgAc gRmQ== Return-Path: Received: from localhost (host86-156-236-210.range86-156.btcentralplus.com. [86.156.236.210]) by smtp.gmail.com with ESMTPSA id s1sm15153129wro.9.2018.12.21.09.16.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Dec 2018 09:16:42 -0800 (PST) Date: Fri, 21 Dec 2018 17:16:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: Simon Marchi , GDB Patches Subject: Re: riscv-tdep.c in 32-bits build Message-ID: <20181221171641.GH3456@embecosm.com> References: <6948b903-63f2-b0d2-4f66-738b95b51385@ericsson.com> <20181221005727.GF3456@embecosm.com> <87va3msy4t.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87va3msy4t.fsf@tromey.com> X-Fortune: Sauron is alive in Argentina! X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00251.txt.bz2 Content-length: 2228 * Tom Tromey [2018-12-21 08:22:26 -0700]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Anyway, I propose casting to LONGEST and printing that. Unless you > Andrew> object I'll push this in a few days. > > It's fine; but as CORE_ADDR is (and will always be) unsigned, I think > you could use pulongest without a cast. Thanks for the review. I pushed a version that still uses 'plongest' as the offsets in questions are signed, and always (assuming descending stack) negative. I understand some of interfaces are a bit wonky in this area as far as signed/unsigned types, so maybe there's a bigger improvement that needs to be done? Any suggestions welcome :) Here's what I pushed, Thanks, Andrew -- gdb/riscv: Format CORE_ADDR as a string for printing Avoid compiler errors caused by trying to print CORE_ADDR using '%ld' format, instead convert to a string and print that instead. gdb/ChangeLog: * riscv-tdep.c (riscv_scan_prologue): Use plongest to format a signed offset as a string. --- gdb/ChangeLog | 5 +++++ gdb/riscv-tdep.c | 14 ++++++++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index 88b79af866f..6a55ab8b643 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -1542,10 +1542,16 @@ riscv_scan_prologue (struct gdbarch *gdbarch, if (stack.find_reg (gdbarch, i, &offset)) { if (riscv_debug_unwinder) - fprintf_unfiltered (gdb_stdlog, - "Register $%s at stack offset %ld\n", - gdbarch_register_name (gdbarch, i), - offset); + { + /* Display OFFSET as a signed value, the offsets are from + the frame base address to the registers location on + the stack, with a descending stack this means the + offsets are always negative. */ + fprintf_unfiltered (gdb_stdlog, + "Register $%s at stack offset %s\n", + gdbarch_register_name (gdbarch, i), + plongest ((LONGEST) offset)); + } trad_frame_set_addr (cache->regs, i, offset); } } -- 2.14.5