From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7uyAHVee0WcBTg0AWB0awg (envelope-from ) for ; Wed, 12 Mar 2025 10:46:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Kmyr8xZ4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 699D81E105; Wed, 12 Mar 2025 10:46:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 96F981E08E for ; Wed, 12 Mar 2025 10:46:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1AF87385840D for ; Wed, 12 Mar 2025 14:46:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AF87385840D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Kmyr8xZ4 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 33550385841E for ; Wed, 12 Mar 2025 14:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33550385841E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 33550385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741790673; cv=none; b=MN7S//SXlpHFCtxb3a6OXu0JFjhCNfnw2WXjlAuy/LgPPc1PHM7tT4X2r4RxGwwo/hgGqtOLE/VeyZHmsyzC/carMgPJ2Crbw5068mktmJjhRqhwSdI8+ELchUyJ6OkYz/fLMI6r4+65qitpYKj/Zf168sigRlqKpBCztfKBRNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741790673; c=relaxed/simple; bh=FAOrvpyGV2jTu9HCk/dmRBU33KsiTx6+jNHg/jExSUU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xxfAeb1pFCo73G1umajmhcodo30PMLdqN2HJMa/9l2zsfpYyJi4lvhBh4PtRDGhwOTI9xmcfRIqTmLuLOfDWJvKajeCSR/hoXP+rMGnE1CKMXSU/o6O15lIw9lR8hDHQJVNHmH9Y/tdqfmYwhS4p7/GdVzTKmyxdV/4n7UGOBSI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 33550385841E Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e673822f76so6662735a12.2 for ; Wed, 12 Mar 2025 07:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741790672; x=1742395472; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O9LX96cfUfVnPVUN9ndtDbPlgWsx3Z0xckr08xxNHU0=; b=Kmyr8xZ4J2vN1eCj6WNlqu/OpNN1klBOb8bgr9IElZfvCX0/E+ybL5huQcwipV7wOi KIZtHo0hTWvLQN2sdO9dQGtKS/4d5F0xwmn4K2+d6VogNSwaiRhAzSK8RbW1O0ZChfEJ SmHECImEXNIHs+Ai2mpB2PLbBUm6OHbmln6+DyvHW7K0qJSa/hf6ALsmXgarjWPmOABX F0VyOKyj/77tst8yIIS4+7PQiUqmWaoI6HuPwB9Qg3mBEsWdJSs74173Otxk8u/GTVCI PhPYddeZDcvZx3y4h8kCNBMGbJuHASG1MYwN4ep44pXcxNeJfBR16vbANqWsdiWiSrXm 50sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741790672; x=1742395472; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O9LX96cfUfVnPVUN9ndtDbPlgWsx3Z0xckr08xxNHU0=; b=TEV/xUm/bG85pFMsuGLZbkQuB8NFLSq/cyxrYKK/oCzxORCA74B/37e4g9t45RU75g GYwdGOZf9RkIcrMkM7RI4ol3C7RnKJSpgdMqAPFVR+Q0cHoEXBwz6gxqo4PPg+NExCrG Y+XBwJT1wg6nsp6XmO3kp2gydp8aIsFSHaBgOKlBfrBtmrE+mdVwfDvvCamUB7gy873C XtJ03Mu03L4o97k5RbMwHSz5UcOZeMg4ueSyUc6aghyv94HwGGICySuGbcSPvv+FmyPt jtMOnea3DRwb7ezCl9wcumyPbuhor41XoN0YrvzkTZCjUVq4aqJQGK7MxeK3xPVKLeOL Ru+Q== X-Gm-Message-State: AOJu0Yz8VYcBjRsS3k80Bsu2FmyAOpMue77h8TCVP6ZYiAxE5RUITl8Q 6X/cTEb43f5WNgJHea9pj8+k89nnD+5ITDcm6G/f+yLqVrJd+4YLFrCV9g2KTZQ= X-Gm-Gg: ASbGncs+Bz8qKdkqTuwrvk21N8jloaiFX8J59dRGVmjnjbT9vU1dRiWqFmAY1yyc2Lm b+5tAlqOqdQ6tdO6M7unMckeeB5SIKFGE9C7wFWBaFqv8NGvK37yCqqGfeVSMBToEUu0qrppxal W/8oMUYZiQGrEo9NTrt0yDvtaQw5waY7LtNeaRMST06cO6/7l+k52MARW0enNGTHe7VdaOiOEMY YRC9f9L6nEL0FYp3r17Bon7axWax3kCUUVGGxzSfHa5/Bh9jRfQoiusK4Zq6IlS7OtmkSNzXftc 9A79WKFagGDOSfpOmZMPHTXOO/ZNpQYe4GrFDpJwbd37W6VK/cpt9ZYRvGbktiZKFA== X-Google-Smtp-Source: AGHT+IH/huxV5s9zRMPIqUWRGXtygEY/bQa34QT38oTBhXArW96G5mnUR8HgfowdmMrxUWpo4abWWw== X-Received: by 2002:a17:907:1c22:b0:ac2:a32c:db1b with SMTP id a640c23a62f3a-ac2a32cf9ffmr1221031066b.6.1741790671559; Wed, 12 Mar 2025 07:44:31 -0700 (PDT) Received: from [140.78.145.202] ([140.78.145.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac239482f3bsm1099698266b.52.2025.03.12.07.44.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 07:44:31 -0700 (PDT) Message-ID: <7ebee6b4-693d-4153-8c65-c53037b8065b@gmail.com> Date: Wed, 12 Mar 2025 15:44:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Add new commands for controlling type signature fallback. To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <9c04ac7d791b96d90c624fba5333f2e9009393a3.1741701275.git.dominik.mascherbauer@oracle.com> <865xkfbhfv.fsf@gnu.org> <3237e31f-16f6-4337-8c09-0d26aee35fc9@gmail.com> <86jz8u5n6o.fsf@gnu.org> Content-Language: en-US From: Dominik Mascherbauer In-Reply-To: <86jz8u5n6o.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> Date: Wed, 12 Mar 2025 10:12:23 +0100 >> Cc: gdb-patches@sourceware.org >> From: Dominik Mascherbauer >> >> Would this be enough, or does it need to be more detailed: > > I think it should be enough, but there are typos to fix: > >> + If type signatures in DWARF objfile are unique, enabling this option to look >> + up type signatures from fallback DWARF objfiles. > > This sentence is incomplete, or maybe some words need to be modified. > >> +Control the behavior of the type signature look up in DWARF objfiles. Type >> +Signatures in DWARF uniquely identify a type unit. A type unit contains debug >> +info for a type and can b referenced by its type signature. Type signature > ^ > "be" > > Thanks. I'll fix that. Thanks.