From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JtDABQwbtmAdXAAAWB0awg (envelope-from ) for ; Tue, 01 Jun 2021 07:33:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 0884E1F163; Tue, 1 Jun 2021 07:33:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 428DC1E813 for ; Tue, 1 Jun 2021 07:33:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D3B80386EC2F; Tue, 1 Jun 2021 11:33:30 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 24266386EC2F for ; Tue, 1 Jun 2021 11:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24266386EC2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2EBFD2191F; Tue, 1 Jun 2021 11:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622547207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoJefDF2Db6LQDb0Hxl82k8QumlcKCkG0TBQIxRBF80=; b=vaKk8ObnNhmzXTfuWBwWGuaKOjvGeYZ7NJcZs33mHBX6oTHJt/pxxT/oPsl03/xS4GWPvX zZKmAOOIut1ljO/2wA7NsJDdcjjGpxUCGk0Sy+ijYIPIWgJtrdiykpekg/lVBtSXHAjVIt DxMT0svjqPDObgzmznG8rSQtaOACp/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622547207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoJefDF2Db6LQDb0Hxl82k8QumlcKCkG0TBQIxRBF80=; b=KAa1RUmtwD7Y9dBlLXqKAORIIy9vL6d2ts+atH/fe0JB/kcWCaoBGteb59gW0V7VbiUIPq HelNZPckXyaVd2BA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 0BAA6118DD; Tue, 1 Jun 2021 11:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622547207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoJefDF2Db6LQDb0Hxl82k8QumlcKCkG0TBQIxRBF80=; b=vaKk8ObnNhmzXTfuWBwWGuaKOjvGeYZ7NJcZs33mHBX6oTHJt/pxxT/oPsl03/xS4GWPvX zZKmAOOIut1ljO/2wA7NsJDdcjjGpxUCGk0Sy+ijYIPIWgJtrdiykpekg/lVBtSXHAjVIt DxMT0svjqPDObgzmznG8rSQtaOACp/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622547207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BoJefDF2Db6LQDb0Hxl82k8QumlcKCkG0TBQIxRBF80=; b=KAa1RUmtwD7Y9dBlLXqKAORIIy9vL6d2ts+atH/fe0JB/kcWCaoBGteb59gW0V7VbiUIPq HelNZPckXyaVd2BA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id F152AQcbtmA5OAAALh3uQQ (envelope-from ); Tue, 01 Jun 2021 11:33:27 +0000 Subject: Re: [PATCH][gdb/symtab] Ignore cold clones To: Bernd Edlinger , Simon Marchi , gdb-patches@sourceware.org References: <20210531141512.GA3181@delia> <5af89971-6072-bfd3-2bc8-c0255770fd70@polymtl.ca> From: Tom de Vries Message-ID: <7e939933-5689-d7d0-229d-a50474ba283c@suse.de> Date: Tue, 1 Jun 2021 13:33:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 6/1/21 7:18 AM, Bernd Edlinger wrote: > So, I did a gcc lto-bootstrap over night with the current trunk version, > and got these symbols in cc1: > > $ nm cc1|grep do_rpo_vn > 0000000000fb9a70 T _Z9do_rpo_vnP8functionP8edge_defP11bitmap_head > 0000000000fb7a40 t _ZL9do_rpo_vnP8functionP8edge_defP11bitmap_headbb.lto_priv.0 > 0000000000719052 t _ZL9do_rpo_vnP8functionP8edge_defP11bitmap_headbb.lto_priv.0.cold > > does your patch handle these? It does. Demangled we have: ... $ c++filt _ZL9do_rpo_vnP8functionP8edge_defP11bitmap_headbb.lto_priv.0.cold do_rpo_vn(function*, edge_def*, bitmap_head*, bool, bool) [clone .lto_priv.0] [clone .cold] ... I build gdb using gcc-11 and -O2 -flto=auto, and found a similar simbol: ... $ nm -C gdb.lto | grep " init_syscalls_info" 0000000000878a10 T init_syscalls_info(gdbarch*) [clone .lto_priv.0] 0000000000436d19 t init_syscalls_info(gdbarch*) [clone .lto_priv.0] \ [clone .cold] ... With the patch, I have: ... $ gdb -q -batch ./gdb.lto -ex "b init_syscalls_info" -ex "info break" Breakpoint 1 at 0x878a10: file xml-syscall.c, line 338. Num Type Disp Enb Address What 1 breakpoint keep y 0x0000000000878a10 in init_syscalls_info(gdbarch*) at xml-syscall.c:338 ... and without: ... $ gdb -q -batch ./gdb.lto -ex "b init_syscalls_info" -ex "info break" Breakpoint 1 at 0x436d19: init_syscalls_info. (2 locations) Num Type Disp Enb Address 1 breakpoint keep y 1.1 y 0x0000000000436d19 1.2 y 0x0000000000878a10 ... Thanks, - Tom