From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155414-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 68860 invoked by alias); 18 Apr 2019 14:15:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 68834 invoked by uid 89); 18 Apr 2019 14:15:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:519
X-HELO: mail-wm1-f46.google.com
Received: from mail-wm1-f46.google.com (HELO mail-wm1-f46.google.com) (209.85.128.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 14:15:02 +0000
Received: by mail-wm1-f46.google.com with SMTP id w15so3096826wmc.3        for <gdb-patches@sourceware.org>; Thu, 18 Apr 2019 07:15:02 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b])        by smtp.gmail.com with ESMTPSA id y127sm2310035wmg.29.2019.04.18.07.14.59        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Thu, 18 Apr 2019 07:14:59 -0700 (PDT)
Subject: Re: [PATCH v4 2/2] MI: Add new command -complete
To: Jan Vrany <jan.vrany@fit.cvut.cz>, gdb-patches@sourceware.org
References: <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <20190418115847.19854-3-jan.vrany@fit.cvut.cz>
From: Pedro Alves <palves@redhat.com>
Message-ID: <7e80637c-567b-faa5-75fe-e6f04ac9abbd@redhat.com>
Date: Thu, 18 Apr 2019 14:15:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190418115847.19854-3-jan.vrany@fit.cvut.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-04/txt/msg00319.txt.bz2

This version is OK, with the tiny issue below addressed.

Can you push this yourself, or do you need someone to do it for you?

> +/* Implement the "-complete" command.  */
> +
> +void
> +mi_cmd_complete (const char *command, char **argv, int argc)
> +{
> +  if (argc != 1)
> +    error (_("Usage: -complete COMMAND"));
> +
> +  if (max_completions == 0)
> +    error (_("max-completions is zero, completion is disabled.\n"));

errors should not end in \n.

Thanks,
Pedro Alves