From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Yw7fOLJQNWpDbQ8AWB0awg (envelope-from ) for ; Fri, 19 Jun 2026 10:22:42 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=juT9LteR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D8BFA1E098; Fri, 19 Jun 2026 10:22:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FB1A1E024 for ; Fri, 19 Jun 2026 10:22:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3D3D4BAE7D2 for ; Fri, 19 Jun 2026 14:22:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3D3D4BAE7D2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=juT9LteR Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DA9DE4BA2E08 for ; Fri, 19 Jun 2026 14:22:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA9DE4BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA9DE4BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781878937; cv=none; b=LFTmewfzqwoNntaJpBCModz6RHWyzuTZ3F4te0vBU4DDMhHKxxm+gwjlQukuVMSBDnfZXTvjduK6soEGEfHQ6piWQJ3C5WxcQrDo4rzGiQxk8O75nub6nznFI0nNHFTxRBD6ycuEwx4/Ys8uexIz4Lpq1Qkoa2zuxMkjypK/Xa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781878937; c=relaxed/simple; bh=miEzQYMGHbnkM6xdRBuMbv944/kPCjjwDj6aoBvwyyk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nVsA7OIryxXof7k+q6IcAi9QiRuorkSvkYdv+Vqv04oTx8uqTwVz0kWvCw3jg8ghL7fIpsYH/QF8lxMUeTy+8f84lWWYbMAMWynVQPQAM+Q+4lpD71ttK3x85oLj0wm4d8EZI4Lkqn1PCHzBCQBDfoHBn5MXR0Vywxp8CKlRVhM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=juT9LteR DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA9DE4BA2E08 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 65JEMAPU172880 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jun 2026 10:22:15 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 65JEMAPU172880 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1781878935; bh=zQbhobV+VfPoNHbD3Pe0kxecqpu12AbG1CrLg5CK5wk=; h=Date:Subject:To:From:In-Reply-To:From; b=juT9LteR81dkZOwy92Jy5OajMPrHmvPU9sc30j0EIOiS+Z0XeRfwtX4HLMGf21oQP y4+6tk8093LD8+ml0yBSAm1c4LUoOPpfCHjtNXcjS4g3VihTTobT9uBRlTNaiH2pb9 THYkpzYPDSd44110mLOTYXpA8M0GjS5FLPowgHxMVuohReIZoKUTk5tYRoF4qK7v8T 8iVk6jrLUFfXVKNEPfwnx7H5GhP/k9mlj4VEEuJU0ZFG1uarGMiigJajtkka03CdIl jjqqiW2bCAf1uLaMy+zGoChrKRSgbCougKk76YtxvqrUCGSh2PT12YoK/ilA6E8tfI JDoYAAhBZgWiA== Received: by simark.ca (Postfix) id 699571E024; Fri, 19 Jun 2026 10:22:09 -0400 (EDT) Message-ID: <7e778a1e-fd07-4270-955a-82f2b239e626@polymtl.ca> Date: Fri, 19 Jun 2026 10:22:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: make symtab::compunit return a reference To: Tom de Vries , gdb-patches@sourceware.org References: <20260618183928.3921440-1-simon.marchi@polymtl.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 19 Jun 2026 14:22:10 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-06-19 08:16, Tom de Vries wrote: > On 6/18/26 8:39 PM, simon.marchi@polymtl.ca wrote: >> From: Simon Marchi >> >> The compunit symtab backlink of a symtab is never null (the constructor >> asserts it), so make symtab::compunit return a reference instead of a >> pointer, and have the symtab constructor take the compunit_symtab as a >> reference too. Update all callers accordingly. >> >> This came up earlier in review, where a caller would check the result of >> `symtab->compunit ()` for nullptr, and I pointed out that it was >> unnecessary. Returning a reference makes this clear. >> > > Hi Simon, > > Looks reasonable to me. > > Reviewed-By: Tom de Vries Thanks, pushed. Simon