From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cP78I+K6emIWfwUAWB0awg (envelope-from ) for ; Tue, 10 May 2022 15:20:02 -0400 Received: by simark.ca (Postfix, from userid 112) id 836F91E21F; Tue, 10 May 2022 15:20:02 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=iw8r2U9F; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEE761E143 for ; Tue, 10 May 2022 15:20:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 583D6385734F for ; Tue, 10 May 2022 19:20:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 583D6385734F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652210401; bh=c6oc+v8tg+8CZArCQsGchhFdorn0Bt5r7LbhV1lFLO0=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iw8r2U9Fe4932pxXdR+QXUwVI1bQXgN2spChWZ4mU797zAx+BfI050EvofmAn+CMI a94wbBGQtPlxmQctwJ/kA8gMfgyX1iGGKf+K7zFi0DA3HXWGV5aRrop4zIfsdDlPvy GCSpX5dPkscypz5U8q+K8lH3V5/XLjUxHoHo3FfQ= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 8433038425B5 for ; Tue, 10 May 2022 19:19:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8433038425B5 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24AIlKHL027487; Tue, 10 May 2022 19:19:39 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fywmvrmc9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 19:19:39 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24AJGSa6006482; Tue, 10 May 2022 19:19:38 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fywmvrmbt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 19:19:38 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24AJ9iMq008032; Tue, 10 May 2022 19:19:37 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04wdc.us.ibm.com with ESMTP id 3fwgd9q6c9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 19:19:37 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24AJJa5I22544734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 May 2022 19:19:36 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A3EA86A066; Tue, 10 May 2022 19:19:36 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 374356A064; Tue, 10 May 2022 19:19:36 +0000 (GMT) Received: from lexx (unknown [9.160.59.210]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 10 May 2022 19:19:36 +0000 (GMT) Message-ID: <7e66a2a5bc481204623153b0a22b8bbec2b88225.camel@vnet.ibm.com> Subject: Re: [PATCH][PATCH] Update syscalls/{ppc64,ppc}-linux.xml To: Kevin Buettner , Tom de Vries Date: Tue, 10 May 2022 14:19:35 -0500 In-Reply-To: <20220510110243.74851f92@f35-zws-1> References: <20220509154832.GA22531@delia> <20220510110243.74851f92@f35-zws-1> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TG-t9F3-qDe9EvG90CR7iKIIx8VZdnFE X-Proofpoint-ORIG-GUID: C3DnB_nLHbyl-4xLWokopRaX1nuvSW0S Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-10_06,2022-05-10_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 clxscore=1011 impostorscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205100081 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: will schmidt via Gdb-patches Reply-To: will schmidt Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 2022-05-10 at 11:02 -0700, Kevin Buettner via Gdb-patches wrote: > On Tue, 10 May 2022 11:01:27 +0200 > Tom de Vries wrote: > > > On 5/9/22 17:48, Tom de Vries wrote: > > > Hi, > > > > > > Regenerate syscalls/{ppc64,ppc}-linux.xml on a system with 5.14 > > > kernel. > > > > > > Note btw that it does not only add, but also renumbers, f.i.: > > > ... > > > - > > > + > > > ... > > > > > > Currently testing. > > > > > > > Here's a v2, with a gdb.base/catch-syscall.exp test-case fix > > included. > > > > Testing on ppc64le revealed: > > ... > > (gdb) catch syscall 286^M > > Catchpoint 2 (syscall 'openat' [286])^M > > (gdb) FAIL: gdb.base/catch-syscall.exp: multiple targets: insert > > catch > > syscall on syscall 286\ > > -- unlinkat on powerpc:common64 > > ... > > > > FWIW, I've wrote a patch that exposes the same problem on x86_64- > > linux ( > > https://sourceware.org/pipermail/gdb-patches/2022-May/188881.html > > ). > > > > Any comments? > > I don't have a problem with your patch, which (mostly) updates system > call > numbers. Agree. :-) I'm hoping Carl will still chime in here. He committed a change last year to add support for a couple of the syscalls ( commit 38c90362460000bac2efdbf06250821429777bb0 ). That did not touch the xml files at all, but would be good to have him confirm the changes in the numbers is consistent with what he saw at the time. > > What I am wondering about is how often they change? Also, what > happens > when a GDB with some set of syscall numbers is used with a kernel > which > uses different numbers? (Nothing good, I'd guess.) I'm just > wondering > if there's a better way to do things... I agree with the sentiment. I expect the syscall numbers to rarely/never change. A quick glance at the history of the syscall xmls suggests to me that the xml files were added in 2009, and underwent a regeneration in 2016, which looks like it may have been limited to just added the group="foo" entries to the xml. It could be this refresh is getting GDB caught up with 13 or so years of kernel changes and additions. > > Kevin >