Re: [PATCH 17/24] gdb: add gdbarch_pseudo_register_write that takes a frame

[Simon Marchi <simon.marchi@polymtl.ca>]

On 11/14/23 07:20, Andrew Burgess wrote:
>> @@ -4080,6 +4096,27 @@ pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num,
>>    return pseudo_reg_val;
>>  }
>>  
>> +void
>> +pseudo_to_concat_raw (frame_info_ptr next_frame,
>> +		      gdb::array_view<const gdb_byte> pseudo_buf,
>> +		      int raw_reg_1_num, int raw_reg_2_num)
> 
> This function, and its overload are missing a /* See value.h.  */ comment.

Thanks, fixed.

>> @@ -1670,10 +1677,25 @@ value *pseudo_from_raw_part (frame_info_ptr next_frame, int pseudo_reg_num,
>>  value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num,
>>  			       int raw_reg_1_num, int raw_reg_2_num);
>>  
>> +/* Write PSEUDO_BUF, the contents of a pseudo register, to the two raw registers
>> +   RAW_REG_1_NUM and RAW_REG_2_NUM.  */
>> +
>> +void pseudo_to_concat_raw (frame_info_ptr this_frame,
>> +			   gdb::array_view<const gdb_byte> pseudo_buf,
>> +			   int raw_reg_1_num, int raw_reg_2_num);
>> +
>>  /* Same as the above, but with three raw registers.  */
>>  
>>  value *pseudo_from_concat_raw (frame_info_ptr next_frame, int pseudo_reg_num,
>>  			       int raw_reg_1_num, int raw_reg_2_num,
>>  			       int raw_reg_3_num);
>>  
>> +/* Write PSEUDO_BUF, the contents of a pseudo register, to the tthreewo raw
>> +   registers RAW_REG_1_NUM, RAW_REG_2_NUM and RAW_REG_3_NUM.  */
> 
> typo s/tthreewo/three/.

Fixed, thanks,

Simon