From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YTMCJCJyA2mq7xEAWB0awg (envelope-from ) for ; Thu, 30 Oct 2025 10:11:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 8FCD51E0BC; Thu, 30 Oct 2025 10:11:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 306691E04C for ; Thu, 30 Oct 2025 10:11:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF4D53858D32 for ; Thu, 30 Oct 2025 14:11:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF4D53858D32 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 4FE683858C54 for ; Thu, 30 Oct 2025 14:11:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FE683858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FE683858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761833474; cv=none; b=HWICF0ezPc2Dw8kqWTukBWOV8cWBI2ZCljeoRrAl9HSSJv2Rtai9qV8paCbnPUbILnLBm2pW2qkshHaby0E9seYF7/+UZVzYOezBvNQDZgU7xoqTNQBI5551L/KKXzIpkddy1WeznkeJInH5y2SD6yuqVJA2+b+NjHeY7uWktws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761833474; c=relaxed/simple; bh=XkbuVFBh+7P7Ihq2XwVs4EBr4VS46j+dGnHjsZjJ7/g=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=EGE6KrjkwME7AOu4I2wdUz4iOf1rXfEnp3go82S7LCHhaHNUx0CRMlwUx4ibYPFVxD1d8wnZkPu1X6AHWfr9UZ2i9sfhQ2gDw2LGqvZaWSL2OMTV/2OToi3vnV+8g0sdDBIiAtQeRu/bXPcsKpAIzydzm0zcwq8sTJ7SKWuKbtE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FE683858C54 Received: from loongson.cn (unknown [36.44.122.148]) by gateway (Coremail) with SMTP id _____8AxidH_cQNp9Z4cAA--.62358S3; Thu, 30 Oct 2025 22:11:11 +0800 (CST) Received: from [192.168.0.111] (unknown [36.44.122.148]) by front1 (Coremail) with SMTP id qMiowJDxbMH8cQNpDcIdAQ--.44302S3; Thu, 30 Oct 2025 22:11:10 +0800 (CST) Message-ID: <7e43ceed-cd49-d880-3a3d-14818f00e8d5@loongson.cn> Date: Thu, 30 Oct 2025 22:11:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH V2] gdb/testsuite: Add LoongArch case in my-syscalls.S Content-Language: en-US From: Tiezhu Yang To: Zewei Yang , gdb-patches@sourceware.org References: <20251023012922.1216883-1-yangzewei@loongson.cn> <20251023014549.1219570-1-yangzewei@loongson.cn> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: qMiowJDxbMH8cQNpDcIdAQ--.44302S3 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7WF43AF1ftr4kKFyfuw4rZwc_yoW8uF43pF 18Aa15Kry8Xr18JwnFqryjqa4rJr18t3s8Xr18tF15Cr15Jr1Yqr1UWFWjgw17JrWxKr4j qr18Jry3ZFyUXFgCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67 vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr 1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1wL05UU UUU== X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/24/25 10:44, Tiezhu Yang wrote: > On 2025/10/23 上午9:45, Zewei Yang wrote: >> This patch adds syscall wrappers for LoongArch64 to >> gdb/testsuite/lib/my-syscalls.S. >> >> - Implements the missing `__loongarch64` section. >> - Uses `li.w` to load the syscall number into `$a7`. >> - Triggers system calls via `syscall 0`. >> - Returns to the caller using `ret`. >> >> This change fixes build errors when running >> `gdb.threads/step-over-thread-exit-while-stop-all-threads.exp` >> on LoongArch64 targets caused by the absence of the LoongArch-specific >> syscall wrappers in `my-syscalls.S`. >> >> Tested on: loongarch64-unknown-linux-gnu >> Result: expected testcases passed. >> >> Signed-off-by: Zewei Yang >> --- >>   gdb/testsuite/lib/my-syscalls.S | 12 ++++++++++++ >>   1 file changed, 12 insertions(+) >> >> diff --git a/gdb/testsuite/lib/my-syscalls.S >> b/gdb/testsuite/lib/my-syscalls.S >> index c514b32d..3e2e397d 100644 >> --- a/gdb/testsuite/lib/my-syscalls.S >> +++ b/gdb/testsuite/lib/my-syscalls.S >> @@ -63,6 +63,18 @@ NAME:                ;\ >>   NAME ## _syscall:        ;\ >>       svc #0 >> +#elif defined(__loongarch64) >> + >> +/* LoongArch 64-bit syscall wrapper */ >> +#define SYSCALL(NAME, NR)       \ >> +.global NAME                    ;\ >> +NAME:                           ;\ >> +        li.w     $a7, NR        ;\ >> +        /* syscall number */ \ >> +NAME ## _syscall:               ;\ >> +        syscall 0                       ;\ >> +        ret >> + >>   #else >>   # error "Unsupported architecture" >>   #endif > > Looks good to me in general, if there are no more comments or > objections, I will adjust the commit message and code format, > then push this patch in the next week, because it is related > with LoongArch and no side effect for the other archs. Pushed. Thanks, Tiezhu