From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AYPbKkIxVmOG/A8AWB0awg (envelope-from ) for ; Mon, 24 Oct 2022 02:31:30 -0400 Received: by simark.ca (Postfix, from userid 112) id A08921E112; Mon, 24 Oct 2022 02:31:30 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=R044jxY9; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4A8861E0CB for ; Mon, 24 Oct 2022 02:31:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3BDC0385734B for ; Mon, 24 Oct 2022 06:31:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BDC0385734B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666593089; bh=1e1Zs3tSWB/u/cJb32/K6O0h+ZAOWFJFN9ViXi+Rpbc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=R044jxY95gTDSUDpPm+zaYCPdd+f2xFdSEzm4iaOHUtI1EDQaM4T3AdKsXHaVFFOG VyqxK8sdb1oArIuHFTw5dRb8Ed2OyRnjHIFHsAAwNkk2MdUqTwJ/vYFhe8dVVaJwiW AiX69OajqG6/UNWI86GGlbfX+6aajpCxdTlfuA1c= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 5BC5F38582A8 for ; Mon, 24 Oct 2022 06:31:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BC5F38582A8 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 8575C300089; Mon, 24 Oct 2022 06:31:06 +0000 (UTC) Message-ID: <7e383f23-1568-2129-d717-2b7fc45f860b@irq.a4lg.com> Date: Mon, 24 Oct 2022 15:31:03 +0900 Mime-Version: 1.0 Subject: Re: [RESEND PATCH 0/1] sim/testsuite: Trim extra path from arch To: Mike Frysinger , gdb-patches@sourceware.org References: <28df7073ec5a8f601ba47c9d2f7d4a7a0ce08753.1657795051.git.research_trasio@irq.a4lg.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022/10/24 4:16, Mike Frysinger wrote: > On 27 Aug 2022 01:53, Tsukasa OI wrote: >> The patch is a RESEND of >> >> but to the right mailing list and completely new cover letter. > > please clean up the patch and send it out standalone -- no need for a cover > letter, and the relevant details should all be in the patch itself. Sorry, I should have at least enhanced the commit message (I would have attached a separate cover letter for information not relevant to the change itself). > >> 1. Configure Binutils with aarch64-unknown-elf and build it >> /src/binutils/configure \ >> --target=aarch64-unknown-elf \ >> --prefix=/opt/cross/aarch64-unknown-elf \ >> --enable-multilib >> && make >> 2. Run `make check-sim' and confirmed that the simulator tests "pass" >> 3. Intentionally try to fail the test by modifying >> `sim/testsuite/aarch64/pass.s' >> (replace the last line from "pass" to "fail") >> 4. Run `make check-sim' and "confirmed" that the simulator tests "pass" > > since i don't have the same paths as you, i didn't run the same configure. > but using --target=aarch64-elf and running `make check-sim` with -j1 vs -j4 > doesn't show any behavior difference. all the tests are found & run. if i > add an error to one of the tests like you did, it fails in both modes. > > $ runtest --version > DejaGnu version 1.6.3 > Expect version 5.45.4 > Tcl version 8.6 > >> However, this block doesn't work because the `arch' variable returned by >> the `sim_arch' function is "./aarch64". That is supposed to be "aarch64". > > i don't mind fixing sim_arch, but this really should be fixed too. we > shouldn't be in a situation where "./aarch64" is present as an input. > > seems easy enough to do so i pushed a patch for it. > -mike That worked perfectly! I'll withdraw this patchset and close the bug report. Thanks, Tsukasa