From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6X8QK3gPNWAvegAAWB0awg (envelope-from ) for ; Tue, 23 Feb 2021 09:21:44 -0500 Received: by simark.ca (Postfix, from userid 112) id A20B51EF78; Tue, 23 Feb 2021 09:21:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CF5011E54D for ; Tue, 23 Feb 2021 09:21:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C68C386F027; Tue, 23 Feb 2021 14:21:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C68C386F027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1614090100; bh=uvK7rqWuLC72g1DUSI94JAaGVuD57vM7id4CzaipWNY=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BmeQTUHKx0IspHYwOMEm2giCHCI0zVzOqir80Np9PubisSQRX1uUPIRlt5yZS5D9o R/l5OKFKBdGdCCpc1Es70eti2qkH/WcBSS8HELtCBnF/DbnPnBkr80fW6RaQ0ubLs4 Hwi1wpHoKGd2KFCcqs9CBmrVeieS8CT4KmOpAS+E= Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700080.outbound.protection.outlook.com [40.107.70.80]) by sourceware.org (Postfix) with ESMTPS id 128C5386F027 for ; Tue, 23 Feb 2021 14:21:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 128C5386F027 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVuvK723QByVePVAd+/zWzC9wo2vN0zV7KL3DXmLSlIYk0RPUWcK1ZnacHVtwu54YJdoufgDK5/zt2u/D6Vx4NjC2FVKuytTzFWkGrN1scKkC9lGEtjX40qXRXe6G0iH0YsJQJt4DeJ+yOtpI6iRg39gE2hWxvRvcqi7sfvJ1QY1J4EoiEeZ8An5p47lzP6H2fPga//GMv0Ita6EtVVaoJVKF1w0LvgC2b/DpIeSSyVqk8S1Cz80bUWjlV8FFt1APGWt3vptMsSp2SBSjqZPcNr6OZq8C8Vixq4sPaMRTWGcDybCO/ZNnFQiFxAz8RsUE1QMVVdLkDiDOD+zU+efYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvK7rqWuLC72g1DUSI94JAaGVuD57vM7id4CzaipWNY=; b=iWDY3grU6V9tNSu+A9Fj2PANKQ/uZGpxMPs0m81P1Y96YoFsh/COxqHhdE4VxGs0d/iLzY5kjPuSI1Xwl0r9V3g9PDU25nQ5/e84WK5gxQODDLRvPJAec90WV3J+CY7q8MxQmnkLmiemeiP6uP78tcoO52Kzr6CrB+hEBubIOB+/5GPfKA07nFH2DQj8UJ/YKrPOBpMs2ZWQ5KCrT1PP4XbmtDElyet893jcGdpC45jZJ+tkomZ1CgBaqot5vcoGaIU1D5K30JhDkEgYgbJH13gkY4bArO/bW7hZVP0lNCENhMdvwaQUh93Uxf3HPZPj5X6Q5pEuplhDFD9hvyevvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB3194.namprd12.prod.outlook.com (2603:10b6:5:184::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.33; Tue, 23 Feb 2021 14:21:35 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3868.033; Tue, 23 Feb 2021 14:21:35 +0000 Subject: Re: [PATCH 04/30] Move compilation unit info to dwarf_expr_context To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-5-Zoran.Zaric@amd.com> <87y2gmq8rx.fsf@tromey.com> Message-ID: <7e14e337-4c15-acca-6eff-5c414dc22e1b@amd.com> Date: Tue, 23 Feb 2021 14:21:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87y2gmq8rx.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:3c68:1988:3c97:9289] X-ClientProxiedBy: LNXP265CA0084.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::24) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:3c68:1988:3c97:9289] (2a00:23c7:5a85:6801:3c68:1988:3c97:9289) by LNXP265CA0084.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.32 via Frontend Transport; Tue, 23 Feb 2021 14:21:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8a7d8d3c-4467-4436-914e-08d8d8065329 X-MS-TrafficTypeDiagnostic: DM6PR12MB3194: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RMZ+HhvvtzhsqNwQ++e36o9cTo4UHOiuk/TxkVqoaJReYXmKf7hnWHPOpd4v96eld0GaM4KstiTgD57e5AbfjRKsWhlqJS1qk7ZC5+UvrWXi/6d5nXXuW+tL9NNZvih49MFsNDwoNlk3F+k6cMq38nH0d5wmBgwogwSb+MAn7xovgYAqyiMxaFv+OACp7XoUBeCpjpbuSJymZptq31AEeV+e2gRVF+VSrNANhlZUE8/dYGyW3MO4eDIRssgDxaIYUZZoZPn4T0mQPPVR532NxXkhUlWaPFxlpgY+yql85RJS8bf7P8KvDSi2NmaG8ed+VbVn92TjDX6Yl4VjMsuF3WxCNhPB7uTKdU9MGQkolB/MdbQkXZ8iDAjFexygWcBJqgl9nG3AiDWRv1829Efd1qtXkT02qPbnGNxSS61h0Q3woaPJc9bB2fTQ8c5GZIRbJ+jI0wtvQK+u+7F5PFq74oOCg31sFXpBMLgxRCt3Smeo5KsYyA/yYYslohurm0FkZU+5FAtxiAvcEt/qre0l687sTMBuH+xBie/IqVQ3bQ34K6s2gajimcUabocU1r9hpQMYm+RWApLu1C1C5kZQl3U5JeI+2ABK6RN7m6m+xAQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(6486002)(86362001)(36756003)(110136005)(2616005)(478600001)(8676002)(2906002)(5660300002)(31686004)(6666004)(66476007)(52116002)(66946007)(8936002)(31696002)(316002)(66556008)(186003)(16526019)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?djJWM3FEc2docVpKWExWM3Jyd2xybXhWS283L3dhUTltRHVhZzhRa2FHcTZD?= =?utf-8?B?QkdPNkdzUWdTaXpYRUpmU1dRVFlIZDBtQXFEaW1kZzZtSDRXVnVSVHJhUERK?= =?utf-8?B?Z05NVWcyRGcwWFlHbjFvY0lNQnU0R2pBQXFkQUZLK0NKZUpSc3JGTnQ1Vk9X?= =?utf-8?B?cjhwS28wRFN5RUpxRFBkTGhJWUg3VWxsRXVudUlmTjJSSFB0b3BNSWhWa3h5?= =?utf-8?B?R1Fyb3RDa1Ardm9odldTUEZjSXF3SEVGdU5kQjhlMkg3TlJjRVVhcXhmR3p6?= =?utf-8?B?RWJDbllmeHNnNnlXdVJ4ZnBVN01EMkZMK2tmUDdmSEUydHphcnhyWDcyLzdz?= =?utf-8?B?ajE1OXdibGNpRXpCZXN1YjBaamtqbk1XZGRnRVF1L0JLSkoyeVdTdlZTWGQ0?= =?utf-8?B?T1Q2ckYzaW92U29zS2QrMG8vNTRpbjhWV214ZldSZXFnUG9ZRW5QN0dPVG5H?= =?utf-8?B?eUVtbDFwSGVta3pqMXRZcDhzSzVEeE5UaXdocmlGWEw3L1RLcENpZXQ4STVa?= =?utf-8?B?N1hrOHhWNjFlVmcwUU1WUGpycVJpMnIvaDVTVktKbkQ5L3ZlclpBcXQ5cHZH?= =?utf-8?B?K0lGUHlGUmRWR3ZNR0NSTUlUWkJ5TmlTUmVJNE90VjV4ckJiLytJcWZ2R0w0?= =?utf-8?B?SlpYelJ4dmZUbTFPQXdSZTE1SUg2NnpNM2hOczBoWnZJQWhRWGRXM0VPc0dh?= =?utf-8?B?bUFBdCtOaWlyMFZWaDEwdW8rQXFFWk9nbUtnT3hDK1dTVGVlMlllTW5xUmVZ?= =?utf-8?B?aU9hWWFMY0xyVThRNk9vOHRjODBHdU81NlJUY0ZiY2V0bGNCZFBVcmk2Z2FZ?= =?utf-8?B?RU5QVlJtMnl5ejBwSkpWRFVrY2N5Q0JaY05uYmFJYU8vL3AxMmFZaWFDM083?= =?utf-8?B?ekUwRElud0dtdTZ5bXJqV0hVSWdiaUVYejJtYlBRM0UwaTVuVmZJYVh2R1k1?= =?utf-8?B?dDVOVlZoTlB0MkxiUzAvbHdaMFJibSt6a1c4VkYyeEVEbk9XTFBMdkIyNTFx?= =?utf-8?B?YTYwdmxpQUxsWmVEdmFrei91REJ2ZUtsMHo2aUZWRDZIOXdRcTdkL2ErWGdG?= =?utf-8?B?YkQrSGtVdFk2R3FUcktuYWJKb3RFT2hhZkpBN0MreDk0aUtkeXM4WlpTTnJ2?= =?utf-8?B?Z3UvdllwaGQrQVl4RHhNVHpNQVYrbDd4UzRZUGw4UC9ucyt4NWNjS1A2eFFW?= =?utf-8?B?VjA5NWJpWEwzQm1maXVucEtZQkExTE03bFZiZ0NMR29UWk50QS9aZEF5aUp5?= =?utf-8?B?OUFTOGNCZTNpK25yTlk5TkZLMU01OVBRYlppMnM0K1pLditzbHdLMHhoaG9Z?= =?utf-8?B?L1NYWTNKTjBsbThpMGI3Z0cyMXJITW16NnZacEg3akVwcGJ2bWNvUnJTVzA2?= =?utf-8?B?ZDRUaDhIM3AxRkc2cnFlWDAvZUJpM0xLZ0VDRlAxVjJrNVRLNHdEa0Q1NTNT?= =?utf-8?B?UjNlWnBmTzFIb29pVm5URWpySFNlOU0wSEdkZXFTR0c2bkhEVkx2VStiR1Zx?= =?utf-8?B?Z0VtRWJGTjRzODBQUUhoRGRzcjladktrUk1hdDc1T1lic0E5N3lHOUx0QzNQ?= =?utf-8?B?dTNrNVUvMGJ3SFNRVkliR3NtcGF1Q2Y1dDFpcDhOZDVnUkE5Z0NtMHYxOE9q?= =?utf-8?B?MnFkTUxjVVhRNSs4OHRKdnc5aWtuMTRBZ1pTQnM1TUtDdER3L3h0MnhxZWtr?= =?utf-8?B?cDNOWXBFSnlaa0M5ZXdSWEFIVnpDbVpoeUFnVXBibFQxa3haZTVZN3RWa1N4?= =?utf-8?B?OFBEakVVZWhmaEtVMW44ZmNSVnF5dURwTWdiTzFUUm9GVmJHc3VYbkVMYnQ2?= =?utf-8?B?VjNDYVZGeHpIaDVFUGdqMjNPVW1wZnBxdmU4MUo2VER2N1JlU2Z1aUNWNStQ?= =?utf-8?Q?egufCyNnA7x+L?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7d8d3c-4467-4436-914e-08d8d8065329 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2021 14:21:35.1990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rix/z9Pn80sDYPlPYmohanEzoy0H5w2Az5Vh5cZZKdaU5KbhiV0uAFwxXzPZMwbvLMvYRLNcPN5bidBbjNkBZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3194 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > > Zoran> +/* Ensure that a PER_CU is defined and throw an exception otherwise. */ > Zoran> + > Zoran> +static void > Zoran> +ensure_have_per_cu (struct dwarf2_per_cu_data *per_cu, const char* op_name) > Zoran> +{ > Zoran> + if (per_cu == nullptr) > Zoran> + throw_error (GENERIC_ERROR, > Zoran> + _("%s evaluation requires a compilation unit."), op_name); > > One thing I didn't think to ask about in an earlier patch is -- why > throw_error with GENERIC_ERROR here? Unless there's a specific reason, > in gdb it's normal to use plain 'error' instead. > > Other than that, this seems fine. > > Tom > Hi Tom, In the new patch series I will be using the NOT_AVAILABLE_ERROR exception because the evaluator client needs to distinguish the regular error and the missing context error case so that the new symbol needs evaluator replacement can behave the same as before. I couldn't find a more appropriate existing error then the NOT_AVAILABLE_ERROR which kinda fits the purpose, but maybe I should define a new CONTEXT_MISSING_ERROR or something. What do you think? Zoran