From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RrU6DVWezGBNSwAAWB0awg (envelope-from ) for ; Fri, 18 Jun 2021 09:23:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 223821F163; Fri, 18 Jun 2021 09:23:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 48EB71E813 for ; Fri, 18 Jun 2021 09:23:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BD143AA902C for ; Fri, 18 Jun 2021 13:23:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BD143AA902C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624022607; bh=x1HiILh//3txFpi75DYPA+N+53wAnAc4ctYCmxMkpgo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sVh0lMqxsdpXNtvz2lPAQkMRllKpL+sp1XbZ+iqjiK7qTIi2ARhx1rH3V2m0aPwtc wGt0ezfCAHEp6KHaJFbJT++o4p2fEIjochjDOPgccr4W4AMnd5R/yjkbKdQZNdEP/6 67r1jElXaIOmFEWbHEKiXmw19udMEP/Rp/0i+KsY= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8EEB03860C32 for ; Fri, 18 Jun 2021 13:23:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8EEB03860C32 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15IDN00P025861 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 18 Jun 2021 09:23:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15IDN00P025861 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1F7151E813 for ; Fri, 18 Jun 2021 09:23:00 -0400 (EDT) Subject: Re: [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS To: gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <33565c24-0468-1ded-63db-d7ef402d5329@polymtl.ca> <5ece9821-45a3-14f6-33a1-3506b6efe72f@polymtl.ca> Message-ID: <7e003119-2201-0a77-423e-129565455619@polymtl.ca> Date: Fri, 18 Jun 2021 09:22:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Jun 2021 13:23:00 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > oof, i agree, that smells like an aclocal bug. i'm not sure i'd call it benign > when it's indistinguishable from actual missing macros. for example: > $ echo AM_FOO >> configure.ac > $ aclocal > configure.ac:121: warning: macro 'AM_FOO' not found in library > $ echo $? > 0 The aclocal warning is indistinguishable between a valid and an invalid macro. But if the macro is valid, it will successfully get replaced by autoconf and we will get the expected result in the configure file. That's why I called it benign. If the macro doesn't exist (like AM_FOO), of course it won't get replaced, and AM_FOO will appear literally in the configure file. But then the configure file will just be obviously broken. > > i think autoconf might fail (i hope that's always the case), but it feels a > bit wrong for it to be disconnected as such. and hopefully people always > check the exit code of their tools ;). > >> I'd suggest still just doing the right thing and removing all the >> ../config/* includes, and just ignore the warnings. I'll try to open an >> automake bug or ask on the mailing list eventually. > > this seems to go against our -Werror approach to things. i also suspect > it'll trip up devs who waste time trying to figure out why there's this > warning (and surely it's their problem because no one else in the project > would allow this to creep in), which means a snowball effect for people. Hmm, right. > so all things considered, i think the explicit include to silence the > warning is the right trade-off. we can add some comments explaining > why they're there so that at least doesn't keep tripping us up. > > how about at the top of acinclude.m4: > dnl NB: When possible, try to avoid explicit includes of ../config/ files. > dnl They're normally found by aclocal automatically and recorded in aclocal.m4. > dnl However, some are kept here explicitly to silence harmless warnings from > dnl aclocal when it finds AM_xxx macros via local search paths instead of > dnl system search paths. > -mike That LGTM. Simon