From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126687 invoked by alias); 3 Jul 2018 13:54:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126677 invoked by uid 89); 3 Jul 2018 13:54:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1433, spots X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jul 2018 13:54:33 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFF1F40255C9; Tue, 3 Jul 2018 13:54:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B97402026D76; Tue, 3 Jul 2018 13:54:30 +0000 (UTC) Subject: Re: [RFA 00/10] Remove standalone ptid functions To: Tom Tromey References: <20180613215049.9691-1-tom@tromey.com> <20180613232228.GA2166@adacore.com> <49903166aff66528df83fbda26001be8@polymtl.ca> <64e82c8f-9647-2fb9-62f7-0b31660a41c6@redhat.com> <87bmcde5nq.fsf@tromey.com> <87sh51of6q.fsf@tromey.com> Cc: Simon Marchi , Joel Brobecker , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <7deff07f-0058-7fd1-2357-4d7317f5f40c@redhat.com> Date: Tue, 03 Jul 2018 13:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87sh51of6q.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00045.txt.bz2 On 07/02/2018 04:00 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > >>>>>> "Pedro" == Pedro Alves writes: > Pedro> I'm just not so sure about eliminating pid_to_ptid. I'd ran into uses > Pedro> of that where I had second thoughts on whether replacing it with > Pedro> a ptid_t ctor call is really a good idea. What I thought was, > Pedro> that when you're reading the code, a pid_to_ptid call more clearly shows > Pedro> that want to build a process-wide (sometimes a filter) ptid as opposed > Pedro> to a single thread ptid. It also helps with grepping, if you'd like > Pedro> to find such spots. But it's not a big deal, and I can certainly live > Pedro> with it. > > Tom> It's easy enough to drop it out of the series if you would prefer that, > Tom> or to rename it to something like ptid_t::from_pid. Let me know. > > Hi Pedro. This series is still pending since I was waiting for a reply > to this. Sorry, I kept wanting to take a better look, and ended up putting it off for too long. I looked around the code a little better now, and I'm now thinking that we won't lose as much as I expected -- most of a spots end up being clear from context. As for grepping, it's not as convenient, but we can still find most spots with "ptid_t ([^,]*)" or some such I guess. So OK with me as is. Sorry for the delay. Thanks, Pedro Alves