From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69440 invoked by alias); 14 Nov 2017 22:41:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69428 invoked by uid 89); 14 Nov 2017 22:41:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=Siemens, regularly, Hx-languages-length:1413, Hard X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 22:41:25 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id B7.ED.19528.2117B0A5; Tue, 14 Nov 2017 23:41:22 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 14 Nov 2017 23:41:21 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.14] (192.75.88.130) by AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.239.4; Tue, 14 Nov 2017 22:41:20 +0000 Subject: Re: [PATCH] Assertion 'xfered>0' in target.c for remote connection To: Paul Carroll , Sergio Durigan Junior CC: "gdb-patches@sourceware.org" References: <1155839491.1748621.1509663923992.ref@mail.yahoo.com> <1155839491.1748621.1509663923992@mail.yahoo.com> <87lgjo6oqi.fsf@redhat.com> <9030ce55-663c-bfac-7586-dd1934190815@ericsson.com> <44698d0e-9426-7f48-8226-aa4eec0462b1@codesourcery.com> From: Simon Marchi Message-ID: <7dd983d7-1b7b-2af1-2935-b4a51cf97627@ericsson.com> Date: Tue, 14 Nov 2017 22:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <44698d0e-9426-7f48-8226-aa4eec0462b1@codesourcery.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR08CA0054.namprd08.prod.outlook.com (2603:10b6:404:b9::16) To AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3571fb21-01f1-4c1b-1f05-08d52bb0d3b3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:AM3PR07MB308; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;3:E9XBqTZ0+x1HHx7V88g+lz5TWvnVyY9/qOrZHyf+ynju5Qplg8y7MDkyYRa/NmDOj7mwJpldIq8tCmUihqUymx4k0A8PQYp3twkkWa2CKDxknmxnIAOnybugiWWkuYJdXgOP5zEIDevAC1dTuDyxlLvwmr5lR0cp5pEu/5OGz8qhZJeGucL+6GTfDPBug2zZrQQxgtr1bu5PpdfsRYTFbYyHjlOr/OBR9hVNo99nEwqJjA8ZpKA4NprX/zaHzStM;25:ftRy7wn/wgduIITHH91QY3ScWQwPvtzG6ytWHBrhiDR9qpWGm00LLacA5FCHKRN62X+KeWkBn2wwoQkIhlza+gRCJuF04XVaOBWtJhThcnEWZghvul9HVg+45G9jn06PWQSPsHP+6whoOQTf4Ge3nxxi2iUk1OpIocZDg+yrmRchtGcxVZWAsTcloqzGEgx43IrIcitTCLGfp+MbUn4MXnuM9+LqrgkS+MW9++J2/5naT9D3MsTzTFisCY5E7OPEwLWNMXKwLeB8y3XwGGzP9sW3aOBza3trZoGVnhygGSh12kiDC4x5H4/gApB0E+hhO03ag2oYK7AouOMmoJDXNP0U/AaljhdwGtUtXJe9bvs=;31:vj2bWyGe4DiCF5BnQYmMi4LF164wbIMVDf97v1ntSzoCAWvBlzFd35C8Fh6JgA+V9+Fu+QZxsJ5gu95evWddVHvh5B0oY5ECSSkfseimE+8zH/q9joSTuYDaAhjf6NAKzSQMM+6JFn8QtiDRPmnOhe2b22yBNPANp033FDDh6sRFKFFTi813BPrXAbRdUiR+B/JZcpAfpALrN8kWA8TJQvP9sg0gZmunh5rKHwP1Hoo= X-MS-TrafficTypeDiagnostic: AM3PR07MB308: X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;20:ndMPnQLEsm/mekMzDOU5GztqXApcZY9quKi1MpEArOTwxkk2wmPBV/4iuh38RetHSNGdGGruIDT42DM3mp6nVAkiOz9cxbZCJ64YQ6upuaAxOGdjPybuVBRPZJT5aOD1LW32UaOhLgAGO/ZLc8BIAqa59fDPRjofpjnUgiwSihJBpssPoKBm41zR4NAgmWBct/mfP2lY8mefYbGEYdBhd2vJ08B/99LX2Vkm3rrsShobEMIC/qPI5ODu+Qet10tMUcWX8GIemwcn0oWcE6Kcp4rdvkZaiC7L12SOO9L3HTEDpyi4diekmTZSGeL9kPQ4C6/sl3gExWgaPavHif0phXXx0edOR3RZL23OoJFSrJvnvYU3psUVxl2z0NHVd3EJdMlnH3F5+Yb+c6Dm1v4fhq+b65D5alNay3E5AD2cY1kulzHFi9rOmSVKHyCOSwFU0OGuA2QYnZ8VCHtyj/McThBOEOyRgCdUcYtVhdi/MBLWUURbDuPF1v8BaiBDLRpI;4:50HBJUpX00nnQ8Ay2I7cFlKPY/pkMDBEpuJHlbRqAf49+v+flJJKWKnlA856lX0XlZRQin99CxQqLh8buy2ouKoe4L2owfQYBrfO8qb0IsR7QV889DGcPMM4OuKDykvMBaeBN/v9TZ3QAph+/SQsgNARl6WVXlLBHGakQUj/jpYthcJX/ggbNLoW5g3WvWNFtqGdJKhC6HiteDa4Ll2yNbvv52cize0Ok5aDMVbrhsPynIjhcwcWvIW2IhgbAGGZgqObE7fcMYqZz9N7TeEx8DRZsn62Q2Qfz78BwJrdVru36yZNd7iRBpGzSgn1esgjlBk+h5vCKr4fKPieY1NeRtZRDdJmwodz12NmTmYLvQ8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863)(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3231022)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR07MB308;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR07MB308; X-Forefront-PRVS: 04916EA04C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(346002)(376002)(189002)(377424004)(24454002)(199003)(43784003)(31696002)(110136005)(6116002)(4001150100001)(33646002)(3846002)(2906002)(6666003)(65806001)(65956001)(66066001)(189998001)(47776003)(6306002)(58126008)(16526018)(8936002)(2950100002)(25786009)(81166006)(229853002)(86362001)(53936002)(68736007)(36756003)(8676002)(478600001)(93886005)(81156014)(49976008)(23676003)(65826007)(2870700001)(97736004)(7736002)(50466002)(76176999)(50986999)(54356999)(106356001)(101416001)(966005)(31686004)(83506002)(316002)(16576012)(53546010)(64126003)(305945005)(105586002)(5660300001)(6486002)(4326008)(6246003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB308;H:[142.133.60.14];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA3TUIzMDg7MjM6QklSL2pveHRTczNTK3NiSG83L3lwVitoSHND?= =?utf-8?B?R2RzL3V4cS9xNWtnRjRJZnlUYVB2NGR1TWEwWW85RHZMS1MzTDFtK2g3b0JR?= =?utf-8?B?eFQwaVBrcHNlU2Yyams4ckRWMVVyMERrNVdSMFNTZFJNNWIyT1FmU083ZmdV?= =?utf-8?B?cnlpeHUrVkpQbmhWbHBHbzVnOUc0bWxsTC84QVZ0bTlwZnNjUnVaV00zcHhG?= =?utf-8?B?WU9RK01DTW9GWVJkeFZtd0JycHBDb2c1clZtL0xnM2tEMWdCZ3hSVGl2dzgw?= =?utf-8?B?ekFPWHduV2tkUHc4anFuTTJrd1dDbTErRFRaMzRkVlpyRUkxdTZ3OWZsaUxW?= =?utf-8?B?T0VoSEM1bXZiakVmWmxsV0E5WmlTWFVOajFmcm9uajBhMzA2Z2JQdmZUT3hz?= =?utf-8?B?UGJBOGJUS2tDSHQrdUhUWDc2NC8rdkt0dHVuNU9TaVJFVnY1VWF0WkFodEk1?= =?utf-8?B?a1QrTFJpYjkzRmNtK2ZjdlhzY3FISkpUalhLRmZHM2xRY2swWXQ0S1huVEIr?= =?utf-8?B?dWNTUXVGNGZwZnkrSGt2dWxqQUdCKzArVFBuVFlDUWNjakpDcFk5NGd1alFU?= =?utf-8?B?YkZrSXgzL3ZCbTJQT0MvQWV1VWVpbjFXNGtaK01yV1ZSdlpLdTFWeHBzZDZD?= =?utf-8?B?bWRJa0U1LzhQcXZuRWphZXAvdTMvdFBYWkVrZGJ2cGdLa3g0cFZqYURyNFNq?= =?utf-8?B?bGh3NzBpQVM2OGtLM3NqN2pXelhCK1BMRWprRU53aGt2R01zc3g0dVN4WExJ?= =?utf-8?B?dVI2dXcwRGprME5BSm85dlo0Q3VRUm9BemQ2K1lQMnVMNElsMFdRQzBXdEh1?= =?utf-8?B?VWFWL0U4Sk9xNFI4NzkvZk56emlQYTJObEFDeUZZenNzd2NoY1JySWNaY2My?= =?utf-8?B?bUE1bjVOVmNqQW1kR0JLcWU4T3U3cVVRdmxXWXp6U00yVXYyZk9MRCt3REh2?= =?utf-8?B?NGdtR0VZRzFpSElNTjVJNFZrdXkxditUbzh4NXFXWmlDY3VjZzhnZXhlK2tN?= =?utf-8?B?dWFVN0dRc3JzUE5mSHk0dVlmWTUrQ1hFcTZSUXRkMkNYczVDR21PT1gwRTJx?= =?utf-8?B?R3hjS1V3bDh6SExZUVRnMEZiZ2MzZm53eXBMbGxlbXR1cWxMUmdvMENhbmtu?= =?utf-8?B?SGtDYWZ6djVRQ0FkTmFTMUlCZkVrUFhya2l3c1lLQXUreWxhQTlDUllKWTBY?= =?utf-8?B?WmdZVFlzNWFZMWVNSGU5ZUxpR3pXZlM4Wm4ybG93M3RqQ2VlY0MrQ0UzZ2pv?= =?utf-8?B?d0lWekhIbFVsOWVmdjlxaHlIMmJ4UTN1ditKWHFIMHlBcS96OTMzQnB5dEVu?= =?utf-8?B?QUF4ZGdBZSttVXRSamxIVnNBdTRTa01VOUZnWEtPM091S0cwOFppcjBLckVz?= =?utf-8?B?Smhlejk0WEdrZ2NwL2ZZTzk1bytHWEp4OWY2Umd6WmVIYzNtZWVUaS9zVVg5?= =?utf-8?B?cmhWZEF3b1pSL0c4dEZFZFNRV2xzMGRYL3hiWEgvOWZFc3pqcUNXU1JQOVFv?= =?utf-8?B?ejI0WVJxWHZPSTJXTStuSlpldTJkMklDR1J4NDNnc04xYWpaejJSUTI4c2Ft?= =?utf-8?B?SWtESVozemI3UTgzenhET3VhMGllblVQZGUzOHhneVE0VWZSMmYrK3RFSVR5?= =?utf-8?B?TjhSWEtYbUFtOFpJZUV4V3hUTnlkNFJuZWgrbTloeXllbk5qL0tMOXJnd1k4?= =?utf-8?B?a1M2cFVHV1FuMUtQYk1rMVpkLzZxbG9TOEZRTDJkR1I5YWY4MVViWnl5SHls?= =?utf-8?B?Nkg1N0w4NnE4ZDBzL2d6SUYzcUtNOXY1aXlhVFZDNUpQYzVsVk12M0FRYVF0?= =?utf-8?B?WlBIZGkxbk4vQjF3Qmt0TEVqdmEySG4wQS8yTjY3cTNvbDFobHFlcDlUbkU1?= =?utf-8?B?R280UlZtcWNYYzZGZDlENDU1TWRHS1FwSU5UekRnNFk3Z2ZEU3Mxclg0MktY?= =?utf-8?B?ci9KQlFtM0JLMTVLL2FSOWl5YVZEb212VjllMjR2NDJlL3pOZHY1cHAzNlkv?= =?utf-8?B?NlRvMitQOE9tNFZBNDhYRmVydHdrMWlJakp3Y3NoNTlkVzRxT2NycHR1SW5w?= =?utf-8?Q?NLI=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;6:XtSTOCvoWVAcD58rB2y2P5eH70B3veJAW0Ppkw27JQK7D3C+XcbrbLEVTz7EIz4mEfiZUaskxdnSzz3a2oBML+vkI6+tzFtTw0FroOrY8C3ofSkXRTwkVy+jiI9EfNexy+DfMLq8TsnGIOU2c3QQKN0jaBzSpEaIftQS3jxAMA5hOLsqm7iC/BKf8WGoDKrGHMnpa8YOODN0kH4dmOddvZZCvSZvc9S4equnmzKYpjFl2mH4zqo0UwsbLxVHJmecxEMCwiZVqMCo01+k7pWWKdtfMBnHfk5Y2JcbcpLrG64nF+SHp9JuuR0A5sxGB+Hr2duBIm/NhVxMCsnoVR+fnS99r0rxuUMKS6Um1io9e80=;5:Te2gTirUrFmm92VA2sKfeWRPmViIWFHp9Hr17VMAtlCYNw/+ivMYXVS7npLwOPdPzQ8PLfssndu7g3ptuXVUzuCFTgTAE5GTOil9u6eW63vV4WM8qftWy5npvczcONf61mPur4np9jtvJe4lsa9EEdpTsU1dy+wlvww7XNiVpXQ=;24:8mhPJI8nXoI9crj/ClAfzt8bObsCb+X0OX16/TfNjrGI6zSCcbvVYE3+d5LvdmIADkfajgo812WIaMwEcXsHQb8iDjTeE4JgYxSordtpyWg=;7:WixzfqQFpUQT3cCpm7HKH3QZYkY/6itKbpVz0go8DJyJcOZYnojHffthmLB450cJC4f4tn7m+mevpZLWKvELbeDtQy8n824rdWo9SSRBAQPLJmdhwm5AZzmWUSdgXo7NcI3k1JRbwUK0FmXjqjI0Zy1eDq7qGrHjkO1SizVAYMarDrTIDFGuV9V+XJrZe/w8VHXrCQLCk32a/4TLot2RQTEjbEnBnUs8gXtCQafgr6xcX5fY/Bsr7URVq1z/c0P5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2017 22:41:20.2825 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3571fb21-01f1-4c1b-1f05-08d52bb0d3b3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB308 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00261.txt.bz2 On 2017-11-14 05:30 PM, Paul Carroll wrote: > On 11/14/2017 4:38 PM, Simon Marchi wrote: >> On 2017-11-14 10:02 AM, Paul Carroll wrote: >>>>> We have a customer who is using a Corelis gdb server to connect to gdb. >>>>> Occasionally, the gdb server will send a 0-byte block of memory for a read. >>>>> When this happens, gdb gives an assertion from target.c: >>>>> >>>>> internal-error: target_xfer_partial: Assertion `*xfered_len > 0' failed. >>>>> >>>>> This problem is almost identical to that fixed in https://sourceware.org/ml/gdb-patches/2014-02/msg00636.html >>>>> >>>>> In this case, remote.c needs to be modified to return TARGET_XFER_EOF instead of TARGET_XFER_OK or TARGET_XFER_UNAVAILABLE when 0 bytes are transferred. >> The patch look good to me, given that all other implementations do this. >> It is small enough that it doesn't require a copyright assignment I think. >> I see you have contributed to binutils in the past.  Do you already have >> push access to the binutils-gdb repo?  If not we can push it for you, or >> we can get you an account if you plan on contributing regularly. >> > Please feel free to push the patch for me. > Hard to say how regularly I will be patching things. > The copyright assignment, as Yao noted, is covered by Mentor Graphics (and Siemens). It is pushed, thanks again for the patch. Simon