From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82103 invoked by alias); 29 May 2019 15:13:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81977 invoked by uid 89); 29 May 2019 15:13:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=silent, speak X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 15:13:08 +0000 Received: by mail-wr1-f68.google.com with SMTP id t4so2062734wrx.7 for ; Wed, 29 May 2019 08:13:08 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id o6sm3555827wmc.15.2019.05.29.08.13.04 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 08:13:05 -0700 (PDT) Subject: Re: [PATCH 20/24] Make "frame apply" support -OPT options To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190522205327.2568-1-palves@redhat.com> <20190522205327.2568-21-palves@redhat.com> <1558815166.1454.24.camel@skynet.be> From: Pedro Alves Message-ID: <7dbb69b0-ac98-eaa0-fb41-cbe2e2faa929@redhat.com> Date: Wed, 29 May 2019 15:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1558815166.1454.24.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00639.txt.bz2 On 5/25/19 9:12 PM, Philippe Waroquiers wrote: > Some typos in the test. > > On Wed, 2019-05-22 at 21:53 +0100, Pedro Alves wrote: >> @@ -3095,44 +32diff --git a/gdb/testsuite/gdb.base/options.exp b/gdb/testsuite/gdb.base/options.exp >> index a4bd686fe5f..df5d86c0ece 100644 >> --- a/gdb/testsuite/gdb.base/options.exp >> +++ b/gdb/testsuite/gdb.base/options.exp >> + # tfaas is silent on comand error by design. This procedure > comand -> command Thanks, fixed. > >> # Miscelaneous tests. > Miscelaneous -> Miscellaneous > (maybe the same one as before?) Yup. > >> proc_with_prefix test-misc {variant} { >> global all_options >> @@ -731,13 +807,28 @@ foreach_with_prefix cmd { >> test-enum $cmd >> } >> >> -# Run the print integration tests. >> -test-print "" >> +# Run the print integration tests, both as "standalone", and under >> +# "frame apply". The latter checks that the "frame apply ... COMMAND" >> +# commands recurse the completion machinery for COMMAND completion > Not very clear what commands (with s) we speak about here ... > I meant all of "frame apply COUNT|level|all", which are implemented as separate commands. I've changed it like this: # Run the print integration tests, both as "standalone", and under -# "frame apply". The latter checks that the "frame apply ... COMMAND" -# commands recurse the completion machinery for COMMAND completion -# correctly. +# "frame apply COUNT|all|level". The latter checks that the "frame +# apply COUNT|all|level COMMAND" commands recurse the completion +# machinery for COMMAND completion correctly. Thanks, Pedro Alves