From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id agcFENHWiGDPGAAAWB0awg (envelope-from ) for ; Tue, 27 Apr 2021 23:30:25 -0400 Received: by simark.ca (Postfix, from userid 112) id 348901F11C; Tue, 27 Apr 2021 23:30:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 879731E940 for ; Tue, 27 Apr 2021 23:30:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A2AB3A13CC5; Wed, 28 Apr 2021 03:30:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A2AB3A13CC5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619580624; bh=Lv0/H9pxTVQp4W8EnYZrclYOQjx3om4bG9jXnya2R6o=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=GhL9UTBHDi/9R/I20C7s7lsBd4ZD6ETroZxsHnlq7KxHyz9XxvZmfF9eMmUp3ca/a skSdRW0s/+THWpvMQkN638Y7g7qry9+rMGO+sEVjCp/j7060O1fU5iJqkuwOR0CSOp RNGmu8/d8fUjYxeh4MV4ZwVnWA+cD5nyYQ3dqCJs= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C46A339C0003 for ; Wed, 28 Apr 2021 03:30:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C46A339C0003 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13S3UEv7017300 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 23:30:19 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13S3UEv7017300 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7F76B1E940; Tue, 27 Apr 2021 23:30:14 -0400 (EDT) Subject: Re: [PATCH 17/43] Add as_lval argument to expression evaluator To: Zoran Zaric , gdb-patches@sourceware.org, Tom Tromey References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-18-Zoran.Zaric@amd.com> Message-ID: <7d87f968-fbb5-2fe2-91e7-a0f61eeda614@polymtl.ca> Date: Tue, 27 Apr 2021 23:30:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301144620.103016-18-Zoran.Zaric@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 28 Apr 2021 03:30:14 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Tom, Up to here (patch 17), I think that Zoran's patches are a good cleanup of the DWARF expression evaluation system that we could merge regardless of what follows, do you agree? From your review of the previous version of the series, that's what I understood but I want to make sure. It would make things a bit easier if we finished addressing the comments on these first 17 patches and got them merged without waiting for the whole series to be reviewed. Simon