From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1567 invoked by alias); 13 Oct 2009 08:48:26 -0000 Received: (qmail 1557 invoked by uid 22791); 13 Oct 2009 08:48:25 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from qw-out-1920.google.com (HELO qw-out-1920.google.com) (74.125.92.148) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 08:48:21 +0000 Received: by qw-out-1920.google.com with SMTP id 5so4015627qwc.24 for ; Tue, 13 Oct 2009 01:48:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.11.147 with SMTP id t19mr2538810qct.28.1255423700090; Tue, 13 Oct 2009 01:48:20 -0700 (PDT) In-Reply-To: <4AD34D7C.2030309@vmware.com> References: <1255095434-30271-1-git-send-email-freephp@gmail.com> <4ACFB7AB.6030708@vmware.com> <7d77a27d0910120059x23aae91dv66baaf44ff74c15a@mail.gmail.com> <4AD34D7C.2030309@vmware.com> From: Jiang Jilin Date: Tue, 13 Oct 2009 08:48:00 -0000 Message-ID: <7d77a27d0910130148k4afee99en67ac2f3bff35d73b@mail.gmail.com> Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord. To: Michael Snyder Cc: Hui Zhu , gdb-patches ml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00264.txt.bz2 On Mon, Oct 12, 2009 at 11:38 PM, Michael Snyder wrote: > Jiang Jilin wrote: >> >> Hi Michael, >> >> Is this small patch acceptable? If yes, please tell me who can help me >> check it in, >> you know, I've no write permission. > > Cool, I think Hui, Joel and I all approved this patch. > I'll check it in -- consider it committed. Thank you all! >> On Sat, Oct 10, 2009 at 6:22 AM, Michael Snyder >> wrote: >>> >>> Jiang Jilin wrote: >>>> >>>> 2009-10-09 =A0Jiang Jilin =A0 >>>> >>>> =A0 =A0 =A0 * i386-tdep.c (i386_process_record): Add xgetbv/xsetbv >>>> instructions >>>> support >>>> --- >>>> =A0gdb/i386-tdep.c | =A0 13 +++++++++++++ >>>> =A01 files changed, 13 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c >>>> index b79bcd2..1efe07f 100644 >>>> --- a/gdb/i386-tdep.c >>>> +++ b/gdb/i386-tdep.c >>>> @@ -5172,6 +5172,19 @@ reswitch: >>>> =A0 =A0 =A0 =A0 break; >>>> =A0 =A0 =A0 =A0 /* lgdt */ >>>> =A0 =A0 =A0 case 2: >>>> + =A0 =A0 =A0 =A0 if (ir.mod =3D=3D 3) >>>> + =A0 =A0 =A0 =A0 =A0 { >>>> + =A0 =A0 =A0 =A0 =A0 =A0 /* xgetbv */ >>>> + =A0 =A0 =A0 =A0 =A0 =A0 if (ir.rm =3D=3D 0) >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 { >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG >>>> (X86_RECORD_REAX_REGNUM); >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG >>>> (X86_RECORD_REDX_REGNUM); >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break; >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 } >>>> + =A0 =A0 =A0 =A0 =A0 =A0 /* xsetbv */ >>>> + =A0 =A0 =A0 =A0 =A0 =A0 else if (ir.rm =3D=3D 1) >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 break; >>>> + =A0 =A0 =A0 =A0 =A0 } >>>> =A0 =A0 =A0 =A0 /* lidt */ >>>> =A0 =A0 =A0 case 3: >>>> =A0 =A0 =A0 =A0 if (ir.mod =3D=3D 3) >>> >>> Jiang (is that how you would like to be addressed?) >>> >>> This change looks OK to me in principle, but I'm not qualified >>> to judge its technical correctness. =A0I would like to get Hui >>> Zhu's opinion. >>> >>> Nice job on the formatting and coding conventions! >>> ;-) >>> >>> Michael >>> >>> >>> >>> >>> >> >> >> > > --=20 Jiang