From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67605-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19215 invoked by alias); 12 Oct 2009 08:00:22 -0000
Received: (qmail 19201 invoked by uid 22791); 12 Oct 2009 08:00:20 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f178.google.com (HELO mail-qy0-f178.google.com) (209.85.221.178)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Oct 2009 08:00:16 +0000
Received: by qyk8 with SMTP id 8so8108111qyk.24         for <gdb-patches@sourceware.org>; Mon, 12 Oct 2009 01:00:15 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.33.15 with SMTP id f15mr2345169qcd.59.1255334415181; Mon,  	12 Oct 2009 01:00:15 -0700 (PDT)
In-Reply-To: <4ACFB7AB.6030708@vmware.com>
References: <1255095434-30271-1-git-send-email-freephp@gmail.com>  	<4ACFB7AB.6030708@vmware.com>
From: Jiang Jilin <freephp@gmail.com>
Date: Mon, 12 Oct 2009 08:00:00 -0000
Message-ID: <7d77a27d0910120059x23aae91dv66baaf44ff74c15a@mail.gmail.com>
Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.
To: Michael Snyder <msnyder@vmware.com>
Cc: Hui Zhu <teawater@gmail.com>, gdb-patches ml <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00228.txt.bz2

Hi Michael,

Is this small patch acceptable? If yes, please tell me who can help me
check it in,
you know, I've no write permission.

Thanks!

On Sat, Oct 10, 2009 at 6:22 AM, Michael Snyder <msnyder@vmware.com> wrote:
> Jiang Jilin wrote:
>>
>> 2009-10-09 =A0Jiang Jilin =A0<freephp@gmail.com>
>>
>> =A0 =A0 =A0 =A0* i386-tdep.c (i386_process_record): Add xgetbv/xsetbv in=
structions
>> support
>> ---
>> =A0gdb/i386-tdep.c | =A0 13 +++++++++++++
>> =A01 files changed, 13 insertions(+), 0 deletions(-)
>>
>> diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
>> index b79bcd2..1efe07f 100644
>> --- a/gdb/i386-tdep.c
>> +++ b/gdb/i386-tdep.c
>> @@ -5172,6 +5172,19 @@ reswitch:
>> =A0 =A0 =A0 =A0 =A0break;
>> =A0 =A0 =A0 =A0 =A0/* lgdt */
>> =A0 =A0 =A0 =A0case 2:
>> + =A0 =A0 =A0 =A0 if (ir.mod =3D=3D 3)
>> + =A0 =A0 =A0 =A0 =A0 {
>> + =A0 =A0 =A0 =A0 =A0 =A0 /* xgetbv */
>> + =A0 =A0 =A0 =A0 =A0 =A0 if (ir.rm =3D=3D 0)
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 {
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG (X86_REC=
ORD_REAX_REGNUM);
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 I386_RECORD_ARCH_LIST_ADD_REG (X86_REC=
ORD_REDX_REGNUM);
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
>> + =A0 =A0 =A0 =A0 =A0 =A0 /* xsetbv */
>> + =A0 =A0 =A0 =A0 =A0 =A0 else if (ir.rm =3D=3D 1)
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
>> + =A0 =A0 =A0 =A0 =A0 }
>> =A0 =A0 =A0 =A0 =A0/* lidt */
>> =A0 =A0 =A0 =A0case 3:
>> =A0 =A0 =A0 =A0 =A0if (ir.mod =3D=3D 3)
>
> Jiang (is that how you would like to be addressed?)
>
> This change looks OK to me in principle, but I'm not qualified
> to judge its technical correctness. =A0I would like to get Hui
> Zhu's opinion.
>
> Nice job on the formatting and coding conventions!
> ;-)
>
> Michael
>
>
>
>
>



--=20
Jiang