From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3308 invoked by alias); 30 Aug 2009 23:53:08 -0000 Received: (qmail 3299 invoked by uid 22791); 30 Aug 2009 23:53:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-qy0-f171.google.com (HELO mail-qy0-f171.google.com) (209.85.221.171) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 23:53:01 +0000 Received: by qyk1 with SMTP id 1so2341767qyk.23 for ; Sun, 30 Aug 2009 16:52:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.29.85 with SMTP id p21mr1320982qcc.101.1251676379095; Sun, 30 Aug 2009 16:52:59 -0700 (PDT) In-Reply-To: References: <7d77a27d0908300813p78945f1cv8597e9ee675e959@mail.gmail.com> <7d77a27d0908301639w3b6e0137l438b0fda32dd0264@mail.gmail.com> From: Jiang Jilin Date: Mon, 31 Aug 2009 00:32:00 -0000 Message-ID: <7d77a27d0908301652t570159a6ncf4adf479a47ddc5@mail.gmail.com> Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c To: Hui Zhu Cc: gdb-patches ml , Michael Snyder Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00571.txt.bz2 On Mon, Aug 31, 2009 at 7:43 AM, Hui Zhu wrote: > On Mon, Aug 31, 2009 at 07:39, Jiang Jilin wrote: >> On Sun, Aug 30, 2009 at 11:22 PM, Hui Zhu wrote: >>> On Sun, Aug 30, 2009 at 23:13, Jiang Jilin wrote: >>>> On Sun, Aug 30, 2009 at 9:15 PM, Hui Zhu wrote: >>>>> Hi guys, >>>>> >>>>> =A0 if (tmpu32 > 499) >>>>> =A0 =A0 { >>>>> =A0 =A0 =A0 printf_unfiltered (_("Process record and replay target do= esn't " >>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "support syscal= l number %u\n"), tmpu32); >>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "support syscal= l number %u\n"), (unsigned) tmpu32); >>>>> =A0 =A0 =A0 return -1; >>>>> =A0 =A0 } >>>>> >>>> >>>> Sorry, it's not clear to me. >>>> >>>> when looking into the code, I found the type of tmpu32 is uint32_t, >>>> why did the gcc complain "warning: unsigned int format, uint32_t arg >>>> (arg 2)"? >>>> >>>> %u doesn't mean unsigned int? >>>> >>> >>> Really? =A0what does it mean? >> >> I mean without your patch, the type of tmpu32 _is_ uint32_t, why did >> gcc complain? and when you cast it to unsigned, the warning >> disappeared? >> > > I am not sure the unit32_t in cygwin. =A0But it looks like uint32_t is > not unsigned int in cygwin. > And "unsigned" is seems "unsigned int". If it's true, that is, uint32_t is not unsigned int in cygwin, I think there is a bug in cygwin, we should redefine the uint32_t to real unsigned int, shouldn't we? --=20 Thanks Jiang