From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25876 invoked by alias); 28 Aug 2009 00:14:37 -0000 Received: (qmail 25868 invoked by uid 22791); 28 Aug 2009 00:14:36 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-qy0-f195.google.com (HELO mail-qy0-f195.google.com) (209.85.221.195) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Aug 2009 00:14:29 +0000 Received: by qyk33 with SMTP id 33so1142757qyk.24 for ; Thu, 27 Aug 2009 17:14:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.111.195 with SMTP id t3mr312461qcp.44.1251418467644; Thu, 27 Aug 2009 17:14:27 -0700 (PDT) In-Reply-To: <4A96C677.5060402@vmware.com> References: <1251342694-17525-1-git-send-email-freephp@gmail.com> <4A96C677.5060402@vmware.com> Date: Fri, 28 Aug 2009 00:58:00 -0000 Message-ID: <7d77a27d0908271714j7d69c551ob7791d8ef2097720@mail.gmail.com> Subject: Re: [PATCH] fixed the memory leak in record.c From: Jiang Jilin To: Michael Snyder Cc: "teawater@gmail.com" , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00499.txt.bz2 On 8/28/09, Michael Snyder wrote: > Jiang Jilin wrote: >> * record.c (record_list_release_next) : fixed memory leak when record >> type is record_reg >> >> Signed-off-by: Jiang Jilin > > Looks correct to me, though I'd like to hear "ok" from Hui Zhu too. Sorry, my patch is not OK, and Hui has added a new patch. But he hasn't checked in his new patch. > The change is short enough to accept without a copyright assignment. > > For future reference, we like to see a full ChangeLog entry with a > header that would look something like this (it's ok this time): > > 2009-08-27 Jiang Jilin > > * record.c (...): ... > > Thank you! I got it, thank you! >> --- >> gdb/record.c | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/gdb/record.c b/gdb/record.c >> index 8afca6b..07e9e80 100644 >> --- a/gdb/record.c >> +++ b/gdb/record.c >> @@ -158,9 +158,10 @@ record_list_release_next (void) >> { >> rec = tmp->next; >> if (tmp->type == record_reg) >> - record_insn_num--; >> - else if (tmp->type == record_reg) >> - xfree (tmp->u.reg.val); >> + { >> + record_insn_num--; >> + xfree (tmp->u.reg.val); >> + } >> else if (tmp->type == record_mem) >> xfree (tmp->u.mem.val); >> xfree (tmp); > > -- Regards, Jiang