From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52808 invoked by alias); 19 Feb 2019 02:41:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52784 invoked by uid 89); 19 Feb 2019 02:41:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:738, H*u:1.3.6, H*UA:1.3.6 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Feb 2019 02:41:32 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x1J2fP6r006321 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 18 Feb 2019 21:41:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 92B651E654; Mon, 18 Feb 2019 21:41:25 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 1587C1E16B; Mon, 18 Feb 2019 21:41:24 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 19 Feb 2019 02:41:00 -0000 From: Simon Marchi To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Define gdb.Value(bufobj, type) constructor In-Reply-To: <20190218080636.02e3847f@f29-4.lan> References: <20190218075816.6f67f3d9@f29-4.lan> <20190218080636.02e3847f@f29-4.lan> Message-ID: <7d6aac0f626a0c5f75108978b3b9a589@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00297.txt.bz2 On 2019-02-18 10:06, Kevin Buettner wrote: > +/* Convert a python object OBJ with type TYPE to a gdb value. The > + python object in question must conform to the python buffer > + protocol. On success, return the converted value, otherwise > + nullptr. */ > + > +static struct value * > +convert_buffer_and_type_to_value (PyObject *obj, struct type *type) > +{ > + Py_buffer_up buffer_up; > + Py_buffer py_buf; > + > + if (PyObject_CheckBuffer (obj) > + && PyObject_GetBuffer (obj, &py_buf, PyBUF_SIMPLE) == 0) > + { > + /* Got a buffer, py_buf, out of obj. Cause it to released > + when it goes out of scope. */ Seems to be missing a "be" in "Cause it to be released". Simon