From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MBcHOac/aGc7uSkAWB0awg (envelope-from ) for ; Sun, 22 Dec 2024 11:34:47 -0500 Received: by simark.ca (Postfix, from userid 112) id E78821E097; Sun, 22 Dec 2024 11:34:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 98DCC1E091 for ; Sun, 22 Dec 2024 11:34:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4F7D23858424 for ; Sun, 22 Dec 2024 16:34:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F7D23858424 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) by sourceware.org (Postfix) with ESMTPS id 1310D385843D for ; Sun, 22 Dec 2024 16:34:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1310D385843D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1310D385843D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734885257; cv=none; b=wuhefjPRsjulzpDMH91pNYW8TNAdtuk8gSBVOz9YBj/T3q2E1wZygM3/q6WyaZvb0szDBRGhjetbpWBifl+tVAcLHRLvlX9TqJWUG8JMTYqQXoniZfJj8OYZzrr96bOCA7XOwYmqEkiZbjk1sMYNayDPMxG3uZ05wKWPydUqjZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734885257; c=relaxed/simple; bh=FmoZUZE0bJDEZll2r0nEZ2WtA2NjCmcTBwqgMnWVq1I=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=alkLN3XAiUqyDThhWPmnBQppVmSdOzk3RgSp4KHPL67KqgPc11KrG703lghn7L3soaLeogfFXqLLMqkmfwTgnLV3vbqRfvaGh6QjUWL2dnCKDCnBxICGJRiD2dZQxj5HbTd8iq5ZCgUEjP7g3EEtlq1vND4OCD0ByPvmAiljshE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1310D385843D Received: from [10.38.1.213] (unknown [113.120.165.207]) by APP-01 (Coremail) with SMTP id qwCowAC3vtKGP2hn861fAw--.4934S2; Mon, 23 Dec 2024 00:34:14 +0800 (CST) Message-ID: <7d4a9fc3-bdd3-4230-964b-54a5b5ea4334@iscas.ac.cn> Date: Mon, 23 Dec 2024 00:34:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/jit: fix jit-reader linetable integrity To: gdb-patches@sourceware.org Cc: tom@tromey.com, simon.marchi@polymtl.ca References: <20241222163153.11297-1-liuyang22@iscas.ac.cn> From: Yang Liu In-Reply-To: <20241222163153.11297-1-liuyang22@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: qwCowAC3vtKGP2hn861fAw--.4934S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Aw1rKrWxCryktry5tr17Awb_yoW8Gr4xpa s5u3y3Kr95GFyfA3W7tayvvFy09r90gFy3u3y8Wry8Jr42qFyvqFWvyw4Yk3WxAr1vyr4j qFs8Z3yUZrZ8uFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkIb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26r4j6r4UJwAac4AC62xK8xCEY4vEwIxC4wAS0I0E0xvYzxvE52x0 82IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxAI w28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJw CI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8yE_tUUUUU== X-Originating-IP: [113.120.165.207] X-CM-SenderInfo: 5olx5tdqjsjq5lvft2wodfhubq/ X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Sorry, forgot to put a v2 in the title, please ignore this one. On 2024/12/23 00:31, Yang Liu wrote: > The custom linetable functionality in GDB's JIT Interface has been broken > since commit 1acc9dca423f78e44553928f0de839b618c13766. > > In that commit, linetables were made independent from the objfile, which > requires objfile->section_offsets to be initialized. However, section_offsets > were never initialized in objfiles generated by GDB's JIT Interface > with custom jit-readers, leading to GDB crashes when stepping into JITed code > blocks with the following command already executed: > > jit-reader-load libmygdbjitreader.so > > This patch fixes the issue by initializing the minimum section_offsets required > for linetable parsing procedures. > --- > gdb/jit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/jit.c b/gdb/jit.c > index 77d41bf86ba..21c17c145c9 100644 > --- a/gdb/jit.c > +++ b/gdb/jit.c > @@ -665,6 +665,8 @@ jit_object_close_impl (struct gdb_symbol_callbacks *cb, > > objfile *objfile = objfile::make (nullptr, current_program_space, > objfile_name.c_str (), OBJF_NOT_FILENAME); > + objfile->section_offsets.push_back (0); > + objfile->sect_index_text = 0; > objfile->per_bfd->gdbarch = priv_data->gdbarch; > > for (gdb_symtab &symtab : obj->symtabs)