From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O0w2DlCaDmZaHSMAWB0awg (envelope-from ) for ; Thu, 04 Apr 2024 08:17:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DLdmBbr5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 22DE01E0C0; Thu, 4 Apr 2024 08:17:20 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 03C381E030 for ; Thu, 4 Apr 2024 08:17:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63F39385840A for ; Thu, 4 Apr 2024 12:17:17 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 29FBE3858C98 for ; Thu, 4 Apr 2024 12:16:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29FBE3858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29FBE3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712233017; cv=none; b=Ahn3aNbYTizJkRvXXKxB603I/47CPlq1rSnHR3osMxbRRHA8nzQcOPlqhI2EUKWfhTlAygobaozhHN8HmiiX8Q0ex1B0hhPJ8Sdzhd+83nf2tJ7JOBMr7yaiDR4UaKM//Mc9hz6GZCE9gDMAqFscfqaedbCTZPQeIwcd3hwtAx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712233017; c=relaxed/simple; bh=c85DO2i24ygwUh0bR7vwfJmS4PvbUOjljcZBrr3tOe8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=s/3Ezfn9dBsIn/+x5b77uDk49+QjeDI3gbwDq+YY4aUZwMU3Zy/78KlLUhGJNu67hcJyDoRq6Cfd4FkqzQ8NcnrLStKqlLT/qCqBolLiF3PxriFAM79tiWg3pr8L0JNRej/GH84tAYyV/sSP2FTl8iuMIRmSU4nfks2IKyyXkQA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712233012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F/YcLHyGnmbVu/CP4KjoCiu8wyoBcFrjPOGzskZSx+8=; b=DLdmBbr5af5oF4KA9KxUDyLZkaIcLsv9hEcV47fUcYVHbBGzqB2NBAJ7Vn8Qstx81Psy3P WW7JbgZE5alxCiRokvxzF7sy1U0oYeVkEnQR/51fY6nkhmbM2OYZy1e3L5xqbsPH0SfDnZ WzkTujj4diiwGvQYgV37qZ/t05ArRcg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-4XE4PC8mOse8Tk7DsegAbA-1; Thu, 04 Apr 2024 08:16:51 -0400 X-MC-Unique: 4XE4PC8mOse8Tk7DsegAbA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6991ed0748fso34642996d6.0 for ; Thu, 04 Apr 2024 05:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712233010; x=1712837810; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F/YcLHyGnmbVu/CP4KjoCiu8wyoBcFrjPOGzskZSx+8=; b=mursUfV/z1Y4b25YH4qhPlAFi0P5TBFxSyzWVzZFbKo3kXcZwl9wdsrmbZJMIktxyw 5DiNzbKSuG/HhTJIu8Mnw9BuJxRIDzY5DZ1GyRG2Dj6BPjiU0uSkIwWAuUI5YzHMK3Nu 0j12bnMq/bX6aYTq/DJqdj0e+1Rmj29wGWRqS5whf/S8EkAqf7H6he9Kfoq/G0QxxIyR IEg0CNpPrdXWUsdkOF4AY7kHOckpL23s3iIXe1zWZTNMa8JqG0+4DfG9SEm04K4l2zZe frEvcJLoexArM17RojGiGnkEATQeiWuxkYn8X/69Y40oxAy2s8O5So94b/w8zd2PUqUK 50BQ== X-Gm-Message-State: AOJu0YxAN/p3vyZr0zmc3ZNYMRxnAaAn+JInC2cEoXWn2WE9Dt1kGZCF t+D8hCJPZI3t14ibqia680nFx9MPuBhwHLRAmqeiEVF48wu+9DeuavzXMMUUT/2IixY7a0vrO3L V8wuAQpIKJuo7HZDylfiKNO7duOMeGDaxFmlBYF+JbZIkV5drjVPStTuvMKDFzF6bThXA6A== X-Received: by 2002:ad4:4dc7:0:b0:696:20b8:cfc5 with SMTP id cw7-20020ad44dc7000000b0069620b8cfc5mr8556235qvb.6.1712233010699; Thu, 04 Apr 2024 05:16:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgn/r59ws26kTAvojHBosU87pbqo7heDW752xHD94GgJwaWze9qlWN3FVTNqMupJdlxv+Xgg== X-Received: by 2002:ad4:4dc7:0:b0:696:20b8:cfc5 with SMTP id cw7-20020ad44dc7000000b0069620b8cfc5mr8556212qvb.6.1712233010394; Thu, 04 Apr 2024 05:16:50 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1002? ([2804:14d:8084:92c5::1002]) by smtp.gmail.com with ESMTPSA id ib9-20020a0562141c8900b006961d023d2fsm7383053qvb.17.2024.04.04.05.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 05:16:50 -0700 (PDT) Message-ID: <7d497864-4bef-4f95-bab5-1bf9cbee7000@redhat.com> Date: Thu, 4 Apr 2024 09:16:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Change message when reaching end of reverse history. To: Eli Zaretskii , "Metzger, Markus T" Cc: gdb-patches@sourceware.org, achronop@gmail.com References: <20240313204830.2521708-1-achronop@gmail.com> <50e7e7f5-024b-4ac8-be5c-948ad2f41e73@redhat.com> <8634s18vdh.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <8634s18vdh.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 4/4/24 04:00, Eli Zaretskii wrote: >> From: "Metzger, Markus T" >> CC: "gdb-patches@sourceware.org" , "Alex >> Chronopoulos" , Guinevere Larsen >> Date: Thu, 4 Apr 2024 06:22:14 +0000 >> >> I see no reason for changing the existing portion. The message is short enough: I didn't either, but after my email I found a group of people internal to redhat to ask about this (they are developers but not GDB users, so as fresh a set of eyes as we can ask for) and someone read 'no more reverse-execution history' as if GDB had somehow lost track of it or it had been corrupted. The alternative wording suggested was:     end of history. Recording will continue. >> >> No more reverse-execution history. Recording will continue. >> >> Eli, are you OK with that change? > I don't think I ever chimed into this discussion, and I'm not sure I > even understand the issue well enough. But just on the face of it: > doesn't a bare "Recording will continue" fail to say anything about > the execution, which AFAIU also switches to some other mode in this > case? From a regular user's viewpoint, the execution never switched states, so explicitly saying it will change back will confuse the user more than help. If GDB said, for instance, "changing to replay mode" when the user first steps backwards, then it would make sense to specify that we're back at recording mode, but since we don't do that (and I want to minimize behavior change), I think we should not explicitly say behavior was changed. > > If the above makes no sense, would someone please explain in more > detail what was the original issue, and I will try to come up with a > better suggestion. > The original issue is that when a user is in replay mode going forward, and they hit the message "no more reverse-execution history", some interpret that message as 'you can no longer execute forward' instead of the intended 'if you continue executing, we will do new things and record them, instead of just replaying what was already done'. -- Cheers, Guinevere Larsen She/Her/Hers