Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint

Simon Marchi via Gdb-patches
2023-01-05T16:37:00Z

On 1/5/23 11:31, Tom de Vries wrote:
> On 1/5/23 17:28, Simon Marchi wrote:
>> On 1/5/23 04:04, Tom de Vries wrote:
>>> On 1/3/23 20:22, Simon Marchi via Gdb-patches wrote:
>>>> - -re "$gdb_prompt $" {
>>>> - if { $print_fail } {
>>>> - fail $test_name
>>>> - }
>>>> - return 0
>>>> - }
>>>
>>> This caused:
>>> ...
>>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: gdb_breakpoint: set breakpoint at 1
>>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: !$breakpoint_at_missing_lineno_set
>>> FAIL: gdb.go/methods.exp: going to first breakpoint (the program exited)
>>> FAIL: gdb.go/methods.exp: going to second breakpoint (the program is no longer running)
>>> ...
>>>
>>> Re-inserting this piece of code fixes it.
>>
>> Ah, sorry for this, and thanks for reporting. The CI test job I usually
>> use is a bit broken right now, so I don't test as well as I should.
>
> Ah, that's too bad, I hope you get it running properly again.
>
>> Does the patch below look good?
>>
>
> LGTM, thanks.
>
> - Tom

Thanks, pushed.

Simon