From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91195 invoked by alias); 18 May 2018 20:50:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91184 invoked by uid 89); 18 May 2018 20:50:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=yyyymmdd, yyyy-mm-dd, remote.c, remotec X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 20:50:27 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id E1.00.01293.09C3FFA5; Fri, 18 May 2018 22:50:25 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC019.ericsson.se (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 22:50:24 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 22:50:24 +0200 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 22:50:23 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by SN6PR15MB2398.namprd15.prod.outlook.com (52.135.65.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 20:50:21 +0000 Subject: Re: [PATCH 02/10] remote: Eliminate remote_hostio_close_cleanup To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-3-palves@redhat.com> From: Simon Marchi Message-ID: <7d38b865-691c-7584-1cfa-e03bb5e0e3b2@ericsson.com> Date: Fri, 18 May 2018 21:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-3-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0801CA0010.namprd08.prod.outlook.com (10.161.215.148) To SN6PR15MB2398.namprd15.prod.outlook.com (52.135.65.146) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:SN6PR15MB2398; X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2398;3:UHe3BK8urqDcp4vX8wuLwp2oUy0eP1gwrhKNAxzo5ynJmDiFk/NL9upAVI6jM70P2KbYNhcIQsdZGv7kRpz0GZQQY1hMibcZwp21tu1rxHiPROnbdX7h8yGzWzqz/nu/Z1fAMCn4dMqKCvxctyhhIg44aHZ2VWfjlEIEfWQeLMMlHb0grtjz90Sp5JNHcVxevtIaeSu3rzh3P7OdnYnCW99HFAEH+rAXKIVoiRWuuBMeUtpr+f2jEJDUxtPluuZH;25:fz+voDE3VxyPQxe//gDk9gBYFMKCWoOQ3zK98zyDuaDofvgjbXW39H35KT8QJqp/Um5iwAKpT9OCbL01BYNw+GtjFSAOh4CEH/+AYDCkltJcbAh3CoL67kR179Mat1EpPT6FfLBAfd/Hn3meyhGjY/7Qi/8Rkl6rnTvs1uQMDUWjO8wBY8NVyUkiBEYDS+Rl8GWOuzgUe3QdQMX3oAfL1H/AF6pXMuk/4+A5x6aFgyD4n1tYXKCN/vxeg1kDM9vTtZFCPzwp1vxv/w7Z5omzwH3EEhlUUBOa2YWCobPVc8/yvr0OBrCVA54wHjj8pvUMSDHzybvJtoRAnJHhbluuDw==;31:rp6+7a+zd6D503+75NWBEArx2PqNj+1yfkSt/4shIde4PpP0i6+B85CziXl+Ml+qUe6eLDnNtABLTUMdwQoMhDkp/tj1pqEQ2dPUEm7d5XUa3YalSZSFaHCuFDBkoToPN6rac1certnlo7i3WyxlQJlH+hNIzyxAkLYeJ9BcK0SDXDppU5H5MoB/4pq4Ws/qJfEyIMcwWX6CyY/xHVeretlBx4TRMn4W9cJn8WLArC8= X-MS-TrafficTypeDiagnostic: SN6PR15MB2398: X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2398;20:tcIr+bhTeS9ogGWd7ub2XVn8pQZRlroxJtMGhx5BRbuUymh4rm/GdVHYc/qDRGQiJ9ZSwmOpwB5VlWf4f8nTcXHs1brosN0I4dM2x/Z2kAQ1uf6QFY7L/mRycXBeGnttlC8VpYkBtsRcr1lH8uBrNA9aUsl56ysthnJ+BCSsdi4Olvqrswp/n7T7/SCfw5arYw2kncClQgWIDYyEWjs68FsW+aA/qGqxlwKibAX23ODoRhNQdatFzb/3OunDTMTw5z64natLVYJ9CmUDrEPvQl6Ir7MyrfBBY5pBa4xSXBwqr5tj+I9265tEggJbh3BE4V1GsLQLFwjdNW6f6LzN619Q7phuvsLX1KlxVW7bADigsYDKikReOpkh2lh2443prawmdWzdSaankb0VBpVdfIx3ZoqiGLvdS/rtkSO0axWcIBAQhiU82T4hFc3FSZVcKlpoH9FujUJ432KzgPn0aY45DdxNHUgrf2HigGOCVW8+vQwsadx2hu1hqde4SVoB;4:D4Ww9B2nFg+ADdD1tNGTB8Qrhoth9lE7JNHc7M6f9/3jvreZI/dMx/LLcE5L1SdIsRVNZxb43nUqEQNrjFWwrL2Lzs0KJVxZoZkfRec29A4rRLJ3pLPsvsKopqLsFiEL/PuzoZOvuvRcV6M6AohXySl/o/NaCfKC7ppKZk1qAioVi2LALFkmWos3yy4PpCohCsyjy6lQn68g0FvbgR4OtY5kN8ZXlAqKQIwZyMH9OGyKUwKlc5Xo1fGP9VRJ8kEGuNcsMSLJQm4rISliGLDIOg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:SN6PR15MB2398;BCL:0;PCL:0;RULEID:;SRVR:SN6PR15MB2398; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6049001)(39380400002)(376002)(39860400002)(396003)(346002)(366004)(54534003)(377424004)(199004)(189003)(106356001)(8936002)(105586002)(2906002)(31686004)(81156014)(6486002)(90366009)(36756003)(58126008)(65826007)(5660300001)(229853002)(16576012)(81166006)(316002)(8676002)(558084003)(956004)(2616005)(66066001)(65806001)(486006)(50466002)(11346002)(476003)(446003)(6246003)(25786009)(16526019)(76176011)(186003)(44832011)(47776003)(65956001)(26005)(478600001)(23676004)(52146003)(52116002)(53936002)(53546011)(59450400001)(230700001)(386003)(2486003)(31696002)(6666003)(86362001)(3846002)(49976009)(68736007)(7736002)(97736004)(64126003)(6116002)(305945005)(78286006)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR15MB2398;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjE1TUIyMzk4OzIzOlNJbHBXZUdBcHIxSGR3ZGtLV2tLenVxTG9Y?= =?utf-8?B?dVZvcEFLS1BCZ3lIR2svK2VyZXl0NFVVejJ3R3RqWDA3TlJLaHdpWXpIM0Z3?= =?utf-8?B?M0xJcUIzc3RWRERHcVorZDI4TFJybWJVcUFsdFgvQ3dQVmpuL1JLY3FJeFhV?= =?utf-8?B?UEpPZENYL3A4d2daODg1SDVJQUR5ZDJKbUdkaEllWlNUeUp3Q3BqQk9MVjY3?= =?utf-8?B?Nmh3VHFRYzdzS0o0eGpmYTUzRTdOSzNudkJvMUJRZWJ1OFlhSmR3QmkzcDhV?= =?utf-8?B?bGJNWTZpejRVS0FEUlVFWlpXRFNiWVpNSjBRbGRoQjFxUm5Ua3hBMVhwdllU?= =?utf-8?B?Y05CcEpUSHBZblVORW1pM1BlTUFXOUw2NVpYbFFJRW00SFRMcHN2RTNxVFdz?= =?utf-8?B?NXBUbEVoK296SDF6S2xmV3huc0xFRTVlTjhpbE80YmNQVXU3Mi8yOFU0MkRO?= =?utf-8?B?aXJsNjlUMEV2RjZSV3dub3ZQa3RsNjVmNUxSNENjSHNTZW5Tc2Q2TVpXbGFx?= =?utf-8?B?L0FWZ0tTUWdmN3pjQUI4YTk3WndVSzIyVmg0SnQ0di90YUQrdG5UdUxERVN6?= =?utf-8?B?Si9leUZ4eHFML1RJVlAwbWhqVWZYR0RBdENIT05iSnJkck5hQko3RWhsV0ls?= =?utf-8?B?cTZUV29lODRWUHYyelNpZ2FTNGQ1UGVibDVJTkdhNVBzdkFUeXpHQitlbzY4?= =?utf-8?B?QmZvSWJ5RkZ4cEdaaTJ1TzJ6Vis1Mk53Y1NrdmdVTCtocG94Qno4SzZNWlg3?= =?utf-8?B?NmlZL0NiYm13T3laZXBTaDF3VTRGUVZJdzk2K0dSdk04QTJmc0t3cFBSZndS?= =?utf-8?B?QzA3aGVOSUxhNDlYVGNUMldONWZkazdhbUYySEpUN0QxRVg5V0VLUlZ2cU44?= =?utf-8?B?TCt5ejVzaXNDZ0xWRFVzRWFXcHpMREVDK3lIVERGaldVUkxKMCtNaTE4WlJw?= =?utf-8?B?QXlOQTY2UzJIQjUvTHpLWVYrb2VUMVE0V1ltUExyRTV1dExTNG1wbFpLTHAy?= =?utf-8?B?bUNIN3VCSTYzNzdNOEw4RVMrK0NKR0REMUxBTGRlVVBmWldOVlErQVJ6Z1gv?= =?utf-8?B?dzVwOTlyWWlvcTRhb2UxUExTSy80ZElCOEJCTjJsOERCSGdacjZzM2ZMZm9k?= =?utf-8?B?eDJJWk5iNDBKR3VhblV6ZThTM09TZlBxRWZ6N1VTdmFDOThFWTB4MHcxNllW?= =?utf-8?B?Qmpma0dtQ01YWlZLY1NhMkovVHN6WHpIQ1lBZlUyWVFSTDdja1ZwUzlHUG9W?= =?utf-8?B?VEhsU3dkZWtHMWFoMGNVeXZVNjZqYnpqWjBMbkNjYTZPWWpXQlZmVzFPd3BS?= =?utf-8?B?RUlWR0hUYm4rcW1pREJKMk8xODFsZHRtb05xZEp0aWNxOXZkSWRoek5peWRo?= =?utf-8?B?ZzNpb3FVamtoZFRXOEttd09NaW5qNjZqTUViUnlGeUVuaGt5ZC83eTdrajh6?= =?utf-8?B?Rmd0T2o1NVNIbGdycVA5R0ZKejROUjBlZDMvUUNyVVZDSmZYNnI2Q3F4aDBq?= =?utf-8?B?c3NrVXVEWlhOeGVESkRIaTI2S1h0ZE0ybVR1WVhmR0ZhYzZTd0NzT1UrR3BK?= =?utf-8?B?MHZFVGE5N0JGY1dBMnM3S0lWaUFhWnFhUk90VWZNQzdVRkZKYUI1T3ViWmx5?= =?utf-8?B?S29QZTF4M3N5T1htUlBsSmpTUGltV213Rzh3Q2ExUG13ZFcxY2w0MTFnZTlP?= =?utf-8?B?UUp5RHFEYUQ5SHhKa2d0bExPNlBlSThoRHcxWHBBeEtHUGNQZVZkQXpudmor?= =?utf-8?B?MGsxWkEzbC84UktONGp2YndvSHlZNFlNa2F2MEN4TFNFRjhMQkJxWXdnZkFH?= =?utf-8?B?a1V0NVFJV3g3OG9LeXowajJPMzNYdEdOMXk1WEhKUUNIQ3pRK2ttSWVNK0dv?= =?utf-8?B?THN3RGROQitaa2pJN2xZU1JDSGlQRlY5bit0U0pud1RWYmZabFRwQnpObkR3?= =?utf-8?B?ZW52b0t0aUR4b2VXSlRzU1QyRDlWUEhxSEF1NlVIRis5ZXBHTTgwZEswNVcr?= =?utf-8?B?MXJkWFFhOVpUaCtHZzhoajN3c3BSQ0lkUjBXZ2lidnJlZXFta21NSWJzWmV6?= =?utf-8?B?bVcwdERaSmtsaHY0WStrUEtLL0Q5enF6cDZIV1lFdy96ajh6S2JOV1poSWV4?= =?utf-8?B?UG9xT0hUVHR3RTJjSzVoU0ZtYWVhWGcza0Y0MHowR0UweS9RNTFoZ2M1Ujdj?= =?utf-8?Q?31HyH4B4FZkzhODKCbKSZxo1ZRSV10kaK2h+an7XOo=3D?= X-Microsoft-Antispam-Message-Info: J2MrIcUBdr3za8bO09M8BTie1/SSEMRH1PLb5bAwXzYKjixAKycNc/pyDzVKRRYHFqKjVKIgE4dsiFqIjsK2PSdscZg4cz0iI5AAazIf8roTHux0A68fHLhKzk6G/C/IivkYnttXK0mqdWr53WLq3Zf56lrAOA5XOjnFaNQxr/0Xkb13OTRrHcAFp3pw2em9 X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2398;6:A5gp3xBoJXSLopjrRHoi2UnnRNwzTc0hWi0V4AKPJbW/cIZAJ0bIzoJ9eoBoloOjwPlO7XT9lASQq/mKBcQMfHAv1bjW6C0pMyqW2GamEQVyvWgutfGLsIl3m1jeOjaNYcDuVcCgA3l5QETE8odxFL5hzN9iD/P6XX9OoJ+wPjI27GR5RTIjUrLP282LP3TZoVUc8ITVZBB538l/qG5wl5BR8GLrQXJnhx+DCP2UNrfIYXQhY/56CrkkyrQYnsr0RvD3SpyqhFxzXPFL3EbdyRL/0m2qxgLC8w/5GIPYmhXrD8DKPbepGYrFrp9I0Du/IItc318j2Xpkq9Gyi8+nRaisaYfWmc6+GlQTVVK5BfZKpatMh2SQt7LJZGaQHRnTLPWzhnlUSIQvIazQ+clgZ42dDXTFNBCl55oQ0nfDxfvWUtY+hq5D5iyJOXiK37zIdF2R6opSbIprOkN64qQjew==;5:CWU7KA1avtyfMtSjUZlfVlVCcTqXx8jMLgBmWFwtCR0KaA0w21DRlxzIbrrB145l14Dd7gGSv69gMcRscGDCRMb6zDAa+bmQhOpcvT7wIsCEDNSdkxCokbTztY3cMOkg2VnkWvwnsm83+C6lX88z4rROm4LPiZF0ixdXG0d20vY=;24:FUwTSIyI2BxyKxwDjDLFhaZwzOLrlVFAGh3wlgRoVIoXUEd6fLzprExQENTYZH+rtuzg6TxobyIWenDVrWxYEqxWMLEchqb0PyGLffgX8iM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2398;7:ZUJ5TEPPcWCpmClOVgH4LQk/8vMEuxeBW8KKUaOx1+71C1rIiZYaIQDs0lakF7ds/bX02E4efJB54FP6Md7YUCWKrWf87okO9QTxcBwhquJw8CuDHh1dg83k4OLyJP86qEuKSq0DCzKywCLJp9DNO+eiGR1sKOpAjgePbYFVz/AymoI8rAZh3pwSKQpSz6soTHjmmKGRzGBQj7b7Sv/LiS+vHFe+KvD4xUsMUhjOJQVzErnYJpQAl8hszaptZHeq X-MS-Office365-Filtering-Correlation-Id: 9d44ff2d-caa6-41ac-2521-08d5bd00f918 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 20:50:21.6426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d44ff2d-caa6-41ac-2521-08d5bd00f918 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2398 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00421.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * remote.c (remote_hostio_close_cleanup): Delete. > (class scoped_remote_fd): New. > (remote_file_put, remote_file_get): Use it. LGTM, including catching the exception in the dtor. Simon