Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver

Simon Marchi
2020-10-12T14:16:13Z

On 2020-10-12 7:41 a.m., Joel Brobecker wrote:
> I got reports of the nightly source packaging failing soon after
> you pushed this patch, and I was able to reproduce it by configuring
> (out of tree), followed by a "make distclean". I did a "make -C gdb install"
> as well, but I don't think it should have any influence on the outcome.
>
> The error I get is the following:
>
> | Makefile:246: ../gnulib/Makefile.gnulib.inc: No such file or directory
> | make[2]: *** No rule to make target '../gnulib/Makefile.gnulib.inc'. Stop.
> | make[2]: Leaving directory '/[...]/gdb'
>
> Do you think you could look into it?

Ah, that's a case I didn't think of. When make distclean runs, it runs
first in gnulib, so erases gnulib/Makefile.gnulib.inc. When it then
runs in gdb, the Makefile can't run.

So I guess we'll need to make the inclusion condition/non-fatal for this
reason, unless you see another way?

Simon