Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver

Andrew Burgess
2020-10-09T08:34:44Z

* Andrew Burgess <andrew.burgess@embecosm.com> [2020-10-07 16:33:19 +0100]:

> * Simon Marchi <simark@simark.ca> [2020-10-06 10:10:25 -0400]:
>
> > On 2020-10-06 8:17 a.m., Andrew Burgess wrote:
> > > The problem here was me unconditionally trying to include
> > > Makefile.gnulib.inc from the gdb and gdbserver Makefile. The very
> > > first time you run 'make clean' after applying the patch
> > > Makefile.gnulib.inc doesn't exist, but the gdb/gdbserver makefiles
> > > still try to pull the file in unconditionally.
> >
> > If the file is generated at configure-time, I think it would be ok for
> > Makefile.gnulib.inc to be included unconditionally. As when you run
> > "make clean" after pulling some changes, you're supposed to do to it
> > from the top level, so Makefile.gnulib.inc will be created before "make
> > clean" runs in GDB.
>
> OK, I made the include compulsory.
>
> <snip>
>
> >
> > Finally, I don't know if the change was intentional, but the file was
> > previously named Makefile.gnulib.inc and is now named Makefile.gnulib.
> > I liked Makefile.gnulib.inc, as it shows it's not a "top-level"
> > Makefile, it's meant to be included.
>
> I just thought 'Makefile.gnulib.inc.in' was a bit much (in the source
> tree), but I don't really mind. I changed back to use this filename.
>
> The patch below has these two fixes. I'll apply in a couple of days
> unless anyone objects.

I've now pushed this patch.

Thanks,
Andrew