From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61420 invoked by alias); 6 Oct 2017 08:54:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61405 invoked by uid 89); 6 Oct 2017 08:54:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Oct 2017 08:54:34 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 8F01E822FC for ; Fri, 6 Oct 2017 10:54:31 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VOmMkwwQVzjf for ; Fri, 6 Oct 2017 10:54:31 +0200 (CEST) Received: from dhcp-guest-31.act-europe.fr (dhcp-guest-31.act-europe.fr [10.10.127.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 5F27482273 for ; Fri, 6 Oct 2017 10:54:31 +0200 (CEST) Subject: Re: [RFA v3] enable/disable sub breakpoint range To: gdb-patches@sourceware.org References: <83lgks1e1h.fsf@gnu.org> From: Xavier Roirand Message-ID: <7cf5c60b-4bab-1e91-61dd-f580bf417b12@adacore.com> Date: Fri, 06 Oct 2017 08:54:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00129.txt.bz2 Le 10/3/17 à 6:02 PM, Pedro Alves a écrit : > We'd do the same to breakpoint commands, i.e., commands that take > an breakpoint/location list would xref the description of breakpoint > lists. > > See commit 5d5658a1d3c3 ("Per-inferior/Inferior-qualified thread IDs") > for how that looked like before support for '*' ranges was added. > > (And now I wonder whether it'd make sense to model the breakpoint > number parsing on a simplified version of the thread ID number > parsing. See gdb/tid-parse.h / tid_range_parser.) > > Thanks, > Pedro Alves > We have several ways for achieving this, especially when taking the C++ization of the code in account. What do you think would be the best approach: - commit patch I've done as a first step, then propose a new patch including '.*' support ? - write a breakpoint location range parser similar to the tid (for thread) one in pure C style including the '.*' support ? In that case what about the C++ization ? Would it be done in the future ? - Change the patch I've proposed to integrate '.*' support in the new C++ style function I wrote ? Something else ? Regards.